On 16 May 2016 at 14:21, Lisa Nguyen <lisa.ngu...@linaro.org> wrote: > On 12 May 2016 at 03:02, Saul Romero <saul.rom...@arm.com> wrote: >> Hello Daniel: >> Where do you want me to elaborate more about this fix? Is it in the comments >> section so amend the patch? >> Thanks! > > Hi Saul, > > You'd elaborate more about your fix in your commit message. So far > your commit message is, "Changes in cpufreq_06.sh to calculate > summatory and average of frequency measurements, " which doesn't give > Daniel and the others a good idea what you're trying to achieve. As > Daniel suggested, explain what you were seeing before and how your > patch would help solve the bug/issue or improve something. Then it'll > be easier for everyone to give better feedback. > > Also, when you resubmit the patch, please update the subject to "PATCH > PM-QA v2" (or whatever version you're on), so we can look at the > latest one with the updated commit message. > > Sorry for not seeing this sooner. Use the --amend option to update your patch.
Oh, I just noticed that your Signed-off-by line says "Signed-off-by: Saul Romero <saul.rom...@linaro.org>", but you sent your patch from saul.rom...@arm.com. I'm assuming that it's a typo? >> ________________________________________ >> From: Daniel Lezcano <daniel.lezc...@linaro.org> >> Sent: 09 May 2016 09:24:45 >> To: Saul Romero; lisa.ngu...@linaro.org >> Cc: linaro-dev@lists.linaro.org; Basil Eljuse >> Subject: Re: [PATCH PM-QA] Fixed array initializations to calculate freq >> deviation. >> >> On 05/05/2016 12:06 PM, Saul Romero wrote: >>> Changes in cpufreq_06.sh to calculate summatory and >>> average of frequency measurements. >>> >>> Signed-off-by: Saul Romero <saul.rom...@arm.com> >>> --- >> >> Hi Saul, >> >> can you elaborate in the changelog what happens with the current and why >> it must be fixed. Also, a proper fix should not comment the code. >> >> Thanks. >> >> -- Daniel >> >> -- >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >> <http://twitter.com/#!/linaroorg> Twitter | >> <http://www.linaro.org/linaro-blog/> Blog >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-dev
