Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

Reviewers: lemzwerg, marc, Message: On 2012/10/28 07:46:36, marc wrote: On 2012/10/26 13:58:41, lemzwerg wrote: > LGTM. +1 Nice to have this feature available! It is more a pacifier than a feature since it does not actually add any functionality. And I don't want to see anything in our

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

On 2012/10/28 08:47:50, t.daniels_treda.co.uk wrote: David wrote: >> Nice to have this feature available! > > It is more a pacifier than a feature since it does not actually add > any functionality. And I don't want to see anything in our code tree > (except possibly the documentation for i

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

On 2012/10/28 17:38:10, Keith wrote: http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll#newcode95 lily/lexer.ll:95: The inside of \"violin1" is marked by nesting two quote modes as we A start-condi

Re: Doc: NR 5.3 Add \single command (issue 6742057)

On 2012/10/29 08:10:53, J_lowe wrote: Setting to patch-review as I need some more competent devs to look over this new re-arrangement and suggest better/alternative definitions of the commands (if needed). (better) @lilypond examples will come later This is a work in progress to then he

Re: Allow digits in identifiers (issue 6493072)

On 2012/10/29 06:20:17, lemzwerg wrote: LGTM. Nice idea. I'm not sure whether this fits into the large picture w.r.t. syntax normalization as envisioned by David, but at least for me it looks reasonable. Well, I replied on the Google code review as well. In a manner, this is the kind of

Re: Doc: NR 5.3 Add \single command (issue 6742057)

http://codereview.appspot.com/6742057/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/6742057/diff/1/Documentation/notation/changing-defaults.itely#oldcode2192 Documentation/notation/changing-defaults

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

On 2012/10/30 04:06:18, Keith wrote: Well, David has pointed out some shortcomings, but I am not sure if they are practical problems. A "practical problem" presumably is one the user can be bothered about. I never claimed that problem class here. Users are not interested in language design o

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

Actually, I would be perfectly fine with binning both \violin.1 as well as \"violin1". I am just afraid it would be a bit like taking candy from a baby. But if people are fine with the prospect of waiting until \violin1, \violin 1, \violin $(1+1) will all work, then that's likely the cleanest so

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

On 2012/10/30 06:17:30, Keith wrote: On 2012/10/30 06:05:57, dak wrote: > Actually, I would be perfectly fine with binning both \violin.1 > as well as \"violin1". That should be fine. No-one has indicated they would actually use either of these. (But I do use "v

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Please make the indicated convert-ly-like changes. Thanks! http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly File input/regression/measure-counter.ly (right): http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly#newcode20 input

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly File input/regression/measure-counter.ly (right): http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly#newcode1 input/regression/measure-counter.ly:1: \version "2.17.5" Oops: also

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/31 11:41:19, david.nalesnik wrote: David, I don't mind making the changes, but I'm running into some problems. I used git pull -r before making a patch set and uploading to rietveld, but looking over the patch set there I see that other changes have found their way in--includin

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

http://codereview.appspot.com/6730044/diff/40002/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/6730044/diff/40002/ly/engraver-init.ly#newcode88 ly/engraver-init.ly:88: \consists "Footnote_engraver" Any idea where this line is from? It just appears in the la

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/31 11:55:12, david.nalesnik wrote: Thank you--I am a bit worried! Speaking of "patch," when I run git format-patch I get six separate patches. Is there any way to compress them into one so this is more convenient for you? -David Try if you can git send-email to work for you.

Re: Various clean-ups in stems and beams. (issue 6584045)

http://codereview.appspot.com/6584045/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197 lily/beam.cc:197: Grob *me = unsmob_grob (smob); Looking at the combination of this and is_kievan, it would appear that the expected response

Re: Various clean-ups in stems and beams. (issue 6584045)

On 2012/11/03 11:37:08, mike7 wrote: On 3 nov. 2012, at 12:26, mailto:d...@gnu.org wrote: > > http://codereview.appspot.com/6584045/diff/1/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197 > lily/beam.cc:197: Grob *me = unsmob_gr

Re: Gobble empty strings passed as arguments to python scripts. (issue 6819066)

On 2012/11/05 10:58:37, janek wrote: I think it would be helpful to not-so-advanced English speakers if a word more ordinary than "gobble" was used. I am not sure of that. "gobble" is actually pretty established in programmer jargon: From The Jargon File (version 4.4.7, 29 Dec 2003) [jargon

Re: Allow (closed) scheme function calls as text scripts. (issue 6812088)

Reviewers: lemzwerg, thomasmorley65, Message: On 2012/11/05 22:45:06, thomasmorley65 wrote: On 2012/11/05 22:40:36, lemzwerg wrote: > Very nice! Can't review the code. But from description: GREAT It's actually more a fix of a shortcoming. Scheme functions should have worked in most places

Re: Various clean-ups in stems and beams. (issue 6584045)

http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108 > input/regression/note-head-style.ly:108: \override Staff.Dots.style = > #'kievan > Why can't we use the new function here, e.g., > > \kievanOn > \kievenOn only works on the voice level and the

Re: Various clean-ups in stems and beams. (issue 6584045)

On 2012/11/07 05:32:40, mike7 wrote: On 7 nov. 2012, at 00:50, mailto:d...@gnu.org wrote: > > http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108 >> > input/regression/note-head-style.ly:108: \override Staff.Dots.style > = >> > #'kievan >> > Why

Re: Allow (closed) scheme function calls as text scripts. (issue 6812088)

On 2012/11/08 08:28:40, janek wrote: On 2012/11/05 22:45:06, thomasmorley65 wrote: > On 2012/11/05 22:40:36, lemzwerg wrote: > > Very nice! > > Can't review the code. > But from description: > GREAT The same in my case... David, could you add a comment (either to the parser code, or in the co

Re: Add LilyPond Report #28 to news (issue 6828049)

Reviewers: janek, Message: On 2012/11/10 13:52:09, janek wrote: i think we add "web: " at the beginning of website commits. Also, i'd put this announcement below 2.16 announcement (because it's old). Unfortunately, the report is old, but the announcement isn't. If people check the news reg

Re: Applies scheme indentation according to the GNU guidelines (issue 6814080)

Marc Hohl writes: Am 10.11.2012 14:59, schrieb janek.lilyp...@gmail.com: I've looked a bit at one random file. Looks mostly good to me. http://codereview.appspot.com/6814080/diff/1/scm/define-music-display-methods.scm File scm/define-music-display-methods.scm (right): http://coderevi

Uses single algorithm for side-position spacing. (issue 6827072)

http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc File lily/side-position-interface.cc (right): http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc#newcode85 lily/side-position-interface.cc:85: Position next to support, taking into account my o

Re: Uses single algorithm for side-position spacing. (issue 6827072)

On 2012/11/11 15:26:48, mike7 wrote: To be clear, I have no problem implementing a LilyPond documentation and commenting policy to move towards the establishment of an API. This sounds like a worthwhile yet difficult task. I would start talking about this separately from any one patch.

Re: Uses single algorithm for side-position spacing. (issue 6827072)

To make it short: a function needs documentation that tells its purpose in the overall scheme of things (for what purpose is it used), its outline (what does it do), its input and output. A "policy" may describe how they are formatted and whether or not they are used as Scheme documentation strin

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (left): http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely#oldcode170 Documentation/notation/vocal.itely:170: On 2012/11/14 21:53:23, benko.pal wro

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely#newcode221 Documentation/learning/tweaks.itely:221: @var{value}. This must always b

Re: Allow music of nominally zero duration to be typeset. (issue 6810087)

Reviewers: benko.pal, Message: On 2012/11/16 22:13:59, benko.pal wrote: LGTM in the sense that it won't make things worse; I've tried to understand the code but failed, see below. I have not actually tried to understand the code. I just added checks for existing array elements before access

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

http://codereview.appspot.com/6852052/diff/7/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/6852052/diff/7/Documentation/learning/tweaks.itely#newcode226 Documentation/learning/tweaks.itely:226: include it. For more details, s

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

On 2012/11/20 21:39:54, Trevor Daniels wrote: On 2012/11/20 19:08:46, dak wrote: > but I'd suggest reversing the narrative > of the first paragraphs, like I still think this amount of detail is not quite in keeping with the tenor of the Learning Manual. I am bad at keeping wit

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

On 2012/11/20 23:57:36, dak wrote: If you feel you can boil this down into something that is better suited for putting the reader on the right track without exhausting him, feel free to improve this, if necessary skimming over information that is likely to cause more harm than good at this

Doc: Clarify footnotes as articulations (2971) (issue 6845078)

http://codereview.appspot.com/6845078/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6845078/diff/1/Documentation/notation/input.itely#newcode1250 Documentation/notation/input.itely:1250: [@var{direction}] \footnote [@var{

Re: Doc: Clarify footnotes as articulations (2971) (issue 6845078)

On 2012/11/22 11:04:00, Trevor Daniels wrote: That's always the problem when you try to explain rather than just showing what to do, especially with a messy interface like this one. Basically we got one interface now, with two essentially different behaviors depending on whether the last argum

Re: Doc: new syntax for \tweak, \override (2936) (issue 6852052)

On 2012/11/23 23:51:13, Trevor Daniels wrote: https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-default

Re: Issue 2916: Document \hide and \omit (issue 6851102)

Reviewers: Trevor Daniels, thomasmorley65, http://codereview.appspot.com/6851102/diff/3001/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/6851102/diff/3001/Documentation/learning/tweaks.itely#newcode1499 Documentation/learning

Re: markup-commands rest-by-number and rest (issue 6850073)

On 2012/11/26 11:37:26, benko.pal wrote: I just meant that instead of checking several times whether dealing with multi-measure rest or not, you may convert duration log at a single place (with the caveat of turning a negative sign to 'M' instead of '-'). Probably even without the caveat.

Re: markup-commands rest-by-number and rest (issue 6850073)

On 2012/11/26 11:51:03, dak wrote: On 2012/11/26 11:37:26, benko.pal wrote: > I just meant that instead of checking several times whether dealing with > multi-measure rest or not, you may convert duration log at a single place (with > the caveat of turning a negative sign to &#

Re: Issue 2916: Document \hide and \omit (issue 6851102)

On 2012/11/26 21:53:09, Trevor Daniels wrote: I think you've chosen the best way forward here. Calling a strategic retreat "the best way forward" might be putting a bit of a spin on it. It would have been prohibitively costly for the ground forces to secure the conquered areas. http://codere

T1686 - First patch to allow LilyPond Initialisation to use Guile V2 if required. (issue 6849088)

http://codereview.appspot.com/6849088/diff/1/lily/main.cc File lily/main.cc (right): http://codereview.appspot.com/6849088/diff/1/lily/main.cc#newcode65 lily/main.cc:65: int guile_major_version = 2; I don't think it makes sense to even define a guile_major_version since the executable will only

Re: fix representation switching from line-position to staff-space (issue 6778050)

On 2012/10/30 18:59:49, benko.pal wrote: 2012/10/30 David Kastrup : > Benkő Pál writes: > >> 2012/10/27 : >>> On 2012/10/27 20:34:35, benko.pal wrote: >>> I want staves with line-positions like (-2 0 2 4) work. >> >>> Why would somebody specify (-2 0 2 4) with t

IR: Improve performer documentation (issue 6868047)

Improving the docs certainly is quite worthwhile. https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm File scm/document-translation.scm (right): https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm#newcode21 scm/document-translation.scm:21: ;; type p

Re: markup-commands rest-by-number and rest (issue 6850073)

thomasmorle...@googlemail.com writes: On 2012/11/27 20:03:06, benko.pal wrote: > Did you had a look on the compiled output of the new reg-tests? no. could you push to a dev/ branch? Sorry. I'm still a newbie in devel tasks. If you have a branch where you checked in your changes, you

Re: Doc: cautionary accidentals after a key change (3000) (issue 6872049)

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3324 Documentation/notation/changing

Re: Changes to Kievan documentation (issue 6865049)

https://codereview.appspot.com/6865049/diff/2001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/6865049/diff/2001/Documentation/notation/ancient.itely#newcode2483 Documentation/notation/ancient.itely:2483: @node Kievan note

Re: Doc: cautionary accidentals after a key change (3000) (issue 6872049)

On 2012/12/03 07:30:36, Keith wrote: https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3324 Documentation/notation/changing-defaults.itely:3324: \override Staff.KeyCancellation.break-visibility = #all-invisible On 2012/12/03 06:00:15, dak

Re: Doc: cautionary accidentals after a key change (3000) (issue 6872049)

https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3318 Documentation/notation/changing

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

Reviewers: Trevor Daniels, https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely#newcode902 Documentation/learning/tweaks.itely:902: @e

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

, possibly decimal value On 2012/12/04 22:27:59, dak wrote: On 2012/12/04 21:37:12, Trevor Daniels wrote: > , possibly decimal, Definitely not. "direction" is checked by ly:dir?, and ly:dir? _only_ permits -1, 0, 1, and nothing else. "possibly decimal" is definitely

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

/learning/tweaks.itely:952: @tab A constant vector can be written by writing constants On 2012/12/04 22:27:59, dak wrote: > On 2012/12/04 21:37:12, Trevor Daniels wrote: > > I'd prefer the same form as the other entries, > > just stating what it is, rather than how it might > >

Re: Doc: Clarify documentation of footnotes (2971) (issue 6845078)

http://codereview.appspot.com/6845078/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6845078/diff/8001/Documentation/notation/input.itely#newcode1240 Documentation/notation/input.itely:1240: Although notes inside a chor

Re: Removes '-signs from vectors (issue 6923043)

On 2012/12/11 00:31:04, thomasmorley65 wrote: Please review. I didn't touch the translations. Correct? git grep "#'#" returns one file I don't know what to do with: Binary file Documentation/pictures/baer-sarabande-original.jpg matches Binaries are prone to matching very short strings ra

Re: Doc: Clarify documentation of footnotes (2971) (issue 6845078)

http://codereview.appspot.com/6845078/diff/15001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6845078/diff/15001/Documentation/notation/input.itely#newcode1280 Documentation/notation/input.itely:1280: specifies a type of grob t

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

Ugh, found those unsent "Draft Comments" in my backlog, no idea whether they still apply. Might be worth glancing over. https://codereview.appspot.com/6498077/diff/28/lily/phrasing-slur-engraver.cc File lily/phrasing-slur-engraver.cc (right): https://codereview.appspot.com/6498077/diff/28/lily

Re: Add dead-is-alive boolean property to Hara_kiri_group_spanner (issue 6948058)

Reviewers: lemzwerg, Message: On 2012/12/15 10:48:12, lemzwerg wrote: LGTM. Do we have a regtest (or rather, an example) which demonstrates how to use it? I don't actually have one. Since this was inspired by a discussion on the mailing list, I was sort of hoping that Keith would be able t

Re: Add dead-is-alive boolean property to Hara_kiri_group_spanner (issue 6948058)

On 2012/12/15 18:22:46, Keith wrote: [...] A re-arrangement in logic could give a useful option "If a Staff with the 'alive_together_alternative' flag set has anything interesting to say on this line, but /none/ of his (un-flagged) friends in his keep-alive-together group do, then print him

Re: Add dead-is-alive boolean property to Hara_kiri_group_spanner (issue 6948058)

k-ohara5...@oco.net writes: On 2012/12/15 21:32:41, dak wrote: The "dead-is-alive"-thing had the advantage that even though I did not understand what I am working with, it was easy to make it behave as advertised. "This reverses the decisions that the Hara_kiri_engraver

Re: Issue 2172: Get line and column numbers right. (issue 6938044)

Reviewers: Graham Percival, Message: On 2012/12/16 01:08:31, Graham Percival wrote: could we get something in Changes.tely about this? No need to update this patch; you can push the modification to changse.tely immediately once this patch is accepted. I did not do so on the theory that "b

Re: Add dead-is-alive boolean property to Hara_kiri_group_spanner (issue 6948058)

On 2012/12/17 06:13:22, Keith wrote: On 2012/12/16 08:09:38, dak wrote: That works fine. The input below will show a single staff, except for the one line containing the voice-crossing section, regardless of where the line-breaks fall. (We can do this with current LilyPond using two

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

On 2012/12/17 17:21:39, email_philholmes.net wrote: - Original Message - From: To: ; Cc: ; Sent: Monday, December 17, 2012 11:27 AM Subject: Re: Doc: NR typo for Midi I

Re: Flag an error for isolated post-events occuring in music lists (issue 6929046)

Reviewers: thomasmorley65, Message: On 2012/12/13 01:05:28, thomasmorley65 wrote: Can't review parser-code, but from description: LGTM For the sake of easier understanding I'd have given these examples,though, to show that printing yes/no is more a matter of accident: % fingering is prin

Re: Checks for recursive element behavior (issue 6943072)

On 2012/12/21 07:59:02, MikeSol wrote: Hey all, I'm ok w/ this on the countdown but can someone check out David's suspicion that this slows stuff down by O(n^3)? I definitely won't push this if it slows LilyPond down to a crawl. I am not ok with that. It looks really, really, really ex

Re: Checks for recursive element behavior (issue 6943072)

On 2012/12/22 06:41:06, mike7 wrote: On 21 déc. 2012, at 10:09, mailto:d...@gnu.org wrote: > On 2012/12/21 07:59:02, MikeSol wrote: >> Hey all, > >> I'm ok w/ this on the countdown but can someone check out David's > suspicion that >> this slows stuff down by O(n^3)? I definitely won't push t

Re: Checks for recursive element behavior (issue 6943072)

On 2012/12/22 08:29:59, mike7 wrote: Where in the new code are things being allocated and thrown away temporarily on the heap? What do you think extract_grob_set does? If there is a more efficient way to implement this patch, let me know. It seems, though, that the only way to prevent gr

Re: Tablature: ignore minimumStretch to/from fret zero (issue 6944061)

On 2012/12/23 14:24:31, Carl wrote: I think the whole issue on this "bug" is incorrect. The problem we have is that by using restrain open strings, we are telling lilypond "Don't use open strings". Then by setting minimum-fret to 0, we are saying "Do use open strings." How can we decide

Allows for easier creation of many Lilypond objects via Scheme. (issue 7009047)

All of this is absolutely devastatingly horrible code that is not reconcilable with sane per-session semantics and tampers with LilyPond internals in a way that has bleed-over effects into future files in the same command line. In addition, the interfaces into the exposed internals are absolutely

Re: Allows for easier creation of many Lilypond objects via Scheme. (issue 7009047)

On 2012/12/24 07:28:17, mike7 wrote: On 24 déc. 2012, at 01:10, mailto:d...@gnu.org wrote: > All of this is absolutely devastatingly horrible code that is not > reconcilable with sane per-session semantics and tampers with LilyPond > internals in a way that has bleed-over effects into futur

Re: Allows for easier creation of many Lilypond objects via Scheme. (issue 7009047)

On 2012/12/24 08:10:25, marc wrote: On 2012/12/24 07:28:17, mike7 wrote: > So what I need from you, if you're willing to help me out, are explanations of > how this causes bleedover effects. IIRC, the functions define-session and define-session-public were created for that very reason, so

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode155 Documentation/contributor/doc-work.itexi:155: The correc

Re: Simplify several library functions. (issue 7020044)

Reviewers: lemzwerg, thomasmorley65, Message: On 2012/12/28 15:09:24, thomasmorley65 wrote: LGTM Two questions: a) Where is `identity´ defined? I can't find it, neither in LilyPond nor in the guile-manual. Huh. The Guile2 manual shows its definition. It's a common function and is equiva

Re: Doc: NR 5.3 Add \single command (issue 6742057)

https://codereview.appspot.com/6742057/diff/7001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6742057/diff/7001/Documentation/notation/changing-defaults.itely#newcode1626 Documentation/notation/changing

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

On 2012/12/30 16:30:45, J_lowe wrote: Excuse my ignorance but is the \xxx-xxx-xxx ok in terms of consistency of name of command and/or is 'draw' redundant? \line arranges a text line, \draw-line draws an actual line, so the name choice seems ok. Another possibility would be to use properties

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

On 2012/12/31 00:07:12, thomasmorley65 wrote: I thought about extending \draw-line with a 'style-property. But in extreme cases you would have to write: \markup { \override #'(style . dashed) \override #'(on . 0.5) \override #'(off . 0.2) \override #'(thickness . 2) \draw-line

Re: Issue 3061 (issue 7033045)

https://codereview.appspot.com/7033045/diff/1/ly/articulate.ly File ly/articulate.ly (right): https://codereview.appspot.com/7033045/diff/1/ly/articulate.ly#newcode455 ly/articulate.ly:455: ((tremtype (ly:music-property (car trem) 'tremolo-type)) All this seems far too complex. Why not use ly:d

Re: Issue 3061 (issue 7033045)

On 2013/01/01 22:05:58, zefram_fysh.org wrote: mailto:d...@gnu.org wrote: >All this seems far too complex. Why not use ly:duration-length and just >divide the respective values of ly:moment-main? No need to fiddle with >counting dots and shift factors manually. That's a valid approach, b

Re: Let ChordNameVoice use the same performers as Voice (issue 7054043)

Reviewers: lemzwerg, J. Rohrer, Message: On 2013/01/04 19:32:02, J. Rohrer wrote: [Thus I learned something about contexts today: I would not have naively expected \context { \AlreadyDefinedContext \name NewContext }, to actually create a new, independent context, since the command l

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

Reviewers: Keith, Message: On 2013/01/10 06:40:08, Keith wrote: Anything with a line break still causes a crash. I can't say exactly why, because I'm a bit confused which VerticalAxisGroup gets removed, the outer or the inner. The outer group commits suicide once it hears of an inner one.

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

On 2013/01/10 09:05:21, mike7 wrote: It's actually not as bad as you'd think. The Hara_kiri_engraver is just a thin wrapper around the Axi_group_engraver. Everything can be switched on and off via an extra context property haraKiri. I was able to drum up a sketch in 10 minutes. Running

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

On 2013/01/10 09:21:33, mike7 wrote: On 10 janv. 2013, at 10:19, mailto:d...@gnu.org wrote: > On 2013/01/10 09:05:21, mike7 wrote: > >> It's actually not as bad as you'd think. The Hara_kiri_engraver is > just a thin >> wrapper around the Axi_group_engraver. Everything can be switched on >

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

On 2013/01/10 22:21:23, benko.pal wrote: good for a start but I have some problems with the duration parameter: 1. { \tuplet 3/2 { c8 c c c c c } \tuplet 3/2 4 { c8 c c c c c } \tuplet 3/2 { c8 c c c c c } } I found it ugly that the first and last input line are engraved different

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

Ok, most of this is obsolete due to myself not managing reviews properly. The current review for issue 3095 is to be found at http://codereview.appspot.com/7094044>. I am closing this one down. Apologies. On 2013/01/11 18:28:35, Ian Hulin (gmail) wrote: I don't think \tuplet needs the tupletS

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

On 2013/01/12 12:54:25, Ian Hulin (gmail) wrote: This LGTM, but with one really big question: do we really still need \tupletSpan at all? It is for setting a default. If you have a back-and-forth between tuplets and full notes (which is essentially the case for which there has been substanti

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

On 2013/01/12 16:16:55, Trevor Daniels wrote: I prefer \tupletSpan \default too, but I don't think we should advise users not to use \tupletSpan. The disadvantage of \tupletSpan is that it makes a non-local change. That's not copy&paste friendly and leads to non-self-contained code pieces. T

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

On 2013/01/12 16:43:42, Ian Hulin (gmail) wrote: tuplets specified by the current \tuplet command are to be subdivided. To unset it, use @code{\tupletSpan \default}. Doing this will ensure the spanner for the music on the current \tuplet command spans all the music, rather than the value

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

What happened to "I'll have a look later" in https://codereview.appspot.com/7069044#msg5>? Have you even _tried_ using the remove-empty property of the created axis spanner instead of adding a new haraKiri property duplicating its functionality? https://codereview.appspot.com/7061062/ _

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

https://codereview.appspot.com/7061062/diff/1/lily/axis-group-engraver.cc File lily/axis-group-engraver.cc (right): https://codereview.appspot.com/7061062/diff/1/lily/axis-group-engraver.cc#newcode122 lily/axis-group-engraver.cc:122: { On 2013/01/14 18:20:44, Keith wrote: On 2013/01/14 17:50:47

Re: Uses single algorithm for side-position spacing. (issue 6827072)

https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm#newcode54 scm/output-lib.scm:54: (define-public (non-event-cause grob) Mike, this function is total crap. What is it suppose

Re: \tuplet and \tupletSpan to replace \times and tupletSpannerDuration (issue 7094044)

https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly#newcode1376 ly/music-functions-init.ly:1376: On 2013/01/15 05:09:46, Keith wrote: Perfect Comment

Rewrites last-grob-cause function (issue 7092058)

https://codereview.appspot.com/7092058/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/7092058/diff/1/scm/output-lib.scm#newcode57 scm/output-lib.scm:57: (define-public (last-grob-cause grob) The name is quite clearer, and the semantics make sense. It i

Re: Rewrites last-grob-cause function (issue 7092058)

On 2013/01/16 12:12:40, mike7 wrote: Ah, this is cruft. Just did a git grep and didn't find it used anywhere. This must have been left-over from an old patch set. I'll just post a patch deleting it. Well, for the record, I found this function when looking for something to use in the contex

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

Comment #7 from Keith has not been addressed as far as I can see, but I have to admit that I don't understand a thing from it, so I can't estimate whether it is mistaken or indicates a real usage problem. Other than that, it looks like a welcome simplification. https://codereview.appspot.com/70

Re: Rewrites last-grob-cause function (issue 7092058)

Well, this just removes an unused buggy function previously undocumented. In my book, this does not need a countdown but can be pushed straight to staging. It would make sense, however, to rename this issue to "Removes last-grob-cause function" in case people look for it any time after. https:/

Creates Skyline_forest smob (issue 7098069)

https://codereview.appspot.com/7098069/diff/1/lily/skyline-forest.cc File lily/skyline-forest.cc (right): https://codereview.appspot.com/7098069/diff/1/lily/skyline-forest.cc#newcode2 lily/skyline-forest.cc:2: This file is part of LilyPond, the GNU music typesetter. And the license makes 95% of

Doc: fix calculation of global-staff-size in points (3114) (issue 7099051)

https://codereview.appspot.com/7099051/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/7099051/diff/1/Documentation/notation/text.itely#newcode1519 Documentation/notation/text.itely:1519: (/ (/ staff-height pt) 20))) (/ staf

Automatic line-width detection with included file (issue 3136). (issue 7201047)

I don't actually understand the patch, but wouldn't it be sanest to not copy _any_ file at all but instead let TEXINPUTS (a PATH-like variable) point at the original input directory as its first element? https://codereview.appspot.com/7201047/ ___ lily

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

On 2013/01/25 08:05:28, Keith wrote: https://codereview.appspot.com/7061062/diff/9001/lily/axis-group-engraver.cc File lily/axis-group-engraver.cc (right): https://codereview.appspot.com/7061062/diff/9001/lily/axis-group-engraver.cc#newcode120 lily/axis-group-engraver.cc:120: // mess everyth

Re: Eliminates the Hara_kiri_engraver. (issue 7061062)

On 2013/01/25 13:02:39, mike7 wrote: To be fair, the callback in question would be no sneakier than your average sneaky callback. In general, reading grob properties in the engraver stage is a bad idea. The engraver created the grob in question itself, announced it itself (so all acknowledger

Re: Creates Skyline_forest smob (issue 7098069)

https://codereview.appspot.com/7098069/diff/4001/lily/skyline-forest.cc File lily/skyline-forest.cc (right): https://codereview.appspot.com/7098069/diff/4001/lily/skyline-forest.cc#newcode28 lily/skyline-forest.cc:28: A skyline forest is, conceptually, a skyline pair that can have "forest" is a

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

"m...@mikesolomon.org" writes: Maybe it's not worth it to do all this intermediate stuff...you're right that it takes time for others to understand (and even for me to understand) as I'm working towards this goal. The project is even more ambitious as the last skyline one in terms of the amoun

Re: Make documentation reflect presence of \tuplet (issue 7220052)

Reviewers: Keith, Message: On 2013/01/29 04:47:13, Keith wrote: Looks great. You can simplify the version in changes. The two tuplets sharing share one beam catches the eye, but that was not the change. Right. This was a cut&paste job from the notation manual where the intent was to _al

<    2   3   4   5   6   7   8   9   10   11   >