"m...@mikesolomon.org" <m...@mikesolomon.org> writes:
Maybe it's not worth it to do all this intermediate stuff...you're right that it takes time for others to understand (and even for me to understand) as I'm working towards this goal. The project is even more ambitious as the last skyline one in terms of the amount of code that will be touched, so it may be difficult for people to understand the utility of things until I have a final working vertical spacing version of LilyPond. The only problem is that there will be a branch that is significantly different from staging that I won't be able to refactor into separate commits without a heapload of work. But it will avoid people unnecessary review of intermediary steps.
Mike, try the following: don't write code. Only write comments. Those comments explain what the code will accomplish (not _how_ it accomplishes that), and how it fits together with other code. Debug the comments. Make sure that the plan laid out in those comments is coherent. Go through the various cases and scenarios. Once you have all the structure and the comments together, let's review them. Onlz the skeleton of comments, nothing else. If you can't focus without writing code, remove the code for the sake of reviewing. We don't want to see it. It is an implementation detail that can be filled in by a coding monkey in case you are busy with something else. Architecture is not the art of building walls until a building emerges. The purpose of a review is not just making sure that there is enough mortar on every brick. That's masonry, not architecture. You are putting out arbitrary code pieces for review. You are right that reviewing all the code in summary is a bit much. So instead start with all the comments, so that we can review how you plan to fit anything together instead of looking at the execution of fitting stuff together. -- David Kastrup https://codereview.appspot.com/7185044/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
