https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly#newcode1376
ly/music-functions-init.ly:1376:
On 2013/01/15 05:09:46, Keith wrote:
Perfect
Comment or implementation? I actually like how using \default has
impacted code complexity.
https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py#newcode3490
python/convertrules.py:3490: if (den & (den - 1)) != 0 :
On 2013/01/15 05:09:46, Keith wrote:
# if den is a power of two
A bit too clever to put in with no comment. Somebody somewhere will
have his
time needlessly wasted figuring this out... me, for example.
I was not actually thinking anybody would ever look at the convert rules
ever. They are not really active code, and fairly inconsistent overall.
At any rate, added a comment.
https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py#newcode3502
python/convertrules.py:3502: return (r"\tupletSpan 1*%d/%d" % (num,
den))
On 2013/01/15 05:09:46, Keith wrote:
It would have been fine to handle all cases this way.
Disagree. Naturally occuring durations should be handled as such.
1*x/y is a fallback.
https://codereview.appspot.com/7094044/diff/11001/scm/define-music-display-methods.scm
File scm/define-music-display-methods.scm (right):
https://codereview.appspot.com/7094044/diff/11001/scm/define-music-display-methods.scm#newcode683
scm/define-music-display-methods.scm:683: "")
On 2013/01/15 05:09:46, Keith wrote:
I guess you wanted a space " ")
Here? No. The "" is not inside of the string-append at all. It is the
else-branch of (if span ...
so you get \tuplet 2/3 4 {...}
but I don't understand why you used string-append at all.
The space is wrongly prepended rather than appended. I did it via the
format string instead now. Turns out that formatting here (after
changing *time-scale*) was the wrong thing to do anyway.
https://codereview.appspot.com/7094044/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
