On 2010/10/26 22:13:26, Valentin Villenave wrote:
Since I have both of your approvals, I am pushing the patch now.
Thanks!
I have reverted this commit.
You put something up for review for 83 minutes, you don't wait for
approval from the Documentation Editor -- and you *know* that I want to
rev
Looks mostly good.
http://codereview.appspot.com/2699041/diff/24001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/2699041/diff/24001/Documentation/changes.tely#newcode74
Documentation/changes.tely:74: be used in safe mode). The old syntax is
On Tue, Oct 26, 2010 at 01:23:01PM -0700, Keith E OHara wrote:
> On Tue, 26 Oct 2010 05:12:16 -0700, wrote:
>
> >On Tue, 26 Oct 2010 00:47:01 -0700, Graham wrote:
> >This is directed at people saying "I can't do anything to help..."
> >
> You sent this to -devel; did you intend -user ?
No; I kno
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1624
Documentation/notation/spacing.itely:1624: size) will always reset al
New patch-set uploads (well two actually, but please review the latest).
Code in display-lily.scm to support Guile V2 now tested on Guile 1.8.7
system.
Cheers,
Ian
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm
File scm/lily.scm (right):
http://codereview.appspot.com/2219044/d
Am 20.10.2010 11:12, schrieb Marc Hohl:
Am 18.09.2010 22:21, schrieb n.putt...@gmail.com:
[...]
I think the only sane method would be to use a scheme engraver, since
you could acknowledge interesting grobs and make typesetting decisions
for the TabNoteHead based on the grobs present at a particu
On Wed, Oct 27, 2010 at 8:58 AM, wrote:
> I have reverted this commit.
For some reason, I wouldn't expect otherwise. :-)
> Calm the bloody mao down. Doc patches _do_ get approved. James Lowe
> has been steadily cleaning up broken documentation; his patches
> sometimes take a week and 3-4 vers
On Wed, Oct 27, 2010 at 11:00 AM, Marc Hohl wrote:
> I know, most developers are extremely busy right now.
>
> This particular feature isn't listed on the tracker, but since 2.14 will
> provide
> a major change concerning the tablature handling, I think it is important
> that
> tablature should wo
On Wed, Oct 27, 2010 at 10:28 AM, Valentin Villenave
wrote:
> If it's half-baked, then please do comment on it.
I would have rather commented in the codereview interface, but oh well.
- pitches.itely, line 600 in new version: was there supposed to be a
newline here? I'm not certain why you star
On Wed, Oct 27, 2010 at 11:14 AM, Valentin Villenave
wrote:
> On Wed, Oct 27, 2010 at 11:00 AM, Marc Hohl wrote:
>> This particular feature isn't listed on the tracker, but since 2.14 will
>
> I haven't made this a Critical priority,
It's not going to be. You want 2.14 asap, right? :)
>> Sorr
hello,
I have just downloaded 2.13.37-1 for windows and to check I always
double click the LilyPond icon to see if I can compile the start up file.
I noticed just now that it says
\version "2.12.0"
\header{
title = "A scale in LilyPond"
subtitle = "For more information on using LilyPond,
On 2010/10/27 10:27:30, graham_percival-music.ca wrote:
- same place, but more generally: I'm not certain quite what these
paragraphs are getting at (perhaps seeing it in a bit more context
would have helped), but I think they could be improved.
I think it's best if we treat non-Western stuff a
On Wed, Oct 27, 2010 at 01:44:09PM +0100, James wrote:
> I have just downloaded 2.13.37-1 for windows and to check I always
> double click the LilyPond icon to see if I can compile the start up
> file.
That's fine; it doesn't hurt to have a file with an old version
string. The number will be upda
On Wed, Oct 27, 2010 at 2:44 PM, James wrote:
> Could someone else verify this in case I have some residual files on this
> system. I have just done a clean uninstall and reinstall though.
No, it's normal actually:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=ly/Welcome_to_LilyPond
http://codereview.appspot.com/2754041/diff/1/lily/general-scheme.cc
File lily/general-scheme.cc (right):
http://codereview.appspot.com/2754041/diff/1/lily/general-scheme.cc#newcode84
lily/general-scheme.cc:84: " If @var{size} is @code{SCM_UNDEFINED}, the
entire file is read."
To be in sync with
On 2010/10/27 00:48:09, Valentin Villenave wrote:
Greetings everybody,
new patch set. Please have a look!
\version statements: I have put 2.13.38 in the regtest, but 2.14.0 in
the .ly
init files. Putting a minor version number in these files just didn't
feel
right. And 2.14 is near, is
Looks good!
See my comments on the UTF-8 characters in the names getting mangled.
Thanks,
Carl
http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly
File ly/norsk.ly (right):
http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly#newcode4
ly/norsk.ly:4: Copyright (C) 1998-
Greetings everybody,
updated patch set.
Something keeps removing traling newlines at the end of files, I'm not
sure what does that (I have configured git core.whitespace properly,
though: could git cl or codereview be the culprit?).
On Wed, Oct 27, 2010 at 9:08 AM, wrote:
> That sentence has a
On 27 Oct 2010, at 14:53, v.villen...@gmail.com wrote:
I think it's best if we treat non-Western stuff as "notations and
tunings" rather than just "note names". Here's a new patch set,
please
have a look.
As it now stands in the manual, it looks out of context to me. So it
should be chan
A few editorial suggestions ... some apply to other similar instances,
which I've not marked.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (left):
http://codereview.appspot.com/2755041/diff/10001/Documentation/no
Hello,
On 26/10/2010 23:12, Francisco Vila wrote:
2010/10/26 James Lowe:
\version "2.13.35"
I can not reproduce your symptoms on current Git version, compiled
today. You could always try 2.13.37.
I did try 2.13.37 and you are correct. The issue has 'gone away'.
Thanks
James
__
Am 27.10.2010 12:14, schrieb Valentin Villenave:
On Wed, Oct 27, 2010 at 11:00 AM, Marc Hohl wrote:
I know, most developers are extremely busy right now.
This particular feature isn't listed on the tracker, but since 2.14 will
provide
a major change concerning the tablature handling, I thi
On Wed, 27 Oct 2010 00:24:33 -0700, Graham Percival
wrote:
On Tue, Oct 26, 2010 at 01:23:01PM -0700, Keith E OHara wrote:
However, I have no familiarity with how vocal music is supposed
to look, and I tend to avoid tweaks myself. Graham's request
seems quite easy for a few people to coopera
On 2010/10/26 08:21:41, Mark Polesky wrote:
Well... Okay, yeah, but see this:
http://kainhofer.com/%7Elilypond/Documentation/contributor/syntax-survey.html#miscellany
I'm the one that wrote the @var description there. And yes,
the rationale is simplistic: "This improves readability in
the P
On Wed, Oct 27, 2010 at 6:49 PM, Jonathan Wilkes wrote:
> I'm interested to know how successful your sales pitch has been. I did a
> free software talk a few weeks ago but talked mostly about Pure Data and
> Ardour, plus music-oriented distros of GNU/Linux.
I suspect that it may be (ever so sl
Thanks Trevor! New patch set.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (left):
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely#oldcode579
Documentation/notation/pitches.i
On Wed, Oct 27, 2010 at 9:11 PM, wrote:
> Are you sure? I thought that what should come first were links to the
> same manual (i.e. @ref links).
Oh, I wasn't looking at the right section: I was looking at
http://lilypond.org/doc/v2.13/Documentation/contributor/syntax-survey#cross-references
inst
On 27 Oct 2010, at 19:41, tdanielsmu...@googlemail.com wrote:
A few editorial suggestions ... some apply to other similar instances,
which I've not marked.
The description of Turkish music is rather cursory: there are several
descriptions. See for example Ozan Yarman, "A Comparative Evaluati
On Wed, Oct 27, 2010 at 09:02:48PM +0200, Valentin Villenave wrote:
> On Wed, Oct 27, 2010 at 6:49 PM, Jonathan Wilkes wrote:
> > I'm interested to know how successful your sales pitch has been. I did a
> > free software talk a few weeks ago but talked mostly about Pure Data and
> > Ardour, plu
On Wed, Oct 27, 2010 at 10:54 PM, Graham Percival
wrote:
> Zing! That was a cheap shot.
What can I say? You taught me well, Master :-)
> He means "if your audience is so text-hostile that they can't
> understand \include, then there's no bloody way that they can
> write scheme code and override
Am Mittwoch, 27. Oktober 2010, um 23:13:14 schrieb Valentin Villenave:
> Putting "ca." in front of a metronome marking is something I've never
> done (Jon, I assume you mean "ca." as an abbreviation for "circa"? If
> you meant "ca." as in a French word, then proper spelling is "ça" :-).
Ah, do I l
On Wed, Oct 27, 2010 at 11:13:14PM +0200, Valentin Villenave wrote:
> On Wed, Oct 27, 2010 at 10:54 PM, Graham Percival
> wrote:
> > Zing! That was a cheap shot.
>
> What can I say? You taught me well, Master :-)
Yeah, but I keep it classy, Valentine! I mean, making fun of
somebody's girly nam
--- On Wed, 10/27/10, Valentin Villenave wrote:
> From: Valentin Villenave
> Subject: Re: problematic commit
> To: "Jonathan Wilkes"
> Cc: lilypond-devel@gnu.org
> Date: Wednesday, October 27, 2010, 9:02 PM
> On Wed, Oct 27, 2010 at 6:49 PM,
> Jonathan Wilkes
> wrote:
> > I'm interested to k
On Wed, Oct 27, 2010 at 10:40 PM, Hans Aberg wrote:
Hi Hans,
> Just mentioning it. When LilyPond expand being capable of handling more
> music outside CPP, there might be more such details pooping up.
(no comment)
> The description of Turkish music is rather cursory: there are several
> descri
On 28 Oct 2010, at 00:20, Valentin Villenave wrote:
Just mentioning it. When LilyPond expand being capable of handling
more
music outside CPP, there might be more such details [popping] up.
(no comment)
Sorry, a typo. :-)
Hans, you always have very interesting things to say on these
subj
Nearly there :)
http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#newcode588
Documentation/notation/pitches.itely:588: Man
2010/10/28 Jonathan Wilkes :
> Well, no, I'm referring to Lilypond here.
> What I mean is that
> a) "\tempo 4=72" looks easy, but if someone
> asks how to get that tempo but have it
> display as quarter note = "ca. 72", as far as I
> know one has to have two two \tempo commands,
> one as above, an
--- On Thu, 10/28/10, Graham Percival wrote:
> From: Graham Percival
> Subject: Re: problematic commit
> To: "Valentin Villenave"
> Cc: "Jonathan Wilkes" , lilypond-devel@gnu.org
> Date: Thursday, October 28, 2010, 12:11 AM
> On Wed, Oct 27, 2010 at 11:13:14PM
> +0200, Valentin Villenave wrot
On Thu, Oct 28, 2010 at 12:18 AM, Jonathan Wilkes wrote:
> Actually Pd has an ever-growing set of GUI
> objects-- you can see some of them being shown
> off in the image on Pd's Wikipedia page.
Well, that was kinda my point :-D
Nah, just kidding. Pure Data looks simply gorgeous.
For a Plan-9 ap
The recent "improve positioning of TupletNumber and Slur" patch breaks
the doc and regtest compile. I don't understand to understand how or
why, but it does, so I've reverted that commit.
Sorry, I don't have an exact error message for you, because somebody
thought it would be funny to spam tons o
On 2010/10/26 17:19:51, Carl wrote:
L Great TM.
this has now been pushed.
http://codereview.appspot.com/2687043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/2699041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
comments.
http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (left):
http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#oldcode447
Documentation/notation/pitches.itely:447: use defaul
Looks pretty good to me. Just a tiny style nitpick indicated below.
Thanks for your work on this!
Regards,
Patrick
http://codereview.appspot.com/2699041/diff/33001/input/regression/note-names.ly
File input/regression/note-names.ly (right):
http://codereview.appspot.com/2699041/diff/33001/inp
Copied from frogs to devel, because I don't think the frog people can
answer.
Carl
-- Forwarded Message
From: Ian Hulin
Date: Wed, 27 Oct 2010 15:31:13 -0600
To: Lilypond Frogs List
Conversation: [frogs] display-lily.scm question
Subject: [frogs] display-lily.scm question
-BEGIN PGP S
Hi Ian,
On Wed, Oct 27, 2010 at 2:31 PM, Ian Hulin wrote:
>
> I've just done some stuff with this file to ensure it compiles OK when
> running using Guile V1.9.
>
> It declares all it stuff in a module (define-module (scm dislplay-lily)
>
> It currently gets loaded by lily.scm as part of the dyna
> The recent "improve positioning of TupletNumber and Slur" patch
> breaks the doc and regtest compile. I don't understand to
> understand how or why, but it does, so I've reverted that commit.
Umpf. What a pity. If you are correct, my tiny, innocent change has
unveiled a more serious bug whic
> I'm directing this primarily to bug-list folks. This was submitted
> over a week ago, and I see no action. Did I miss something?
Yes. I've already fixed this in the git repository.
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.or
48 matches
Mail list logo
