comments.
http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (left): http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#oldcode447 Documentation/notation/pitches.itely:447: use default (Nederlands) note names, the @co...@bs{}include} Incidently, does your language change mean that this limitation is no longer true? That would be awesome. http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#newcode41 Documentation/notation/pitches.itely:41: * Non-Western notations and tunings:: WTM is "notations" ? http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#newcode444 Documentation/notation/pitches.itely:444: @co...@w{@bs{}include "english.ly"}} to the input file. If you're going to change this, then you might as well change it properly. ------- For example, to use English note names, use: @lilypond[quote,verbatim] \language "english" \relative c'' { c4 cs cf css } @end lilypond ----- I thought you were only doing the arabic stuff here, but oh well. http://codereview.appspot.com/2755041/diff/22001/Documentation/notation/pitches.itely#newcode570 Documentation/notation/pitches.itely:570: @unnumberedsubsubsec Non-Western notations and tunings Why have an @unnumberedsubsubsec here at all? I suggest a single sentence in the previous bit, saying something like "Some types of non-Western music use alternate pitches; these are discussed in @ref{World music}." Then we can safely isolate all that stuff to the relevant Specialist 2.x section. Your job as a programmer and doc writer is over -- as long as it's clear where this weird stuff should be discussed, you're fine. Let somebody who cares about the alternate notations write the descriptions. You're not expected to care about everything that your work touches. And even if you *do* care about it, I'd rather see any music theory descriptions as a separate patch, anyway. Focus on the _specific_ topic at hand and get the patch approved+pushed. There's always time for more patches later on. http://codereview.appspot.com/2755041/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
