On Mar 16, 2011, at 6:06 AM, mts...@gmail.com wrote:
> Done - after an LGTM from Han Wen, I'll run the regtests and push l8r
> today unless anyone has more comments.
>
>
> http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.co
Done - after an LGTM from Han Wen, I'll run the regtests and push l8r
today unless anyone has more comments.
http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc#newcode593
lily/beam.cc:593: Interv
lgtm
http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc#newcode593
lily/beam.cc:593: Interval placements = robust_scm2interval
(me->get_property ("normalized-endpoints"), Interval (0.0,0.0));
spa
New patch set uploaded. Thanks for the comments, Han-Wen!
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode176
lily/beam.cc:176: Beam::calc_feather_widths (SCM smob)
On 2011/03/15 13:03
On Mar 15, 2011, at 9:18 AM, Han-Wen Nienhuys wrote:
> On Tue, Mar 15, 2011 at 10:08 AM, m...@apollinemike.com
> wrote:
>> On Mar 15, 2011, at 9:03 AM, Han-Wen Nienhuys wrote:
>>
>>> On Mon, Mar 14, 2011 at 9:16 AM, wrote:
>>>
I've sketched this out using your suggestion above (calculati
On Tue, Mar 15, 2011 at 10:08 AM, m...@apollinemike.com
wrote:
> On Mar 15, 2011, at 9:03 AM, Han-Wen Nienhuys wrote:
>
>> On Mon, Mar 14, 2011 at 9:16 AM, wrote:
>>
>>> I've sketched this out using your suggestion above (calculating it once and
>>> returning the fraction for the called beam) -
On Mar 15, 2011, at 9:03 AM, Han-Wen Nienhuys wrote:
> On Mon, Mar 14, 2011 at 9:16 AM, wrote:
>
>> I've sketched this out using your suggestion above (calculating it once and
>> returning the fraction for the called beam) - nevermind my previous question
>> about redoing calculations. A new
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode176
lily/beam.cc:176: Beam::calc_feather_widths (SCM smob)
actually, you could just call this length-fraction; what's calculated
over here
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode204
lily/beam.cc:204: SCM temp = scm_cons (scm_from_double
(feather_fractions[i][LEFT] / total_width), scm_from_double
(feather_fractions[
On Mon, Mar 14, 2011 at 9:16 AM, wrote:
> I've sketched this out using your suggestion above (calculating it once and
> returning the fraction for the called beam) - nevermind my previous question
> about redoing calculations. A new patch set is on-line.
> I still need to do the math for the
On Mar 13, 2011, at 10:30 PM, hanw...@gmail.com wrote:
>
> http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc#newcode206
> lily/beam.cc:206: orig->set_property ("feather-fraction", scm_cons
On Mar 13, 2011, at 10:30 PM, hanw...@gmail.com wrote:
>
> http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc#newcode206
> lily/beam.cc:206: orig->set_property ("feather-fraction", scm_cons
http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/11001/lily/beam.cc#newcode206
lily/beam.cc:206: orig->set_property ("feather-fraction", scm_cons
(scm_from_double (0.0), scm_from_double (orig->spanner_length (
On Mar 12, 2011, at 8:49 AM, hanw...@gmail.com wrote:
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc
> File lily/spanner.cc (right):
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc#newcode405
> lily/spanner.cc:405: Spanner::broken_spanner_index (Spanner const *
On Mar 12, 2011, at 2:49 PM, hanw...@gmail.com wrote:
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc
> File lily/spanner.cc (right):
>
> http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc#newcode405
> lily/spanner.cc:405: Spanner::broken_spanner_index (Spanner const *
http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc
File lily/spanner.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc#newcode405
lily/spanner.cc:405: Spanner::broken_spanner_index (Spanner const *sp)
On 2011/03/12 10:18:06, MikeSol wrote:
On 2011/03/09 23:03:44
Thanks for the comments!
New patch uploaded.
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode173
lily/beam.cc:173: span_data.push_back (get_beam_span
(orig->broken_intos_[i], commonx));
On 2011
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode620
lily/beam.cc:620: {
it would be nice if you could collapse all of the if (feather) code.
You're duplicating an awful lot of logic.
http://cod
On Thu, Mar 10, 2011 at 5:04 AM, wrote:
>> this looks wrong - different broken pieces cannot ever share a
>
> commonx.
>
> Odd - it gets correct results for some reason (I honestly don't know
> how...).
Lily tries not to crash, and things may just work in this case, but
better not rely on it.
Reviewers: hanwenn,
Message:
Thanks for the comments!
Below I have a question about commonx - the other fix will be easy to
implement.
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode173
lily/
Thanks for the comments!
Below I have a question about commonx - the other fix will be easy to
implement.
http://codereview.appspot.com/4237057/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode173
lily/beam.cc:173: span_data.push_back (get_beam_span
(orig->broken_intos_[i], commonx));
this looks wrong - different broken pieces cannot eve
Hey all,
A potential fix for issue 1504 is posted here:
http://codereview.appspot.com/4237057/
I haven't had time to run the regtests yet (traveling), but will in the next
few days. There is, however, an additional regtest (see patch) that shows this
patch in action.
Lemme know what you thin
23 matches
Mail list logo
