http://codereview.appspot.com/4237057/diff/1/lily/beam.cc File lily/beam.cc (right):
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode620 lily/beam.cc:620: { it would be nice if you could collapse all of the if (feather) code. You're duplicating an awful lot of logic. http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode647 lily/beam.cc:647: } I see dup code. Can you fold? http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode653 lily/beam.cc:653: : segments[segments.size () - 1].vertical_count_); use segments.back() http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode665 lily/beam.cc:665: * (placements[RIGHT] - placements[LEFT]) placements.delta (), placements.length() ? http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode682 lily/beam.cc:682: weights[LEFT] = 1; can you set multiplier to 1 in this case? http://codereview.appspot.com/4237057/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
