http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode176
lily/beam.cc:176: Beam::calc_feather_widths (SCM smob)
actually, you could just call this length-fraction; what's calculated
over here is something generic to spanners.  You could even move it
there.

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode204
lily/beam.cc:204: SCM temp = scm_cons (scm_from_double
(feather_fractions[i][LEFT] / total_width), scm_from_double
(feather_fractions[i][RIGHT] / total_width));
can you use a meaningful name?

Even a 1 letter name than 'temp'

http://codereview.appspot.com/4237057/diff/14002/lily/beam.cc#newcode672
lily/beam.cc:672: to the total length.
?

should the total feathering dy be proportional to that?

http://codereview.appspot.com/4237057/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to