On Mar 16, 2011, at 6:06 AM, mts...@gmail.com wrote: > Done - after an LGTM from Han Wen, I'll run the regtests and push l8r > today unless anyone has more comments. > > > http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc#newcode593 > lily/beam.cc:593: Interval placements = robust_scm2interval > (me->get_property ("normalized-endpoints"), Interval (0.0,0.0)); > On 2011/03/16 02:17:28, hanwenn wrote: >> space after , > > Done. > > http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc#newcode624 > lily/beam.cc:624: weights[RIGHT] = 1 - multiplier; > On 2011/03/16 02:17:28, hanwenn wrote: >> weights.swap() ? > > Done. > > http://codereview.appspot.com/4237057/diff/13002/lily/beam.cc#newcode636 > lily/beam.cc:636: + beam_dy * segments[extreme].vertical_count_; > On 2011/03/16 02:17:28, hanwenn wrote: > >> how about > >> int idx = {i, extreme} >> int translations[2] >> for (j = 0;j<2;j++) >> translations[i] = slope * (segments[idx[j]] .. etc) > > Done. > > http://codereview.appspot.com/4237057/diff/13002/lily/spanner.cc > File lily/spanner.cc (right): > > http://codereview.appspot.com/4237057/diff/13002/lily/spanner.cc#newcode406 > lily/spanner.cc:406: SCM ret = scm_cons (scm_from_double (0.0), > scm_from_double (0.0)); > On 2011/03/16 02:17:28, hanwenn wrote: >> i personally like 'result' better, almost as short, and a full word. > >> You could init to SCM_EOL instead? > > Done. > > http://codereview.appspot.com/4237057/diff/13002/lily/spanner.cc#newcode433 > lily/spanner.cc:433: SCM t = ly_interval2scm (Interval > (unnormalized_endpoints[i][LEFT] / total_width, > unnormalized_endpoints[i][RIGHT] / total_width)); > On 2011/03/16 02:17:28, hanwenn wrote: >> try using interval * 1/width (or 1/width * interval). The operator > overloading >> for interval is hit and miss. You can add a operator/ if you want > (separate >> commit) > > Done. > > http://codereview.appspot.com/4237057/ >
Pushed, w/ whitespace errors squelched & the version number in the regtest updated to 2.13.55. Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
