Reviewers: hanwenn, Message: Thanks for the comments! Below I have a question about commonx - the other fix will be easy to implement.
http://codereview.appspot.com/4237057/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4237057/diff/1/lily/beam.cc#newcode173 lily/beam.cc:173: span_data.push_back (get_beam_span (orig->broken_intos_[i], commonx)); On 2011/03/09 23:03:44, hanwenn wrote:
this looks wrong - different broken pieces cannot ever share a
commonx. Odd - it gets correct results for some reason (I honestly don't know how...). What would be a better way of grabbing these coordinates (the left and right points of the beam)? http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc File lily/spanner.cc (right): http://codereview.appspot.com/4237057/diff/1/lily/spanner.cc#newcode405 lily/spanner.cc:405: Spanner::broken_spanner_index (Spanner const *sp) On 2011/03/09 23:03:44, hanwenn wrote:
why not make it a real member funtcion?
Doable! I'll do it w/ my next patch. Description: Potential fix for issue 1504. Changes feathered beaming such that broken feather beams pick up at the same degree of feather-ness as the previous line. Please review this at http://codereview.appspot.com/4237057/ Affected files: A input/regression/beam-feather-breaking.ly M lily/beam.cc M lily/include/beam.hh M lily/include/spanner.hh M lily/spanner.cc _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
