Hi Harm, I took a quick look and it LGTM at a quick read. I have a
couple nit-level suggestions.
-Paul
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm
File scm/markup.scm (right):
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm#newcode141
scm/markup.scm:141
Hi Charles, Today I built and ran 'make check' with your patch applied
to current master. I was able to get it to pass 'make check' by making
the following two changes.
1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`.
2. In that same file, line 100, remove the parens to cha
Hi Charles,
I was thinking about working on MusicXML export for chord symbols, and
wondered about the status of your GSOC project. (It would, of course,
make exporting chord symbols much simpler and more robust.) I was
really glad to find your code up on Reitveld, and was curious, so I gave
it
On 2018/06/22 07:18:20, lilypond-pkx wrote:
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780
Documentation/notatio
Reviewers: ,
Message:
Please review, thanks, -Paul
Description:
Doc: document grob metadata in SVG output in Notation Reference
I.e. using the 'output-attributes' grob property to add id, class,
and other attributes to the SVG output for a given grob.
Please review this at https://codereview.a
Round two. -Paul
https://codereview.appspot.com/325970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On second thought...
https://codereview.appspot.com/325970043/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
https://codereview.appspot.com/325970043/diff/1/Documentation/contributor/source-code.itexi#newcode1257
Documentation/contri
Reviewers: ,
Message:
Please review. Working on css changes for docs, I realized it wasn't
clear to me, from reading the CG, whether the commit prefix should be
'Doc:' or 'Web:' or something else. So this clarifies things.
-Paul
Description:
Doc: CG: Add guideline for use of 'CSS' prefix in co
Reviewers: ,
Message:
Please review, a few follow-ups to the previous manuals css patch.
The following demo site reflects the changes in this patch (remove
spaces after the domain).
http://clairnote.org /lilypond-web-demo/Documentation/
(I'll upload a screenshot showing the former brown colo
On 2017/06/09 13:36:53, dak wrote:
Ok, I've taken another look at something that should help with this
amount of
fine-grained definitions.
LGTM. Although I'm still new to understanding scheme macros, I
think I understand the gist of what's going on.
Do you think that the following macro mar
On 2017/06/10 17:58:43, pwm wrote:
Footers
- simplify color scheme, no need to draw attention to footers with
color
- language text size matches rest of footer (I'll provide a screenshot
for
language section which isn't in the demo site)
Languages / footer screenshot posted to the sourcefor
Reviewers: ,
Message:
Please review these css edits for the manuals. Here is a demo site for
easier review (remove spaces after the domain to reassemble the url):
http://clairnote.org /lilypond-web-demo/Documentation/web/manuals.html
The biggest difference is the color scheme. There are a fe
Reviewers: ,
Message:
Please review,
-Paul
Description:
abc2ly: Support R (rhythm / meter) and Z (transcription) fields
Please review this at https://codereview.appspot.com/324890043/
Affected files (+5, -1 lines):
M scripts/abc2ly.py
Index: scripts/abc2ly.py
diff --git a/scripts/abc2ly.py
On 2017/03/15 02:44:17, pwm wrote:
Only change appearance of GSOC project ideas
I've rebased this now that issue 5085 landed (which changed some text on
the GSOC page). Also, I looked at the other pages that were affected by
the CSS changes in patch set 1, and did not like the results. So pat
LGTM
https://codereview.appspot.com/314620043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2017/03/05 13:44:00, pkx166h wrote:
more fixes to Hungarian to make this bloody thing compile.
LGTM. Thank you James for working this out and making the necessary
changes.
-Paul
https://codereview.appspot.com/320290043/
___
lilypond-devel mailin
On 2017/03/04 20:52:49, pkx166h wrote:
I'll have a go at fixing this now.
Thanks, I haven't had a chance to work on this yet. Sorry I didn't try
a 'make doc' before uploading for review. Since 'make website'
succeeded I thought it was good to go... but that's not the case.
One simple soluti
Reviewers: ,
Message:
Please review. I realized after changing the file names that it might
not have been the best approach. I'm not sure how it will affect
translations of the site. Not hard to change them back in a revised
patch, but in the long run I think these newer names are clearer.
Tw
On 2017/02/18 20:20:27, dak wrote:
Actually I didn't. I just put the finishing touches on a task mainly
done by
Valentin that made it possible to enable a debugging option in Guile,
and the
compiler then dug this one up in consequence as well as a few others.
Ah, cool, nice to have these
https://codereview.appspot.com/314490043/diff/1/lily/one-page-breaking.cc
File lily/one-page-breaking.cc (right):
https://codereview.appspot.com/314490043/diff/1/lily/one-page-breaking.cc#newcode97
lily/one-page-breaking.cc:97: if (scm_is_true (scm_gr_p (this_pos,
lowest_line_pos)))
Thanks for c
Reviewers: ,
Message:
I'll upload screenshots to the issue tracker.
Description:
Web: nest GSOC project ideas under subsection/h3
Please review this at https://codereview.appspot.com/314530043/
Affected files (+77, -72 lines):
M Documentation/css/lilypond-website.css
M Documentation/web/co
https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm
File scm/lily-library.scm (right):
https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm#newcode895
scm/lily-library.scm:895: "Lexicographically compare to lists @var{a}
and @var{b} using
I like David's s
Reviewers: ,
Message:
Finally got around to this. -Paul
Description:
Web: examples page: move more common use cases higher in the list
Makes the order match the list on the home page.
Also adds an additional line between the code for each example for
better readability.
Please review this at
On 2017/02/14 15:15:07, git wrote:
I like this more because it's more of a typical procedure invocation.
I think I'll create a new patch with this and a simplified
calculate-version
(that doesn't accept string lists)
Well, having the procedure as the first argument might be more
scheme-ish?
https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm
File scm/lily-library.scm (right):
https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm#newcode909
scm/lily-library.scm:909: (define-public (lilypond>? ref-version)
Instead of a separate procedure for each compa
For consistency and readability should there be a dash between "never"
and "embed"? For example:
-dgs-never-embed-fonts rather than
-dgs-neverembed-fonts
https://codereview.appspot.com/312970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: ,
Message:
Please review, fixes issue 4979.
-Paul
Description:
Don't merge non-overlapping ledger lines
Issue 4979/2: Add regression test for non-merging ledger lines
Issue 4979/1: Don't merge non-overlapping ledger lines
Please review this at https://codereview.appspot.com/308
Patch Set 2: Improve convert rule, keep id property.
https://codereview.appspot.com/308430043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2016/09/27 10:06:26, dak wrote:
https://codereview.appspot.com/308430043/diff/1/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/308430043/diff/1/python/convertrules.py#newcode3906
python/convertrules.py:3906: @rule ((2, 19, 49), r"""\override ...
Reviewers: ,
Message:
Just a small doc edit. -Paul
Description:
Doc: update toplevel-score-handler definition reference
The file where the default handler is defined has changed.
Please review this at https://codereview.appspot.com/308490043/
Affected files (+3, -2 lines):
M Documentation/n
Reviewers: ,
Message:
Please review, thanks, -Paul
Description:
Add output-attributes grob property to replace id
Allows setting multiple attributes on group
nodes ( in SVG output), specified as an alist.
Please review this at https://codereview.appspot.com/308430043/
Affected files (+84, -35
Now using the Bach BWV861 example from the essay. Screenshot:
https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0
I like the cleaner look since this image doesn't have any title, text,
etc. like the previous one. If you click on the image you can see a
larger version. I will upload t
Thanks for the feedback everyone!
On 2016/09/06 16:39:22, Carl wrote:
I think the only thing remaining is to get the best possible example
for the
front page.
Any suggestions anyone? I'm fine with the Bach one or whatever people
think is best. One of the existing ones would be simplest of
Patch set 3 uploaded, with just one example image on the home page and a
list of links to the other examples on the examples page. I like how
this gets an image of sheet music onto the home page and helps
communicate the wide range of LilyPond's use cases.
Screenshot:
https://drive.google.com/op
On 2016/08/30 15:07:47, fedelogy wrote:
Paul, thanks for tackling this issue!
Thanks, glad to help. It's been on my wish list for awhile.
I'd prefer a slider of images to save vertical space and scrolling.
Some time ago I made a quick test of a pure CSS image slider of
lilypond
examples,
Reviewers: ,
Message:
Please review and let me know what you think about these changes. They
are inspired by recent and not so recent discussions on the lists.
Here's a screenshot of the home page with these changes:
https://drive.google.com/open?id=0ByNTIEA63_a_bkxrWlpKcW43cHc
The images and
Patch set 4 with some minor cleanups.
https://codereview.appspot.com/295970043/diff/40001/input/regression/ledger-positions-customization.ly
File input/regression/ledger-positions-customization.ly (right):
https://codereview.appspot.com/295970043/diff/40001/input/regression/ledger-positions-cus
On 2016/04/23 20:33:21, pwm wrote:
Add StaffSymbol.ledger-positions-function
I realized that calls to StaffSymbol::on_line would not be aware of any
customizations made via NoteHead.ledger-positions, but they will be with
the StaffSymbol.ledger-positions-function from patch set 3. I
considered
Patch set 2, based on David's Feedback.
-Paul
https://codereview.appspot.com/295970043/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
https://codereview.appspot.com/295970043/diff/1/lily/ledger-line-spanner.cc#newcode221
lily/ledger-line-spanner.cc:221: int len = s
Reviewers: ,
Message:
Please review. I've posted an implementation question in the issue
tracker.
https://sourceforge.net/p/testlilyissues/issues/4828/
Thanks, -Paul
Description:
Allow override of NoteHead.ledger-positions
Can be a literal list of positions:
\once \override NoteHead.ledger-p
Reviewers: ,
Message:
Please review. I was working on a scheme version of the ledger line
print routine (for some custom ledger line patterns) and having figuring
out how it worked, I thought I would make some improvements.
Since I'm new to C++ ...review is especially appreciated.
Thanks,
-Pau
https://codereview.appspot.com/292370043/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
https://codereview.appspot.com/292370043/diff/1/Documentation/contributor/source-code.itexi#newcode2296
Documentation/contributor/source-code.itex
Reviewers: ,
Message:
Please review, thanks. -Paul
Description:
Doc: CG: push to staging with rebase not merge
Use 'git pull -r' for consistency with other
parts of the CG.
Please review this at https://codereview.appspot.com/292370043/
Affected files (+21, -8 lines):
M Documentation/contri
Reviewers: ,
Message:
Please review, thanks, -Paul
Description:
Doc: CG: itemize section on commit message prefixes
Please review this at https://codereview.appspot.com/296810043/
Affected files (+20, -8 lines):
M Documentation/contributor/source-code.itexi
Index: Documentation/contributor
Reviewers: ,
Message:
Please review. See issue 4818 for examples that show this obscure edge
case. Luckily it was an easy fix once I figured out what was going on.
Thanks, -Paul
Description:
engraver-init.ly: guarantee no ledger lines in NullVoice
for staves with custom line positions and led
LGTM.
On 2016/03/17 18:15:29, pkx166h wrote:
I've opted for this
* The Git contributor's cycle::
* Pulling and rebasing::
* Using local branches::
* Commits::
* Patches::
* Uploading a patch for review::
* The patch review cycle::
That way those more expert devs that already know how to c
Reviewers: ,
Message:
Found a couple of typos. -Paul
Description:
Doc: NR A.2: Fix typos in chord modifiers table
Please review this at https://codereview.appspot.com/293900043/
Affected files (+2, -2 lines):
M Documentation/notation/notation-appendices.itely
Index: Documentation/notation
On 2016/02/20 08:20:12, trueroad wrote:
LGTM
But here is another method.
Thank you, this is better, and I've used it in patch set 2.
Patch set 2 also includes some edits to the docs (as a separate commit).
-Paul
https://codereview.appspot.com/290850043/
___
Reviewers: ,
Message:
Please review. See the discussion in this thread on the bug list:
http://lists.gnu.org/archive/html/bug-lilypond/2016-02/msg00079.html
Thanks,
-Paul
Description:
output-svg.scm: better defaults for font-family
if the user has not set the font, use a
meaningful svg defaul
Reviewers: ,
Message:
Please review. I've put up a demo copy of the full LilyPond website and
documentation with these CSS changes in effect, to make it easy to see
what they do. (The changes only affect the various headings in the
manuals.)
Just remove the spaces in the following URL (which h
On 2016/02/12 12:49:06, benko.pal wrote:
do we really need to talk about patches at all in the preferred (i.e.
Rietveld-based) workflow?
(do we really need any more about non preferred ways than "ask on
devel"?)
Good question... maybe, maybe not, but I think that deserves a separate
issue/revi
Reviewers: ,
Message:
Please review. Having separate subsections for Commits and Patches will
make it easier to quickly navigate to one or the other from the table of
contents. And since they are in fact two different things, separate
subsections makes conceptual sense, perhaps especially for t
LGTM, with one minor suggestion.
Thanks Urs, I think this really improves this page.
-Paul
https://codereview.appspot.com/285400043/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):
https://codereview.appspot.com/285400043/diff/1/Documentation/web/communit
Thanks for working on this Urs. Here are my strong opinions and
suggested revisions. Make of them what you will!
-Paul
https://codereview.appspot.com/285400043/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):
https://codereview.appspot.com/285400043/di
Reviewers: ,
Message:
Please review, thanks, -Paul
Description:
Doc: CG: Merge and remove redundant git-cl info
Please review this at https://codereview.appspot.com/285350043/
Affected files (+43, -114 lines):
M Documentation/contributor/quick-start.itexi
M Documentation/contributor/source
Add "free software". -Paul
https://codereview.appspot.com/282260043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM with an edit and a broader question about the mentor listings.
-Paul
https://codereview.appspot.com/282290043/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):
https://codereview.appspot.com/282290043/diff/1/Documentation/web/community.itexi#newcode93
Now that ly:one-line-auto-height is in master, this patch set updates
the docs so it and ly:one-page-breaking are both present and accounted
for. -Paul
https://codereview.appspot.com/288910043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
https:
Please review, thanks, -Paul
https://codereview.appspot.com/288910043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Please review. Thanks, -Paul
https://codereview.appspot.com/282260043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
A few doc edits. -Paul
https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacing.itely#newcode895
Documentation/notation/spacing.itely:895
Reviewers: ,
Message:
Please review, thanks.
-Paul
Description:
Add ly:one-line-auto-height-breaking
Includes 4 commits:
Changes entry for ly:one-line-auto-height-breaking
Doc: NR 4.3.2 add ly:one-line-auto-height-breaking
Includes a few related edits to NR 4.3.2
mainly for ly:one-line-br
Slightly simpler docstring revision.
-Paul
https://codereview.appspot.com/284980043/diff/20001/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/284980043/diff/20001/scm/stencil.scm#newcode809
scm/stencil.scm:809: and @code{'box}. Given @code{'outline} the white
back
Please review, thanks. A demo snippet and image showing the problem are
in issue 4726. -Paul
https://codereview.appspot.com/282970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Addressing Harm's suggestions in patch set 2.
https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm#newcode804
scm/stencil.scm:804: (define*-public (stencil-whiteout stil #:optional
(style 'b
Reviewers: ,
Message:
Please review, thanks.
-Paul
Description:
stencil.scm: make args optional in stencil-whiteout
Please review this at https://codereview.appspot.com/284980043/
Affected files (+2, -1 lines):
M scm/stencil.scm
Index: scm/stencil.scm
diff --git a/scm/stencil.scm b/scm/ste
Reviewers: ,
Message:
The snippet below prints a list of markup commands to the log. It seems
that a line of debugging code was not commented out in issue 4685:
http://sourceforge.net/p/testlilyissues/issues/4685/
-Paul
\version "2.19.34"
\header {
title = "anything"
}
{ c }
Descriptio
Some digging turned up:
Grob::spanned_rank_interval in grob.cc
Spanner::spanned_rank_interval in spanner.cc
Item::spanned_rank_interval in item.cc
with the latter two being more illuminating. So this would indeed work
and be much more generic. Now to figure out how and where to implement
a
On 2015/12/15 22:26:01, dak wrote:
Not sure what you need it for.
I was working on a Scheme rewrite of ly:ledger-line-spanner::print,
to allow for some local customizations. It uses the rank of paper
columns,
namely, around line 210 in ledger-line-spanner.cc
Direction vdir = Directi
Reviewers: ,
Message:
Please review.
There is already a Paper_column::get_rank for C++ use, so I created a
Scheme version alongside it, but I'm not sure if this is the best
approach. I named the Scheme one "get_rank_number" to differentiate the
two. Any suggestions are welcome.
Background: I
Please review, thanks.
When StaffSymbol.staff-space is overridden to a value less than 1,
collisions can occur between simultaneous notes that are more than one
staff space apart.
This patch introduces a property "note-collision-threshold" that makes
it possible to prevent this. By setting this
Please review. I finally got around to some of these edits:
http://lists.gnu.org/archive/html/lilypond-devel/2015-05/msg00065.html
-Paul
https://codereview.appspot.com/280810043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.g
Reviewers: ,
Message:
Please review, thanks,
-Paul
Description:
Implement rounded-box whiteout style
As suggested in issue 4504.
Includes edits to regression tests and
changes entry.
Please review this at https://codereview.appspot.com/274590043/
Affected files (+65, -25 lines):
M Documenta
Thanks for your help. I made a test file and got it to compile without
errors.
https://codereview.appspot.com/275770043/diff/40001/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/275770043/diff/40001/Documentation/changes.tely#newcode88
Docume
Patch set 3 to removes the double quotes after '@end lilypond' in
changes.tely. Should be all good to go now.
-Paul
https://codereview.appspot.com/275770043/diff/20001/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/275770043/diff/20001/Docume
Thanks for the feedback. All fixed in patch set 2.
-Paul
https://codereview.appspot.com/275770043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/275770043/diff/1/Documentation/changes.tely#newcode72
Documentation/changes.tely:72: \\mar
Reviewers: ,
Message:
Please review. This patch set implements the "whiteout and
whiteout-style" grob property approach.
Another approach ("whiteout and whiteout-thickness") has also been
proposed. See issue tracker:
https://sourceforge.net/p/testlilyissues/issues/4504/
Thanks,
-Paul
Descript
A couple of suggestions, but LGTM.
https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/running.itely
File Documentation/usage/running.itely (right):
https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/running.itely#newcode43
Documentation/usage/running.it
Pushed:
authorPaul Morris
Sun, 23 Aug 2015 02:32:42 + (22:32 -0400)
committerJames Lowe
Sun, 30 Aug 2015 07:33:48 + (08:33 +0100)
commita3fc862086a720201e4a4764c7beb952fab5f106
https://codereview.appspot.com/264810043/
__
Reviewers: ,
Message:
Please review. This patch allows whiteout-box to take a number
argument. A boolean argument is still possible as well. This brings it
into parity with whiteout for both grobs and markups. This is a
preliminary step needed for the further changes described in issue 4504.
On 2015/08/18 14:46:02, dak wrote:
Well, at least \acceptability would seem nicer than \acceptances.
\inherit-acceptability
would be somewhat descriptive but it is awkward in the sorting order
and rather
verbose.
Hmmm...
\inherit-acceptability "MyStaff" "Staff"
is pretty good, if y
I brainstormed some ideas:
\copy-acceptability
\copy-acceptance
\copy-acceptances
\acceptable-where
\accepts-alias
\acceptability-alias
...but I'm not sure any of those are better than the ones mentioned
already. FWIW, I like how it is easier for me to understand what the
command does with \acc
LGTM. This will make using custom modified contexts much simpler,
thanks!
My only suggestion is that the plural form of "acceptances" sounds odd
if there are more than one:
\layout {
% ...
\acceptances "MyStaff" "Staff"
\acceptances "MyLyrics" "Lyrics"
}
What about \accept-like instead?
Please review. Per feedback I narrowed and tested the convert-ly rule
and edited the changes entry. (I also redid the commits for better
commit history.)
-Paul
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@g
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: now create a white background that
follows the outline o
Just uploaded patch set 4.
It includes improved convert-ly rules. I ran
scripts/auxiliar/update-with-convert-ly.sh
with these rules on both a clean branch and on the branch where I'm
working on this functionality. It worked as expected for both.
This patch set also includes a changes entry and
I updated convertrules.py as follows:
@rule ((2, 19, 22), """whiteout -> whiteout-box""")
def conv(str):
str = re.sub (r"\whiteout", r"\whiteout-box", str)
str = re.sub (r".whiteout", r".whiteout-box", str)
str = re.sub (r"#'whiteout", r"#'whiteout-box", str)
str = re.sub (r"stenc
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py#newcode3751
python/convertrules.py:3751: str = re.sub (r'\bwhiteout\b',
'whiteout-box', str)
On 2015/06/01 23
New patch set uploaded for review (3rd one):
https://codereview.appspot.com/236480043
Please review, especially the convert-ly rule, grob.cc, and doc strings.
Includes commits:
convert-ly: add whiteout -> whiteout-box
rhythms.itely: improve text for whiteout-box
let \whiteout use
https://codereview.appspot.com/236480043/diff/20001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/236480043/diff/20001/Documentation/notation/rhythms.itely#newcode555
Documentation/notation/rhythms.itely:555: collide with o
On 2015/05/31 01:07:47, Keith wrote:
I realize I am changing my opinion here on a few points:
1) leave the old whiteout as a simple box and give the new function a
new name
2) enabling either type of whiteout through a single property looks
better
3) the thickness should be in terms of line-t
On 2015/05/25 13:06:26, Valentin Villenave wrote:
I’ve always been unhappy with the current method for whiteout (which I
have also
been using in rounded-box-stencil, nevertheless). LilyPond scores’
background is
_not_ white, but alpha transparent. Look for example at the way
Frescobaldi
dis
On 2015/05/25 22:24:01, Keith wrote:
The additional copies of the stencils do make the PDF files noticeably
larger.
8% larger when I used 16-copy whiteout around all dynamics and text
marks in a
string quartet score.
The compilation time increased by 2%, desipte the repeated
computations
Thanks for the reviews.
On 2015/05/24 22:56:44, Keith wrote:
I think whiteout-stencil should simply call this function, with the
defaults
suggested, so that the existing
\set Xx.whiteout=##t and \markup\whiteout use this new method.
We could provide access to the old whiteout method with
\s
Reviewers: ,
Message:
Please review, thanks.
See discussion here for background and usage demo:
http://lists.gnu.org/archive/html/lilypond-user/2015-05/msg00522.html
I have not yet done a regtest, but will add one if this is reviewed
favorably for inclusion in LilyPond.
Description:
add stenci
https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly
File input/regression/stencil-flip.ly (right):
https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly#newcode1
input/regression/stencil-flip.ly:1: \version "2.19.19"
On 2015/05/07 0
Here's another round of edits, also:
WARNING: could not change issue labels;
please email lilypond-devel with the issue number: 4370
No permission to edit issue
Thanks,
-Paul
https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.a
Thanks for the feedback! I've improved the doc strings, and revised the
doc string for ly:stencil-scale so that it covers negative arguments.
-Paul
https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly
File input/regression/stencil-scale.ly (right):
https://coderevi
Please review, thanks.
https://codereview.appspot.com/235090043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2015/05/03 20:04:28, dak wrote:
There is no such thing as '' or s'' as a recognizable element in
LilyPond's
syntax and there is not even a tangible representation of it in
Scheme. I don't
think that such a feature warrants both messing with the parser as
well as
introducing new Scheme
1 - 100 of 129 matches
Mail list logo
