Here's another round of edits, also: WARNING: could not change issue labels; please email lilypond-devel with the issue number: 4370 No permission to edit issue
Thanks, -Paul https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode665 scm/stencil.scm:665: (define-public (stencil-flip axis stil) On 2015/05/06 23:51:16, thomasmorley651 wrote:
I'd call it 'flip-stencil', would be more in line with the majority of
namings
here in stencil.scm
Done. I was thinking of ly:stencil-rotate, but you're right most of the names in this file are the other way around, so lets go with that. https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode668 scm/stencil.scm:668: An @var{axis} of Y or 1 will flip it vertically. On 2015/05/06 06:01:30, lemzwerg wrote:
What about:
Value @code{X} (or @code{0}) for @var{axis} flips it horizontally. Value @code{Y} (or @code{1}) flips it vertically.
Exactly defined values for a variable should be represented with
`@code'. And
I'm a great fan of avoiding future tense in documentation :-)
Done. https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode668 scm/stencil.scm:668: An @var{axis} of Y or 1 will flip it vertically. On 2015/05/06 23:51:15, thomasmorley651 wrote:
Why not simply delete these two lines. I feel they are pretty much redundant.
Well Werner requested the "horizontal" and "vertical" language so I'll leave these lines in. I'm ok with erring on the side of a little redundancy for the sake of clarity. https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode669 scm/stencil.scm:669: @var{stil} is flipped in place. Its position, the On 2015/05/06 06:01:30, lemzwerg wrote:
I suggest s/./;/
Done. https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode670 scm/stencil.scm:670: X and Y coordinates of its bounding box, remains the same." On 2015/05/06 23:51:16, thomasmorley651 wrote:
I'd delete "X and Y" in order not to lead to confusing with the
meaning of X-
and Y-axis in LilyPond
Done. https://codereview.appspot.com/235090043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel