Thanks for the feedback. All fixed in patch set 2. -Paul
https://codereview.appspot.com/275770043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/275770043/diff/1/Documentation/changes.tely#newcode72 Documentation/changes.tely:72: \\markup { Ah, thanks, and thanks for those links. I got tripped up by copying the example from define-markup-commands.scm where the double '\' is needed. Fixed in patch set 2. https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm#newcode1143 scm/define-grob-properties.scm:1143: (whiteout ,boolean-or-symbol? "If a number or true, the grob is On 2015/11/03 11:52:28, Trevor Daniels wrote:
Shouldn't this be boolean-or-number>
Yes, good catch, thanks. Fixed in patch set 2. (I had started to change to the "whiteout and whiteout-thickness" approach, but then changed it back, and in the process forgot to change these predicates back as well.) https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm#newcode1149 scm/define-grob-properties.scm:1149: (whiteout-style ,number? "Determines the shape of the Yes, good catch, thanks. Fixed in patch set 2. https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm#newcode1150 scm/define-grob-properties.scm:1150: @code{whiteout} background. Available are @code{outline} and the Fixed in patch set 2. https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm#newcode1151 scm/define-grob-properties.scm:1151: default @code{box}.") Fixed in patch set 2. https://codereview.appspot.com/275770043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
