Re: Brings beamed rest closer to cross staff beam. (issue 5908043)

2012-04-24 Thread mike
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam->get_property_data ("direction") == ly_symbol2scm ("calculation-in-progress")) On 2012/04/25 06:21:54, Keith wrote

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-24 Thread mike
http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc#newcode1328 lily/beam.cc:1328: return scm_from_double (0.0); On 2012/04/25 06:21:29, Keith wrote: It would seem we do not want an early return i

Brings beamed rest closer to cross staff beam. (issue 5908043)

2012-04-24 Thread k-ohara5a5a
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam->get_property_data ("direction") == ly_symbol2scm ("calculation-in-progress")) Mike, any idea why you added this?

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-24 Thread k-ohara5a5a
The function being patched is the pure-alternative to a chained-offset-callback to the original Y-position callback for rests (Rest::y_offset_callback). I cannot follow the data between C and Scheme well enough to understand what this function should return if it needs to bail out early. The prob

Re: What's with the test-patches volunteers?

2012-04-24 Thread Graham Percival
On Wed, Apr 25, 2012 at 07:17:06AM +0200, David Kastrup wrote: > David Kastrup writes: > > > It is close to two months that I have been the only person running > > test-patches, even though several volunteers claimed they would do so. > > It has been the main reason I shelled out €20 for a week o

Re: What's with the test-patches volunteers?

2012-04-24 Thread David Kastrup
David Kastrup writes: > It is close to two months that I have been the only person running > test-patches, even though several volunteers claimed they would do so. > It has been the main reason I shelled out €20 for a week of internet > access during my spring vacation. > > My limited computing r

Re: web: add news about GSoC 2012 (issue 6112050)

2012-04-24 Thread janek . lilypond
Reviewers: Graham Percival, Message: On 2012/04/25 03:24:56, Graham Percival wrote: I get a "chunk mismatch" for the side-by-side comparison, but the actual patch is fine. Go ahead and push directly to staging. pushed as bf2c7f09ff00e6c59877eff5ba5f880299ed95bf, thanks! Description: web: a

web: add news about GSoC 2012 (issue 6112050)

2012-04-24 Thread graham
I get a "chunk mismatch" for the side-by-side comparison, but the actual patch is fine. Go ahead and push directly to staging. http://codereview.appspot.com/6112050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/

Re: Regarding LSR translation work

2012-04-24 Thread Francisco Vila
2012/4/24 Federico Bruni : > Il 24/04/2012 16:00, Phil Holmes ha scritto: > >> I'd be happy to make this a summer project, if you and Federico want to >> collaborate.  Can't start until the end of this year of college, though. > > > Thanks Phil, that would be great. > Let us know when you start, I'

Re: what shall we do with GSOC subpage on the website?

2012-04-24 Thread Carl Sorensen
On 4/24/12 2:31 PM, "Janek Warchoł" wrote: >I see two possibilities: >- delete it >- change it to "projects" or something like that. I think it would be >useful to have such a list - it's interesting for newcomers and allows >to check our progress and plan our development better than 600 tracker

Re: Regarding LSR translation work

2012-04-24 Thread Federico Bruni
Il 24/04/2012 16:00, Phil Holmes ha scritto: I'd be happy to make this a summer project, if you and Federico want to collaborate. Can't start until the end of this year of college, though. Thanks Phil, that would be great. Let us know when you start, I'll try to help as much as I can. Cheers,

Re: lilypond bug 2368

2012-04-24 Thread Karol Majewski
Thank you Phil. Dear LilyPond friends: Janek, Phil, Colin, I have another big problem now. I'm trying to find a global setting that would allow to ignore collisions between ties and accidentals. For me, a tie-accidental collision looks a way better than a shifted tie - especially in tied chords i

what shall we do with GSOC subpage on the website?

2012-04-24 Thread Janek Warchoł
I see two possibilities: - delete it - change it to "projects" or something like that. I think it would be useful to have such a list - it's interesting for newcomers and allows to check our progress and plan our development better than 600 tracker items. The question is, where we keep it, do we

Re: GSoC

2012-04-24 Thread David Kastrup
Janek Warchoł writes: > On Tue, Apr 24, 2012 at 7:56 PM, Kieren MacMillan > wrote: >> Hi Janek, >> >>> Just take a look at these issues - they are the Lyrics project: >>> http://code.google.com/p/lilypond/issues/list?q=label:GSoC-LyricProject >> >> WOW! What an amazing list — > > thanks, i'm fla

Re: announcing things like Mike's tour in News column?

2012-04-24 Thread Jean-Charles Malahieude
Le 24/04/2012 22:07, Janek Warchoł disait : On Tue, Apr 24, 2012 at 9:54 PM, Jean-Charles Malahieude wrote: Le 24/04/2012 21:33, Janek Warchoł disait : On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival I think it needs to come from people other than the main developers, though. We're all

Re: announcing things like Mike's tour in News column?

2012-04-24 Thread Janek Warchoł
On Tue, Apr 24, 2012 at 9:54 PM, Jean-Charles Malahieude wrote: > Le 24/04/2012 21:33, Janek Warchoł disait : >> >> On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival >>> >>> I think it needs to come from people other than the main >>> >>> developers, though.  We're all too burnt out and overworked

Re: announcing things like Mike's tour in News column?

2012-04-24 Thread Jean-Charles Malahieude
Le 24/04/2012 21:33, Janek Warchoł disait : On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival I think it needs to come from people other than the main developers, though. We're all too burnt out and overworked to get enthusiastic about something like this. Maybe. As for the news, i suggest a

Re: announcing things like Mike's tour in News column?

2012-04-24 Thread Janek Warchoł
On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival wrote: > On Fri, Apr 20, 2012 at 05:16:45PM +0200, Janek Warchoł wrote: >> On Fri, Apr 20, 2012 at 11:56 AM, David Kastrup wrote: >> > It reflects the news entries in the repository.  When a new LilyPond >> > Report appears, it _is_ announced ther

Re: GSoC

2012-04-24 Thread Janek Warchoł
On Tue, Apr 24, 2012 at 7:56 PM, Kieren MacMillan wrote: > Hi Janek, > >> Just take a look at these issues - they are the Lyrics project: >> http://code.google.com/p/lilypond/issues/list?q=label:GSoC-LyricProject > > WOW! What an amazing list — thanks, i'm flattered :) > especially if you can ac

Re: GSoC

2012-04-24 Thread Kieren MacMillan
Hi Janek, > Just take a look at these issues - they are the Lyrics project: > http://code.google.com/p/lilypond/issues/list?q=label:GSoC-LyricProject WOW! What an amazing list — especially if you can actually squash/improve all (or even most) of them! >> I have several bounty-worthy Lyrics issu

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-24 Thread Keith OHara
On Tue, 24 Apr 2012 09:21:17 -0700, wrote: If you replace *all* the while(flip()) loops, you can remove the flip function, Well, there will be one more place: spacing-spanner.cc:291 There is: while (flip (&d) != LEFT && rb); By now I can't tell what the whole code is for. Could you give m

Re: GSoC

2012-04-24 Thread Janek Warchoł
On Tue, Apr 24, 2012 at 10:17 AM, David Kastrup wrote: > Instead of joining the gratulations, let me _thank_ you for all the work > you put in to make it possible for you to work on major improvements on > LilyPond. You're welcome! > I urge you to be outspoken about "this could be so much > simp

Re: GSoC

2012-04-24 Thread Janek Warchoł
On Mon, Apr 23, 2012 at 11:01 PM, Kieren MacMillan wrote: > Jan, > >> Congratulations on having your Lyrics project accepted for Google Summer of >> Code! > > +1!! Thanks! > I will have to look back at the thread to see exactly what this "Lyrics > project" is… Just take a look at these issues

Re: GSoC

2012-04-24 Thread Janek Warchoł
On Mon, Apr 23, 2012 at 10:40 PM, Carl Sorensen wrote: > Congratulations on having your Lyrics project accepted for Google Summer > of Code! On Mon, Apr 23, 2012 at 11:14 PM, Trevor Daniels wrote: > Wow, congratulations from me too! You really did put the hours in to > generate a great submissi

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-24 Thread milimetr88
Reviewers: Keith, Graham Percival, http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode63 flower/include/direction.hh:63: // huh? On 2012/04/24 03:32:28

Re: Rename translation branch

2012-04-24 Thread David Kastrup
Francisco Vila writes: > 2012/4/24 Francisco Vila : >> 2012/4/24 David Kastrup : No objections then? Please go ahead. Thanks! I can take care of related docs. > > Patch for the rename in docs and lily-git.tcl The docs talk an awful lot about pushing to _master_. While that has nothing

Re: Rename translation branch

2012-04-24 Thread Francisco Vila
2012/4/24 Francisco Vila : > 2012/4/24 David Kastrup : >>> No objections then? Please go ahead. Thanks! >>> I can take care of related docs. Patch for the rename in docs and lily-git.tcl -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com 0001-Doc-rename-translation-branch.

Re: Rename translation branch

2012-04-24 Thread Francisco Vila
2012/4/24 David Kastrup : >> No objections then? Please go ahead. Thanks! >> I can take care of related docs. > > Moved it. Great! Thanks. So please, translators (correct me if I'm wrong): move lilypond/translation to translation using # I think you can not rename the branch currently checked out

Re: measure counter engraver

2012-04-24 Thread David Nalesnik
Hi Phil, On Tue, Apr 24, 2012 at 9:13 AM, Phil Holmes wrote: > ** > You're OK uploading it to the LSR providing you don't tag it with docs - > it's only those that are imported into the documentation system. > I'm just speaking here from the experience of checking a bunch of LSR files for the 2

Re: Rename translation branch

2012-04-24 Thread David Kastrup
Francisco Vila writes: > 2012/4/22 David Kastrup : >> Francisco Vila writes: >> >>> Hello, David and all, >>> >>> I'd like the lilypond/translation branch to be renamed to just >>> 'translation' if there are no objections. David, I recall you did >>> something similar for 'staging'. >>> >>> A go

Re: Rename translation branch

2012-04-24 Thread Francisco Vila
2012/4/22 David Kastrup : > Francisco Vila writes: > >> Hello, David and all, >> >> I'd like the lilypond/translation branch to be renamed to just >> 'translation' if there are no objections. David, I recall you did >> something similar for 'staging'. >> >> A good moment would be just after one or

Re: measure counter engraver

2012-04-24 Thread Phil Holmes
You're OK uploading it to the LSR providing you don't tag it with docs - it's only those that are imported into the documentation system. Phil Holmes - Original Message - From: David Nalesnik To: David Kastrup Cc: lilypond-u...@gnu.org ; lilypond-devel@gnu.org Sent: Tuesd

Re: Regarding LSR translation work

2012-04-24 Thread Carl Sorensen
On 4/24/12 7:56 AM, "Phil Holmes" wrote: >- Original Message - >From: "Graham Percival" >To: "Phil Holmes" >Cc: "Federico Bruni" ; >Sent: Tuesday, April 24, 2012 8:42 AM >Subject: Re: Regarding LSR translation work > > >> [1] of course there was some recent interest in this. But to pu

Re: Regarding LSR translation work

2012-04-24 Thread Phil Holmes
- Original Message - From: "Federico Bruni" To: "Graham Percival" Cc: Sent: Tuesday, April 24, 2012 1:28 PM Subject: Re: Regarding LSR translation work 2) ask the LSR author to add the possibility to insert translated titles and descriptions (the website itself could benefit from thi

Re: Regarding LSR translation work

2012-04-24 Thread Phil Holmes
- Original Message - From: "Francisco Vila" To: "Graham Percival" Cc: "Phil Holmes" ; Sent: Tuesday, April 24, 2012 9:10 AM Subject: Re: Regarding LSR translation work The problem is not LSR itself. Yes, the docs will look the same after, but it's not how the docs look like, either.

Re: Regarding LSR translation work

2012-04-24 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Federico Bruni" ; Sent: Tuesday, April 24, 2012 8:42 AM Subject: Re: Regarding LSR translation work [1] of course there was some recent interest in this. But to put some numbers on it: I was expecting ~3 contributo

Re: measure counter engraver

2012-04-24 Thread David Nalesnik
David, > .Any problems which > > might result will only affect that multi-file run? > > Basically every use of lilypond-book is a multi-file run. So are our > regtests. > Understood. I also won't upload this to the LSR at the current time since it could potentially cause annoyances the next tim

Re: Regarding LSR translation work

2012-04-24 Thread Federico Bruni
2012/4/24 Phil Holmes : > 1) I don't understand what "say hello to LSR" means. > sorry, I meant "goodbye to LSR" > 2) I don't really understand how LSR snippets are translated, so can't > comment knowledgably See CG, 5.8.3, Updating translation committishes (last two paragraphs). The translatio

Re: Regarding LSR translation work

2012-04-24 Thread Federico Bruni
2012/4/24 Carl Sorensen : >>> Let's manage all the doc snippets in Git and say hello to LSR import! >>> Which are the arguments against this change? >> >>It involves work.  In particular, horrible build system work, >>which always takes an order of magnitude longer than you might >>expect. > > If t

Re: Regarding LSR translation work

2012-04-24 Thread Federico Bruni
2012/4/24 Graham Percival : > On Tue, Apr 24, 2012 at 12:04:57AM +0200, Federico Bruni wrote: >> 1) manage all the docs snippets in Git and say hello to LSR (see >> bottom of my email) > > Do you mean "goodbye" instead of "hello" ? > sorry, yes of course I meant "goodbye" >> 2) ask the LSR autho

Re: measure counter engraver

2012-04-24 Thread David Kastrup
David Nalesnik writes: > On Tue, Apr 24, 2012 at 12:41 AM, David Kastrup wrote: > > Using define-event-class makes the file unfit for inclusion in > multi-file runs of LilyPond since define-event-class permanently > changes LilyPond. > > > I'm a little confused by the word

Re: GSoC

2012-04-24 Thread m...@apollinemike.com
> Francisco Vila writes: > >> 2012/4/23 Carl Sorensen : >>> Dear Jan, >>> >>> Congratulations on having your Lyrics project accepted for Google Summer >>> of Code! >> >> Contratulations! > I concur and I'm excited to mentor it! As ya'll know, I'll be doing my own summer-of-lily cleaning up

Re: measure counter engraver

2012-04-24 Thread David Nalesnik
David, On Tue, Apr 24, 2012 at 12:41 AM, David Kastrup wrote: > David Nalesnik writes: > > > The examples are written to work with the latest versions. (I'm using > > the current release candidate.) > > Then one could use make-engraver. > True, true. My motivation here was to allow it to work

Re: GSoC

2012-04-24 Thread David Kastrup
Francisco Vila writes: > 2012/4/23 Carl Sorensen : >> Dear Jan, >> >> Congratulations on having your Lyrics project accepted for Google Summer >> of Code! > > Contratulations! Instead of joining the gratulations, let me _thank_ you for all the work you put in to make it possible for you to work

Re: Regarding LSR translation work

2012-04-24 Thread Francisco Vila
2012/4/24 Francisco Vila : > I _am_ topposting. Let me explain a copule of things. Ouch! -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listi

Re: Regarding LSR translation work

2012-04-24 Thread Francisco Vila
I _am_ topposting. Let me explain a copule of things. "Ciao" is Italian for "hello" and also for "goodbye", so if you untranslate and then translate back, all becomes clear, at least for me. The problem is not LSR itself. Yes, the docs will look the same after, but it's not how the docs look like

Shortcutting countdowns on issues 2449 and 2489

2012-04-24 Thread David Kastrup
I'll commit the current patches on Patch: Change \bendAfter and \rightHandFinger into event functions http://code.google.com/p/lilypond/issues/detail?id=2489> and Issue 2449: Redesign stream event class representation http://code.google.com/p/lilypond/issues/detail?id=2449> about noonish.

Re: GSoC

2012-04-24 Thread Francisco Vila
2012/4/23 Carl Sorensen : > Dear Jan, > > Congratulations on having your Lyrics project accepted for Google Summer > of Code! Contratulations! -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilyp

Re: Regarding LSR translation work

2012-04-24 Thread Graham Percival
On Tue, Apr 24, 2012 at 07:52:55AM +0100, Phil Holmes wrote: > 3) Graham is wrong when he says writing snippets is not a good > introduction to lilypond. I started by doing a fair few that > documented undocumented features shown in the regtests. Sorry, I came on too strong there. I didn't mean