Re: not all doc "clean-ups" are good

>> Well, it helps in situations like this > ... >> which looks better with a break after the backslash: >> >> This is a paragraph with some text to >> demonstrate that a path name like /usr/ >> local/share/lilypond/foo.bar should be >> split after backslashes. > > Really?!

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc File lily/bezier.cc (right): http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d != LEFT); On 2011/08/19 07:03:50, MikeSol wrote: On 2011/08/18 21:3

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80 flower/polynomial.cc:80: return ret_max ? sols.back () : sols[0]; you could return an interval instead; Polynomi

Re: Make doc is broken

On 11-08-21 04:24 AM, Phil Holmes wrote: - Original Message - From: "Reinhold Kainhofer" To: Sent: Saturday, August 20, 2011 6:23 PM Subject: Re: Make doc is broken Hi Phil, Am Saturday, 20. August 2011, 16:26:48 schrieb Phil Holmes: I think Reinhold's commit cfcb9efdbd7c6600fc89f

PATCH: 48-hour countdown 22:00 MDT 20110824

For Wednesday August 25th, 22:00 Issue 1735 : modifying default behaviour of tremolo slashes - R 4636081 Issue 1628 : Fingerings collide wi

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#oldcode411 python/book_snippets.py:411: if not has_line_width: This change change be pushed now; it's gone through the co

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

On 2011/08/22 12:30:15, Reinhold wrote: Now, it's clear that lilypond produces .pdf files that are about 0.5-1 mm too wide. So we now have the proper way to fix #1816 What does "0.5-1mm" mean? Is it 0.5 for top/bottom, 1.0 for left/right? Or does it depend on some random factor? (i.e. whet

Re: Adds a site search to website and improves doc search (issue 4894053)

On Mon, Aug 22, 2011 at 11:06:04PM +0200, Janek Warchoł wrote: > Phil, could you compile the website with your changes and host it > somewhere? (or tell me how to do this properly) Partial instructions are buried in http://code.google.com/p/lilypond/issues/detail?id=1663 It would be nice if those

Re: oops! I've changed files in the `snippet' directory

On Sun, Aug 21, 2011 at 07:53:35AM +0200, Werner LEMBERG wrote: > > I think the commit message is enough for that? > > LSR: local import > > LSR: full import > > ? > > Is the format of this commit message fixed? I'm asking because a > script might search for it. No, because we don't have any fix

Re: not all doc "clean-ups" are good

On Sun, Aug 21, 2011 at 07:13:30AM +0200, Werner LEMBERG wrote: > Well, it helps in situations like this ... > which looks better with a break after the backslash: > > This is a paragraph with some text to > demonstrate that a path name like /usr/ > local/share/lilypond/foo.bar sh

can't reproduce issue 1732 in lilypond/translation (but 'make doc' still fails)

As I've reported in the comment here: http://code.google.com/p/lilypond/issues/detail?id=1732 now input/regression/midi/key-initial.ly is *always* compiled successfully in the lilypond/translation branch (while it still fails in master). I hoped that I could finally run 'make doc' but I still ge

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

2011/8/22 Janek Warchoł : > I wholeheartedly disagree, i think that this issue isn't negligible > (or did i misunderstood you, Han-Wen?). My impression is that the patch was not actually changing output. If it was intended to, I couldn't tell from a read of the patch. -- Han-Wen Nienhuys - han.

Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060)

Hi, i'm very interested in this, i've spotted this problem some time ago. Why is this Rietveld issue marked as closed? I'm adding a link in T issue 706 http://code.google.com/p/lilypond/issues/detail?id=706 I've tried it and it ate some ledger lines, but maybe i have dirty tree. Try this { 2 <

Re: Add hihat halfopen glyph to font (issue 4714043)

LGTM! (and sorry for delay) thanks, Janek http://codereview.appspot.com/4714043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue 4849054)

Pushed to master with commit - f41963f0b6135c02c363f8401628e85b9bc60def Ian Hulin http://codereview.appspot.com/4849054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

Just to make things clear, LGTM (and sorry for my long absence) Thanks for your work and your patience, James! Janek http://codereview.appspot.com/4837050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/l

Fixes missing images in web-big-page (issue 4922046)

Reviewers: Graham Percival, Message: Patch fixes the missing images in web-big-page.html. Please review. Description: This patch works by adding an extra part (web/) to the path to the css link and the example images links, and then using postprocess_html.py to get rid of this for the split fil

Re: GOP-PROP 8: issue priorities (probable decision)

LGTM (yeah, i'm quite late) 2011/8/16 Graham Percival : > On Sat, Aug 13, 2011 at 05:26:09PM +0100, Trevor Daniels wrote: >> >> I like Keith's "Needs". >> This easily extends to several labels if we >> find that is desirable.  Other suggestions: > > Thanks, I like "Needs_evidence"; it's general en

Re: GOP-PROP 9: behavior of make doc (probable decision)

- Original Message - From: "Janek Warchoł" To: "Graham Percival" Cc: Sent: Monday, August 22, 2011 5:18 PM Subject: Re: GOP-PROP 9: behavior of make doc (probable decision) Hm, LGTM? Phil, i'm amazed by your patience. thanks, Janek Deep into missing images at present... -- Phi

Re: GOP-PROP 9: behavior of make doc (probable decision)

Hm, LGTM? Phil, i'm amazed by your patience. thanks, Janek 2011/8/17 Graham Percival : > Not much discussion, not much change from the last version. > > http://lilypond.org/~graham/gop/gop_9.html > > > Proposal summary > > If there are build problems, then it should be easier to find out > why i

Re: Remove special case in staff-spacing (issue 4188051)

Keith, can you close Rietveld issue 4188051? thanks, Janek http://codereview.appspot.com/4188051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

patches for LilyPond issues 1503 and 1572

Hi Adam, apparently you didn't receive my previous e-mail, so i'm writing again. I'd like to help you with your patches about jazz chords display (issue 1503, and also you said that you have some patches for 1572). It looks like they are being overlooked. We should upload them to Rietveld so that

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

Hi, after disappearing for some time (sorry for that) i'm reading my inbox and found that guitar capo transposer isn't finished! Wol, how can i help you? Would you like me to investigate the scheme function about which you wrote on frogs list ("After capo handler comes capo key")? Maybe it would

[OT] Hungry?

We should definately prepare some of those if we ever organize a LilyPond developers meeting http://www.cuisine.com.au/recipe/Frogs-in-the-lily-pond :) Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/li

Re: Ends of barlines are hidden in staff lines. (issue 4809057)

Does this qualify for a regtest? http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc File lily/bar-line.cc (right): http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode48 lily/bar-line.cc:48: SCM staff_color = Staff_symbol_referencer::color (me); On 2011/08/13 15:55:0

Re: [PATCH] Lilypond-book: get rid of lilyquote snippet option, use quote instead

- Original Message - From: "Reinhold Kainhofer" To: "LilyPond Development" Sent: Monday, August 22, 2011 12:01 PM Subject: [PATCH] Lilypond-book: get rid of lilyquote snippet option,use quote instead Here's a patch that removes the lilyquote snippet option, since it doesn't really

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

Reviewers: lemzwerg, http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#newcode178 python/book_snippets.py:178: %% offset the left padding and tex2pdf needs a bit of on e

Re: dotcol_ variable in rhythmic-column-engraver.cc

Unused things can be thrown away. Period. If people need them, we can resurrect them from the git logs. On Mon, Aug 22, 2011 at 4:27 AM, Mike Solomon wrote: > This variable is unused - is it OK to get rid of it, or is someone planning > on building around it (I'm pretty sure it has been just h

Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

LGTM. Perhaps you should mention that reducing the line width by 1mm is a temporary hack. http://codereview.appspot.com/4940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Creates a Flag grob. (issue 4922042)

On 2011/08/22 12:52:05, hanwenn wrote: On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon wrote: > http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 > scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol > determining wh

[PATCH] Properly work around 1816: Reduce the linewidth by 1mm

Please review: http://codereview.appspot.com/4940043 Fix 1816: Lilypond-book: Give images 1mm less linewidth lilypond creates images that are wider than allowed (~0.5-1mm too wide, e.g. 160.51mm instead of 160mm), so workaround this by removing 1mm from the linewidth. Also remove code that make

Re: Creates a Flag grob. (issue 4922042)

On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon wrote: > http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 > scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol > determining what style of flag > rename to style? Unfortunately, then we don't have

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

Reviewers: dak, Message: On 2011/08/22 11:51:37, dak wrote: python/book_texinfo.py:228: val = float (m.group (1))/72 This would be wrong. TeX's principal unit, the pt or printer's point, is 1in/72.27. You are confusing this with PostScript points, 1in/72, which TeX calls bp (big points).

Re: [PATCH] Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode

Reinhold Kainhofer writes: > Please review: > http://codereview.appspot.com/4938044 > > This patch adds autodetection of linewidth and exampleindent to the texinfo > mode. This works by simply running a test file (with the layout settings > extracted from the original tely file) through texi2p

Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py#newcode228 python/book_texinfo.py:228: val = float (m.group (1))/72 This would be wrong. TeX's principal unit, the p

Re: fixing website translations

Il giorno lun, 22/08/2011 alle 00.57 -0700, Graham Percival ha scritto: > There is NO SUCH @node called {Text editor support}. You have > named that @node "LilyPond e gli editor di testo". So fix your > Documentation/it/web/introduction.itexi > > > Do the same for the other two lines as well.

[PATCH] Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode

Please review: http://codereview.appspot.com/4938044 This patch adds autodetection of linewidth and exampleindent to the texinfo mode. This works by simply running a test file (with the layout settings extracted from the original tely file) through texi2pdf, which prints out the value of the @

Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)

LGTM. http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py#newcode250 python/book_texinfo.py:250: if (QUOTE in snippet.option_dict): Why parentheses? Similar lines in t

[PATCH] Lilypond-book: get rid of lilyquote snippet option, use quote instead

Here's a patch that removes the lilyquote snippet option, since it doesn't really give any benefit over using the quote option. The only difference between the lilyquote and quote options so far was that with lilyquote the texinfo and doctitle was outside the example block. However, we didn't

Re: modifying default behaviour of tremolo slashes (issue 4636081)

Regtest added. http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118 lily/stem-tremolo.cc:118: shape = ly_symbol2scm ("beam-like"); On 2011/08/11 20:05:10, Neil Pu

Re: Creates a Flag grob. (issue 4922042)

On Aug 22, 2011, at 12:06 PM, reinhold.kainho...@gmail.com wrote: > > http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly > File input/regression/color.ly (right): > > http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 > input/regression/color.ly:

Re: Creates a Flag grob. (issue 4922042)

http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24: \override Flag #'color = #blue Why don't you choose a different color to c

Re: Creates a Flag grob. (issue 4922042)

Am Monday, 22. August 2011, 08:16:47 schrieb mts...@gmail.com: > I'm a fan of this. git blame already shows who did what (that said, I > was git blaming the other day and a lot of things show up as Graham > Percival because of the great indenting push of 2011 - is there a way to > see multiple lay

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

Am Monday, 22. August 2011, 09:49:41 schrieben Sie: > Yes, definitely do the pushing stuff in a separate patch. But here's an > outline: > 1. update with >git pull -r > 2. check you only have 1 patch ready with >git status That's the step where I like qgit, because it gives you a really g

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011/8/22 : > Yes, definitely do the pushing stuff in a separate patch.  But here's an > outline: > 1. update with >  git pull -r > 2. check you only have 1 patch ready with >  git status git status shows patches?? Didn't you mean "check that your work is nicely packed in one commit using git log

Re: GOP-PROP 8: issue priorities (probable 2)

On Sun, Aug 21, 2011 at 10:19:23AM +0100, Phil Holmes wrote: > Think we need to change the description of this on the tracker to > make it clear it's not just collisions. ok,done. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: fixing website translations

On Mon, Aug 22, 2011 at 12:57:41AM +0200, Federico Bruni wrote: > Il giorno ven, 12/08/2011 alle 09.07 -0700, Graham Percival ha scritto: > > > >> > WARNING: Unable to find node 'Text editor support' in book usage. > > > >> > WARNING: Unable to find node 'Troubleshooting' in book usage. > > > >> >

Re: changing shape of the G clef (issue 4664070)

pushed as e795110331497fbf46a7d61ed6ed73a9da4ae9c5 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. update with git pull -r 2. check you only have 1 patch ready with git status 3. upload your changes with git push http://codereview.appspot.com/4898058/ ___ lil

dotcol_ variable in rhythmic-column-engraver.cc

This variable is unused - is it OK to get rid of it, or is someone planning on building around it (I'm pretty sure it has been just hanging out not doing anything for at least a year). Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org h