http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right):
http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24: \override Flag #'color = #blue Why don't you choose a different color to check that the two grobs are really handled differently? http://codereview.appspot.com/4922042/diff/1/input/regression/flags-default.ly File input/regression/flags-default.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/flags-default.ly#newcode32 input/regression/flags-default.ly:32: \override Flag #'flag-style = #'mensural Can't we rename that to to style now? http://codereview.appspot.com/4922042/diff/1/lily/flag.cc File lily/flag.cc (right): http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode54 lily/flag.cc:54: '() or "grace"). */ That comment should be moved down to stroke-style http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode57 lily/flag.cc:57: SCM flag_style_scm = me->get_property ("flag-style"); Rename property to style http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode97 lily/flag.cc:97: if (scm_is_string (stroke_style_scm)) Sooner or later, that should be moved out from here into its own grob. Then we can also have slashed beamed grace notes (which don't have any flag). http://codereview.appspot.com/4922042/diff/1/lily/flag.cc#newcode149 lily/flag.cc:149: "flag-style " Rename that to style. http://codereview.appspot.com/4922042/diff/1/lily/tie-formatting-problem.cc File lily/tie-formatting-problem.cc (right): http://codereview.appspot.com/4922042/diff/1/lily/tie-formatting-problem.cc#newcode177 lily/tie-formatting-problem.cc:177: boxes.push_back (Box (flag->extent (x_refpoint_, X_AXIS), flag->extent (commony, Y_AXIS))); Line too long http://codereview.appspot.com/4922042/diff/1/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/4922042/diff/1/ly/engraver-init.ly#newcode787 ly/engraver-init.ly:787: \override Flag #'flag-style = #'no-flag rename to style http://codereview.appspot.com/4922042/diff/1/ly/engraver-init.ly#newcode787 ly/engraver-init.ly:787: \override Flag #'flag-style = #'no-flag Do we need/want a convert-ly warning for \override Stem #'flag-style? http://codereview.appspot.com/4922042/diff/1/ly/property-init.ly File ly/property-init.ly (right): http://codereview.appspot.com/4922042/diff/1/ly/property-init.ly#newcode429 ly/property-init.ly:429: \revert TabVoice.Flag #'flag-style rename to style http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol determining what style of flag rename to style? Unfortunately, then we don't have any documentation any more about the valid values... :( http://codereview.appspot.com/4922042/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
