Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

Colin Campbell shaw.ca> writes: > New today, for Friday: > Issue 621: > Dynamics should avoid cross-staff BarLines (e.g. > GrandStaff, PianoStaff etc) - Rietveld I should advertise that the patch on this issue includes a Docs change. After the patch we no longer need to teac

parser.yy: rearrange to allow more lenient use of music arguments for music functions. (issue4815052)

Reviewers: , Message: I should point out that I consider this a merge candidate. AFAICT, it passes the regtests. Description: parser.yy: rearrange to allow more lenient use of music arguments for music functions. This change may be somewhat contentious: it removes a lot of opportunities for sy

Re: modifying default behaviour of tremolo slashes (issue4636081)

New patch set uploaded. Minor style change: slash shape that was named "default" (which was confusing) is now named "parallelogram" (because that's how it looks like). If you don't like parallelograms ;) we can name it beam-like or sth. http://codereview.appspot.com/4636081/ ___

Re: Remove special case in staff-spacing (issue4188051)

On 2011/07/29 04:31:00, Janek Warchol wrote: Could you add some comments for rookies like me (the more, the better)? Some explanatory comments. (English takes a lot more space than C.) http://codereview.appspot.com/4188051/diff/17001/lily/spacing-spanner.cc File lily/spacing-spanner.cc (righ

Ends of barlines are hidden in staff lines. (issue4809057)

Reviewers: hanwenn, Message: http://lists.gnu.org/archive/html/lilypond-devel/2011-07/msg01051.html 2011/7/27 Han-Wen Nienhuys : Due to rounding, PDF viewers can err the placement of the barline by a pixel. [so that it looks like sticking out of staff] You can make the problem disappear by

Re: Postscript printer errors with rounded barlines?

2011/7/27 Han-Wen Nienhuys : > On Wed, Jul 27, 2011 at 3:23 PM, Jan Warchoł > wrote: > >>> I think this is an other issue.  Due to rounding, PDF viewers can err >>> the placement of the barline by a pixel. This is insolvable, as there >>> is no way to hint that the barline should coincide with the

Re: some comments do not appear in the tracker page

James, 2011/7/27 James Lowe : > Janek > > )On Behalf Of Janek Warchol: > )there is a problem with comments in the tracker.  At least 2 comments > )didn't make it to the "changing G clef" issue page: > )- Trevor's comment from July 26th, containing sentence "The G clef font > )was changed 18 months

Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

On Thu, 28 Jul 2011 05:46:29 -0700, wrote: Message: On 2011/07/26 02:17:28, Keith wrote: I like it, although I can still get the error if I put a new voice in the quoted expression like this: quoteMe = \relative c' \new Voice { Yeah, but then we have a general problem: Which voice do we

Re: Remove special case in staff-spacing (issue4188051)

Keith, I am so sorry - you've sent me this patch ages ago and i forgot about it! :( I've checked regtests to see how it works and it's great!! However, i cannot write any meaningful review, because i don't understand what's going on here at all :( Could you add some comments for rookies like me

auto numbering footnote checkin doesn't play with \null and \musicglyph

Mike, I *think* your recent checkin did something to your original \footnote[Grob] code because taking a snippet from my example in my in-progress doc patch \version "2.15.6" #(set-default-paper-size "a6") \book { \relative c' { c1 \breathe \footnoteGrob #'BreathingSign #'(1 . 1)

Re: New engraver for braces (issue4807053)

I updated the patch to work on the latest git HEAD. After doing a clean regtest comparison (git clean -fxd, config, make, make test-baseline, make check), I don't see anything. The logs' names show this is due to Mike's last commits. Regards, Bertrand http://codereview.appspot.com/4807053/ ___

Re: font: change breve vertical lines (issue4748044)

A pdf proof file is attached to tracker issue http://code.google.com/p/lilypond/issues/detail?id=1767 The gap in smallest font sizes was reduced according to Bertrand's suggestion, and the line height was increased just a bit according to my friend's suggestion. I don't feel strong about these ch

Re : little scheme problem (ly-> xml )

(define function-value-list '((duration . ( ,ly:duration-log )) (step . (,ly:pitch-notename )) (octave . (,ly:pitch-octave )) (test . (,display At the beginning of line 2, replace the apostrophe ' by ` (a semiquote in sc

Re: New engraver for braces (issue4807053)

Make is ok, but reg test gives me a few warnings on some reg tests. --snip-- /home/jlowe/lilypond-git/input/regression/footnote-auto-numbering.log @@ -9,28 +9,28 @@ Finding the ideal number of pages... Fitting music on 1 or 2 pages... Drawing systems... -programming error: Improbable off

Re: Doc: NR Added new Node for Footnotes (issue4751045)

note from Mike --snip-- I just pushed a patch for automatic footnotes. Everything you need to know about them exists in the two new regtests (233aad0ba9781e43424c4e77a859e42b660210e6). The most important thing to note is that, if people want to use non-automatic footnotes, they must now add fo

GOP-PROP 7: Developers as resources

http://lilypond.org/~graham/gop/gop_7.html Recent discussions have prompted me to clarify this. ** Proposal summary How should treat+view developers? I see three main contenders: 1. Independent volunteers: each person does whatever they want, whenever they want. We have busy careers and liv

Re: Current state of automatic footnotes. (issue4580041)

Many thanks to everyone for their help on this. Pushed as 233aad0ba9781e43424c4e77a859e42b660210e6. Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

It doesn't need to be ordered. It can have holes, but there's a small issue with this for now: Church rests are only looking for maximum and minimum values. You can therefore find longas in a church rest if you set usable-duration-logs to '(0 -1 -3). I don't know whether it's better to keep this s

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On 11-07-27 10:59 PM, Graham Percival wrote: On Wed, Jul 27, 2011 at 08:04:21PM -0600, Colin Campbell wrote: The list of patches still not dealt with is rather alarming: is it because devels are on holiday, am I missing the closed or fixed tags in Rietveld and Google Code? How can I help you fo

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On 11-07-28 12:48 AM, m...@apollinemike.com wrote: On Jul 28, 2011, at 4:04 AM, Colin Campbell wrote: New today, for Friday: Issue 621 : Dynamics should avoid cross-staff BarLines (e.g. GrandStaff, PianoStaff etc) - Rietveld Countdow

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On 11-07-28 01:16 AM, Reinhold Kainhofer wrote: On Do., 28. Jul. 2011 04:04:21 CEST, Colin Campbell wrote: Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732: Alignment problems when vertically stacking horizontally centered stencils. Issue : Allow manual

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

hi Bertrand, I started at the patch but it's quite difficult for now, I hope I'll have enough time in the evening. till then could you tell me whether usable-duration-logs is ordered? is it a range or can it have holes? thanks, p ___ lilypond-devel m

Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

Reviewers: J_lowe, Keith, Message: On 2011/07/26 02:17:28, Keith wrote: I like it, although I can still get the error if I put a new voice in the quoted expression like this: quoteMe = \relative c' \new Voice { Yeah, but then we have a general problem: Which voice do we want to quote?

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

> I should have write "2 << (-i + 1)" instead of "/2"... the +1 multiplies by 2, not divides. Whoops, I meant -(i + 1)... perhaps the best would be 1 << -i. Thanks. When I told you I never understood "<<", I wasn't kidding! An update will follow this comment. Bertrand http://codereview.

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

> To be honest, I never understood well how this bitset operator works. adds trailing zeros in binary. > What I see is that "2 << -i" gives the same result than "2^(-i+1)". > I should have write "2 << (-i + 1)" instead of "/2"... the +1 multiplies by 2, not divides. perhaps the best would be 1

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

http://codereview.appspot.com/4536068/diff/37002/lily/multi-measure-rest.cc#newcode241 lily/multi-measure-rest.cc:241: length = (2 << -i) / 2; The division by 2 changes the result. Not that I understand too well what it is supposed to be doing. To be honest, I never understood well how this

New engraver for braces (issue4807053)

Reviewers: , Message: Hi! This patchs allows to add braces the same way as arpeggios. Very useful for complex organ music. Check this out, there is several examples: http://imslp.org/wiki/12_Pi%C3%A8ces_pour_Orgue_(Gigout,_Eug%C3%A8ne) For the moment, the new engraver is a clone of Arpeggio_eng

Re : little scheme problem (ly-> xml )

Le 28/07/2011 13:36, lilypond-devel-requ...@gnu.org a écrit : Send lilypond-devel mailing list submissions to lilypond-devel@gnu.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.gnu.org/mailman/listinfo/lilypond-devel or, via email, send a message with

RE: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

Hello, )-Original Message- )From: m...@apollinemike.com [mailto:m...@apollinemike.com] )Sent: 28 July 2011 09:16 )To: James Lowe )Cc: Reinhold Kainhofer; Colin Campbell; Devel )Subject: Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29 )Importance: Low ) )On Jul 28, 2011, at 10:07 A

Re: review process not working

Reinhold Kainhofer writes: > And with the patch reviews and the patch countdown, at least we get > some feedback now. A while ago it used to be luck if you posted a > patch to the devel list and got one response eventually. Well, that's what I experience with my syntax extensions. I'm currently

Re: review process not working

Am Dienstag, 26. Juli 2011, 19:43:26 schrieb David Kastrup: > Reinhold Kainhofer writes: > > So, it seems the only one who is aware of those rounding problems is > > David. The question then is, why didn't David do a review of the patch > > and now complains that the process is not working? > > C

Re: little scheme problem (convert ly -> xml)

Jan Nieuwenhuizen writes: > bigcab writes: > >> (define function-value-list >> (('duration . ((lambda(x) (ly:duration-log x > > What are you trying to achieve by doing (lambda (x) (foo x))? > >> ('step . ((lambda(x) (ly:pitch-notename x >> ('test

Re: little scheme problem (convert ly -> xml)

bigcab writes: > (define function-value-list > (('duration . ((lambda(x) (ly:duration-log x What are you trying to achieve by doing (lambda (x) (foo x))? > ('step . ((lambda(x) (ly:pitch-notename x > ('test . ((lambda(x) (begin (display "s

Re: Moves tuplet numbers outside staff with their brackets. (issue4639075)

Pushed as 72210831b0366cb7c1f7009ba99a56538d68a7e5. Cheers, MS http://codereview.appspot.com/4639075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On Jul 28, 2011, at 10:07 AM, James Lowe wrote: > PA to Mike Solomon :) Even with my new virtual box, I am sometimes forgetting to take certain steps to get a clean baseline (i.e. forgetting to commit changes before deleting a branch, which leaves a set of files in my new branch, which then get

little scheme problem (convert ly -> xml)

Hi, As you know , I have started coding the ly-> xml in scheme, but as i want to make the code easier to read, I started to create a list of callback to retrieve information for example so I wrote this (for example): ;; once you retrived the good object you just have to extract its value ;; fu

RE: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Reinhold Kainhofer )Sent: 28 July 2011 08:16 )To: Colin Campbell; Devel )Subject: Re: PATCH: 48-Hour countdown to 20:00 MD

Re: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (issue4668045)

Pushed as eed6f105c0b478572ec2b8fa93e1f96c0c5869ba. Cheers, MS http://codereview.appspot.com/4668045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On Do., 28. Jul. 2011 04:04:21 CEST, Colin Campbell wrote: > Countdown done, but still open/not marked fixed: >  From Wednesday July 27 > Issue 732: Alignment problems when vertically stacking horizontally centered > stencils. > Issue : Allow manual directions on dynamics to break alignment