Re: GOP-PROP 5: build system output (probable decision)

Graham Percival wrote Thursday, July 21, 2011 6:37 AM Not much response from the previous GOP-PROP 5 (update); I'm not certain if "silence is a form of consent" [1] in this context. In my case it's because I have difficulty in understanding precisely what the effect of this change will be o

Re: Generating compiled scm (.go) files as part of LilyPond build

Greets, > On Tue 19 Jul 2011 15:28:41 BST, Andy Wingo wrote: >> On Tue 19 Jul 2011 15:18, Ian Hulin writes: >> >>> It may boil down to a matter of taste, but I find double and >>> triple extensions on a filename intrinsically nasty. I've normally >>> come across them before on Windows systems w

Re: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) (issue4630070)

Make is fine, the same reg test that showed a difference last time now shows that the text 'dim...' has been replaced by hairpins, is this what is wanted? See attached at http://code.google.com/p/lilypond/issues/detail?id=1433#c5 http://codereview.appspot.com/4630070/ _

PATCH: 48-hour countdown

New today, for 21:00 MST Friday July 22 Issue 1567 : Add documentation for footnotes - Rietveld Issue 4751045 : Doc: NR Added new Node for Footnotes Issue 1735

Re: Fix for Issue 620. (issue4814041)

On Jul 20, 2011, at 10:22 PM, pkx1...@gmail.com wrote: > It passes make, but I get a lot of reg test issues > > Mainly I can see: > +programming error: Improbable offset for stencil: -nan staff space > +Setting to zero. > +continuing, cross fingers > +programming error: Improbable offset for sten

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

On Jul 20, 2011, at 6:27 PM, n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly > File input/regression/glissando-stem.ly (right): > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 > inp

GOP-PROP 5: build system output (probable decision)

Not much response from the previous GOP-PROP 5 (update); I'm not certain if "silence is a form of consent" [1] in this context. [1] true story from a friend's lifeguard training. If somebody if choking but declines any help, the lifeguard (in Canada, at least) is legally obliged to watch the pers

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 2011/07/20 14:03:49, MikeSol wrote: I went back to my own plan after recent grob impurities - this passes regtests & causes slight differences in horizontal spacing in a couple tremolo related regtests that seem for the better. If someone could confirm the regtest check, I'd be much obl

Using #'prop1 #'prop2 instead of #'(prop1 prop2) in \revert for nested properties

Currently, the parser allows #'prop1 #'prop2 for nested properties in \override, but not in \revert: | OVERRIDE simple_string property_path '=' scalar { [...] } | REVERT simple_string embedded_scm { Is there any reason why revert does not use property_path instead

Do not issue rectstroke if blot diameter is 0.0. (issue4819041)

I can't see the diff. Please read: http://code.google.com/p/lilypond/issues/detail?id=1491 http://codereview.appspot.com/4819041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

GOP-PROP 3: C++ formatting (done)

The updated fixcc.py was pushed in ce4579d52589eea2d01717ee8362fe851fb9a295 An initial update of the CG was made in fda5ce3457daa5326985d032b9b8bf191cf6e129 but we'll probably need to fix up a few loose ends (IIRC we discuss formatting in 2-3 different places in the CG; I'll have a look at tha

Re: Postscript printer errors with rounded barlines?

> Werner, can you have a look at http://codereview.appspot.com/4819041 ? It looks OK, thanks! Currently, I get a server error on Rietveld, so I have to comment here. Please check spaces vs. tabs. Werner ___ lilypond-devel mailing list lilypond-

Re: stable/2.14 cannot compile regtests

On Wed, Jul 20, 2011 at 09:40:01PM -0700, Graham Percival wrote: > Can somebody check if > make test > works on stable/2.14, and if not, fix it? The GUB build died, > apparently on > input/regression/rest-polyphonic-2.ly aha, of course. That file is \version "2.15.0". Could somebody fix tho

stable/2.14 cannot compile regtests

Can somebody check if make test works on stable/2.14, and if not, fix it? The GUB build died, apparently on input/regression/rest-polyphonic-2.ly Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/

Re: Fix 1563: System start bars interpreted collapse-height as absolute length. (issue4693043)

Reviewers: J_lowe, Keith, Neil Puttock, Message: On 2011/07/18 20:24:43, Neil Puttock wrote: lily/system-start-delimiter.cc:117: staffspace = Staff_symbol_referencer::staff_space (sp); A mostly theoretical gripe, I guess: what about collapse-height comparisons where multiple staves are involve

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 2011/07/20 16:04:23, Neil Puttock wrote: On 20 July 2011 16:36, mailto:m...@apollinemike.com wrote: > I'm starting to doubt the viability of my local build...the regtests went off without a hitch. I wouldn't worry about that. Uninitialized members often

Re: Postscript printer errors with rounded barlines?

On Wed, Jul 20, 2011 at 1:07 AM, Werner LEMBERG wrote: > >> The patch below fixes it, and seems safe for inclusion, but it would >> be nice if we could understand something more. >> >> Werner, any insights? >> >> +     0.0 gt { 0 } { 2 } ifelse >> +     setlinecap > > Sorry, no.  Perhaps someone c

Re: Postscript printer errors with rounded barlines?

On Wed, Jul 20, 2011 at 1:07 AM, Werner LEMBERG wrote: >> The patch below fixes it, and seems safe for inclusion, but it would >> be nice if we could understand something more. >> >> Werner, any insights? >> >> +     0.0 gt { 0 } { 2 } ifelse >> +     setlinecap > > Sorry, no.  Perhaps someone can

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

On Wed, Jul 20, 2011 at 1:05 PM, m...@apollinemike.com wrote: >> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >> lily/beam.cc:706: Interval positions = robust_scm2interval >> ((*s)->get_property ("head-positions"), Interval (0,0)); >> rather than changing all callers, w

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

On Wed, Jul 20, 2011 at 11:30 PM, Han-Wen Nienhuys wrote: >>> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >>> lily/beam.cc:706: Interval positions = robust_scm2interval >>> ((*s)->get_property ("head-positions"), Interval (0,0)); >>> rather than changing all callers, wh

Re: Fix for Issue 620. (issue4814041)

It passes make, but I get a lot of reg test issues Mainly I can see: +programming error: Improbable offset for stencil: -nan staff space +Setting to zero. +continuing, cross fingers +programming error: Improbable offset for stencil: -nan staff space +Setting to zero. +continuing, cross fingers -

Re: Fix 1770: revert caused a crash in displayLilyMusic. (issue4805043)

Passes Make and reg tests http://codereview.appspot.com/4805043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Travel over the next week

I am traveling in Korea over the next week and may have limited email access. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over a line break) (issue4630070)

Am Mittwoch, 20. Juli 2011, 23:04:49 schrieben Sie: > Make is fine, the same reg test that showed a difference last time now > shows that the text 'dim...' has been replaced by hairpins, is this what > is wanted? Yes, I replaced them, because the text spanner's extender line didn't look good at a

Re: Issue 1724 -> 620 : workaround?

On Jul 20, 2011, at 4:26 PM, Neil Puttock wrote: > On 20 July 2011 13:27, Xavier Scheuer wrote: > >> I was wondering if you (or someone else) would have maybe a workaround >> I could use in order to have a fairly good output for the code attached >> to #1724 ? >> http://code.google.com/p/lilypon

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 20 July 2011 16:36, m...@apollinemike.com wrote: > I'm starting to doubt the viability of my local build...the regtests went off > without a hitch. I wouldn't worry about that. Uninitialized members often work fine; it might depend on your architecture. > I'll look into emending the pure h

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly File input/regression/glissando-stem.ly (right): http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 input/regression/glissando-stem.ly:10: \xenakisStem #(ly:make-duration

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

On Wed, Jul 20, 2011 at 9:32 AM, wrote: > A lot of files change because Stem::head_positions is now a callback.  I > may > even rename the property - it should really be called > extremal-positions, as > it describes the position of the extreme two heads (stems) or glissandi > (glissando stems).

Fix for Issue 620. (issue4814041)

Reviewers: , Description: Fix for Issue 620. Well, kinda... It fixes all of the issues merged into it, but this could be more generic. Please review this at http://codereview.appspot.com/4814041/ Affected files: M lily/axis-group-interface.cc M lily/hairpin.cc M lily/include/axis-group-

Re: Fix #1695: Clef change placed outside score. (issue4683043)

On 14 July 2011 15:59, wrote: > LGTM. > > Careful thinking about how to handle this.  Great job, Neil! Thanks. It took several drafts before I was happy with the explanation. :) (pushed: bebd93c2dd0d7363f311d912ec1ed1f7dfcb36ba) Cheers, Neil ___ li

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

On Jul 20, 2011, at 5:31 PM, hanw...@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 > lily/beam.cc:706: Interval positions = robust_scm2interval > ((*s)->ge

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On Jul 20, 2011, at 5:32 PM, n.putt...@gmail.com wrote: > On 2011/07/20 14:03:49, MikeSol wrote: >> I went back to my own plan after recent grob impurities - this passes > regtests & >> causes slight differences in horizontal spacing in a couple tremolo > related >> regtests that seem for the bett

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 lily/beam.cc:706: Interval positions = robust_scm2interval ((*s)->get_property ("head-positions"), Interval (0,0)); rather than changing

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 2011/07/20 14:03:49, MikeSol wrote: I went back to my own plan after recent grob impurities - this passes regtests & causes slight differences in horizontal spacing in a couple tremolo related regtests that seem for the better. If someone could confirm the regtest check, I'd be much obl

Re: Fix #1695: Clef change placed outside score. (issue4683043)

On 2011/07/19 22:38:30, Graham Percival wrote: Please push this; we'd like to get back to 0 Critical issues. I'm working on it now. Cheers, Neil http://codereview.appspot.com/4683043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://

Fix 1770: revert caused a crash in displayLilyMusic. (issue4805043)

Hi Reinhold, LGTM, though I wonder whether it'd be better just to junk 'grob-property and use 'grob-property-path exclusively. Cheers, Neil http://codereview.appspot.com/4805043/diff/1/input/regression/display-lily-tests.ly File input/regression/display-lily-tests.ly (right): http://coderevie

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

I went back to my own plan after recent grob impurities - this passes regtests & causes slight differences in horizontal spacing in a couple tremolo related regtests that seem for the better. If someone could confirm the regtest check, I'd be much obliged. Cheers, MS http://codereview.appspot.c

Re: Two different (potentially) conflicting Tremolo Patches being reviewed

On Jul 20, 2011, at 12:32 PM, James Lowe wrote: > Hello, > > I might be overstating this, so I apologise in advance. > > We have two patches that seem to 'touch' Tremolo spacing/shape code. > > http://codereview.appspot.com/4636081 - Janek W > > and > > http://codereview.appspot.com/4754054/

Produces better error messages when programmers forget to document a property. (issue4801045)

Reviewers: , Message: I've needed something like this for a long time - lemme know what you think! Cheers, MS Description: Produces better error messages when programmers forget to document a property. Please review this at http://codereview.appspot.com/4801045/ Affected files: M scm/docume

Creates a glissando stem grob that uses stems' functionality. (issue4777044)

Reviewers: , Message: Tries to minimize overlap with stem.cc - Glissando_stem::has_interface now appears four (indispensable) times in stem.cc. I think it is pretty modular. If I get run over by a truck and no one knows how to maintain this thing and people decide to delete glissando stems from

Re: change in treble clef - do you accept?

2011/7/13 Janek Warchoł : > > Hi, > > in the recent clef survey you said that you prefer current Lily clef over > mine. > I've modified my original suggestion - the clef is bigger now. It > looks like we're going to make the change, but nevertheless i'd like > to know your opinion about my revised

Two different (potentially) conflicting Tremolo Patches being reviewed

Hello, I might be overstating this, so I apologise in advance. We have two patches that seem to 'touch' Tremolo spacing/shape code. http://codereview.appspot.com/4636081 - Janek W and http://codereview.appspot.com/4754054/ - Mike S and while I have done reg test checks, I have only done them

Debugging the internal.texi build

Hey all, When doing build work, I often get: Writing "internals.texi"...ERROR: In procedure procedure-name: ERROR: Wrong type argument in position 1: #f because I forgot to document a property. It then takes me quite a long time to find the property I forgot - often it is a misspelled word, wh