On Jul 20, 2011, at 5:31 PM, hanw...@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 > lily/beam.cc:706: Interval positions = robust_scm2interval > ((*s)->get_property ("head-positions"), Interval (0,0)); > rather than changing all callers, why don't you put the get_property in > Stem::head_positions() ? >
Whatever is more LilyPondish I'll do - your suggestion would require creating another callback for the property, which seems like it may create confusion for future programmers (i.e. why is head_positions called in place X but the property head-positions called in place Y?). That's the reason I swapped out the function with property calls. But, again, I'm a relative newb - whatever you think is best I'll do. Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
