Thanks for all the comments.
Keith has identified the correct place to put include the system
horizontal padding, and it now works properly.
New patch set coming shortly.
Carl
http://codereview.appspot.com/3832046/diff/2001/input/regression/skyline-horizontal-padding.ly
File input/regression
On Mon, Jan 03, 2011 at 03:15:22AM +, Graham Percival wrote:
> On Sun, Jan 02, 2011 at 04:37:35PM -, Phil Holmes wrote:
> > "
> > Priority-Critical: LilyPond segfaults, a regression (see below)
> > against a previous stable version or a regression against a fix
> > developed for this versio
On Sun, Jan 02, 2011 at 04:37:35PM -, Phil Holmes wrote:
> "
> Priority-Critical: LilyPond segfaults, a regression (see below)
> against a previous stable version or a regression against a fix
> developed for this version. This does not apply where the
> "regression" occurred because a feature
On Sun, Jan 02, 2011 at 11:35:33AM +0100, Matthias Kilian wrote:
> On Sun, Jan 02, 2011 at 12:55:45AM +, Graham Percival wrote:
> > > Bisected to this one (cc'd Neil):
> >
> > Fantastic! Bisecting is one of the most useful, yet also
> > time-consuming, parts of fixing regressions.
>
> Maybe
I've fixed the problems Neil identified in the regtest, but it's still
setting the parent twice, and I'm aware that there's still discussion
between Joe and Matthias about this patch.
I'm mainly putting this on reitveld in case people want to discuss it by
adding comments to places, rather than e
On Jan 2, 2011, at 9:47, "Bertalan Fodor (LilyPondTool)"
wrote:
> You should consider using a proper logging framework with different
> logging levels.
>
That is a really good idea. There are a few gotchas that need addressing, for
example the use of ly:message to emit warnings and such, but
It is interesting to see what gets horizontally padded and what does not
-- accidentals do not, for example.
Whether by accident or design, the choices on what to pad seem
reasonable.
It seems that the same padded skyline is used both for page layout, and
for drawing the outer skylines with debug
LGTM, could you send me a patch to apply? (git format-patch origin)
http://codereview.appspot.com/3825043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Yippee for the patch.
Doesn't quite work yet, probably because the function that uses your new
code, append_prob, is not used in the situation where we need the extra
padding. append_system is called. (Confirmed by printf-debugging using
your and my .ly test files)
http://codereview.appspot.com
On 2 January 2011 16:48, Sven Axelsson wrote:
> On 2 January 2011 16:27, Carl Sorensen wrote:
>> override-auto-beam-setting doesn't work in 2.13. Please try your example in
>> 2.13.
>
> Yes, I just realised that myself. Sorry about that.
>
> I have updated http://codereview.appspot.com/3825043/
On 2 January 2011 20:22, Daniel Dadap wrote:
> Sven Axelsson wrote:
>> I am the author of the bagpipe.ly mode included in the Lilypond
>> distribution. I'm sorry I haven't been very visible here the last
>> several years. I haven't had much user feedback for the bagpipe mode,
>> although I know th
On Sun, Jan 02, 2011 at 04:18:17PM -, Phil Holmes wrote:
> "In your original backtrace, is the X_AXIS parent of the Item in frame #2
> 0x0? If so, I'm fine with the patch."
>
> I've been using this as a learning exercise, and can say that
> Item::spanned_rank_interval calls Item::get_column
Sven Axelsson wrote:
> I am the author of the bagpipe.ly mode included in the Lilypond
> distribution. I'm sorry I haven't been very visible here the last
> several years. I haven't had much user feedback for the bagpipe mode,
> although I know there are people out there using it.
Hi Sven. You are
On 1 January 2011 13:10, Matthias Kilian wrote:
> It could be possible to check the result of get_column() in
> Item::spanned_rank_interval(), but I'm not sure wether this is the
> *proper* bug fix (nor what interval should be returned in this
> case).
The issue is that the parent shouldn't be a
LGTM, but I'd rather we didn't set the parent twice (at least in the
default case where BreakAlignment is acknowledged; obviously once the
engraver's moved, this acknowledger never gets called).
Cheers,
Neil
http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasu
[snip long-ish discussion]
OK, I think we reached a conclusion on this and so would like to make a
patch. I propose:
"
Priority-Critical: LilyPond segfaults, a regression (see below) against a
previous stable version or a regression against a fix developed for this
version. This does not ap
Joe asked:
"In your original backtrace, is the X_AXIS parent of the Item in frame #2
0x0? If so, I'm fine with the patch."
I've been using this as a learning exercise, and can say that
Item::spanned_rank_interval calls Item::get_column to return the parent, as
below.
Paper_column *
Item::g
On 2 January 2011 16:27, Carl Sorensen wrote:
> override-auto-beam-setting doesn't work in 2.13. Please try your example in
> 2.13.
Yes, I just realised that myself. Sorry about that.
I have updated http://codereview.appspot.com/3825043/ accordingly.
--
Sven Axelsson
++[>++>++
On 1/2/11 8:02 AM, "Sven Axelsson" wrote:
> On 2 January 2011 15:30, Carl Sorensen wrote:
>> On 1/2/11 4:56 AM, "Sven Axelsson" wrote:
>>
>>> On 2 January 2011 12:23, Sven Axelsson wrote:
On 2 January 2011 00:35, wrote:
> looks mostly ok, but I don't know what's up with those beami
On 2 January 2011 15:30, Carl Sorensen wrote:
> On 1/2/11 4:56 AM, "Sven Axelsson" wrote:
>
>> On 2 January 2011 12:23, Sven Axelsson wrote:
>>> On 2 January 2011 00:35, wrote:
looks mostly ok, but I don't know what's up with those beaming rules.
http://codereview.appspot.c
You should consider using a proper logging framework with different
logging levels.
Bert
On 1/2/11, Graham Percival wrote:
> On Sat, Jan 01, 2011 at 02:25:57AM -0500, David Santamauro wrote:
>>
>> On Sat, 1 Jan 2011 10:19:18 +
>> Graham Percival wrote:
>>
>> > http://code.google.com/p/lilyp
On 1/2/11 4:56 AM, "Sven Axelsson" wrote:
> On 2 January 2011 12:23, Sven Axelsson wrote:
>> On 2 January 2011 00:35, wrote:
>>> looks mostly ok, but I don't know what's up with those beaming rules.
>>>
>>>
>>> http://codereview.appspot.com/3825043/diff/1/ly/bagpipe.ly
>>> File ly/bagpipe.ly
On 2 January 2011 12:23, Sven Axelsson wrote:
> On 2 January 2011 00:35, wrote:
>> looks mostly ok, but I don't know what's up with those beaming rules.
>>
>>
>> http://codereview.appspot.com/3825043/diff/1/ly/bagpipe.ly
>> File ly/bagpipe.ly (right):
>>
>> http://codereview.appspot.com/3825043/
On Sun, Jan 02, 2011 at 11:45:20AM -, Phil Holmes wrote:
> What's the simplest way to revert to the "proper" source, rather
> than the stuff I've edited, to ensure my source tree is clean?
git reset --hard origin
It's in the CG chapter on source code.
> In doing this, I've been following the
On 2 January 2011 12:45, Phil Holmes wrote:
> I've been experimenting with putting trace messages in Lily by editing the
> source, make and then using DDD to watch what's going on. My question:
>
> What's the simplest way to revert to the "proper" source, rather than the
> stuff I've edited, to e
I've been experimenting with putting trace messages in Lily by editing the
source, make and then using DDD to watch what's going on. My question:
What's the simplest way to revert to the "proper" source, rather than the
stuff I've edited, to ensure my source tree is clean?
In doing this, I'v
On Sun, Jan 02, 2011 at 12:35:28PM +0100, Matthias Kilian wrote:
> > In your original backtrace, is the X_AXIS parent of the Item in frame #2
> > 0x0? If so, I'm fine with the patch.
>
> You mean the g in line 197 of axis-group-interface.cc?
>
> Interval_t rank_span = g->spanned_rank_interv
On Sun, Jan 02, 2011 at 08:39:03AM +0700, Joe Neeman wrote:
> > I tried the diff below, which `fixed' the segfault, but it may be
> > completely wrong (I'm currently not familiar with the LilyPond code
> > at all). Unfortunately, I don't have a new enough ImageMagick on my
> > system, so I can't ru
hi Joe,
>>> Comment #9 on issue 1268 by joeneeman: [PATCH] span-bar problem
>>> http://code.google.com/p/lilypond/issues/detail?id=1268
>>>
>>> I've tracked the problem down to Bar_line::compound_barline,
>>> which tries to
>>> center the bar line around the center of the staff
>>> (see lines 119
Graham,
Looks like Joe fixed this (please correct me if I'm wrong).
I'll keep my eyes out for new critical issues before I take off.
Cheers,
MS
On Jan 2, 2011, at 2:21 AM, Graham Percival wrote:
> On Sat, Jan 01, 2011 at 12:21:24PM +0100, m...@apollinemike.com wrote:
>>
>> I have a flight on J
On 2 January 2011 00:35, wrote:
> looks mostly ok, but I don't know what's up with those beaming rules.
>
>
> http://codereview.appspot.com/3825043/diff/1/ly/bagpipe.ly
> File ly/bagpipe.ly (right):
>
> http://codereview.appspot.com/3825043/diff/1/ly/bagpipe.ly#newcode72
> ly/bagpipe.ly:72: #(ove
On Sun, Jan 02, 2011 at 12:55:45AM +, Graham Percival wrote:
> > Bisected to this one (cc'd Neil):
>
> Fantastic! Bisecting is one of the most useful, yet also
> time-consuming, parts of fixing regressions.
Maybe time-consuming, but in theory, everyone able to build lilypond
from git can wri
http://codereview.appspot.com/3832046/diff/2001/input/regression/skyline-horizontal-padding.ly
File input/regression/skyline-horizontal-padding.ly (right):
http://codereview.appspot.com/3832046/diff/2001/input/regression/skyline-horizontal-padding.ly#newcode13
input/regression/skyline-horizontal
33 matches
Mail list logo
