LGTM, but I'd rather we didn't set the parent twice (at least in the
default case where BreakAlignment is acknowledged; obviously once the
engraver's moved, this acknowledger never gets called).

Cheers,
Neil




http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasure-rest-no-segfault.ly
File input/regression/metronome-multimeasure-rest-no-segfault.ly
(right):

http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasure-rest-no-segfault.ly#newcode1
input/regression/metronome-multimeasure-rest-no-segfault.ly:1: \version
"2.13.44"
2.13.45

http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasure-rest-no-segfault.ly#newcode11
input/regression/metronome-multimeasure-rest-no-segfault.ly:11: \new
Staff {
fix indentation

http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasure-rest-no-segfault.ly#newcode24
input/regression/metronome-multimeasure-rest-no-segfault.ly:24:
\consists "Staff_collecting_engraver"
remove (already present in engraver-init.ly)

http://codereview.appspot.com/3858041/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to