Yippee for the patch.
Doesn't quite work yet, probably because the function that uses your new
code, append_prob, is not used in the situation where we need the extra
padding. append_system is called. (Confirmed by printf-debugging using
your and my .ly test files)
http://codereview.appspot.com/3832046/diff/2001/input/regression/skyline-horizontal-padding.ly
File input/regression/skyline-horizontal-padding.ly (right):
http://codereview.appspot.com/3832046/diff/2001/input/regression/skyline-horizontal-padding.ly#newcode13
input/regression/skyline-horizontal-padding.ly:13: \repeat unfold 80 {
<c'''-1 e'''-3 g'''-5> c' <c,-1 e,-3 g,-5> c' }
On 2011/01/02 09:01:11, Trevor Daniels wrote:
Can not a more precise and shorter test
I had a test file for 1290, and related, that shows what does and does
not get displaced by the various skylines:
#(ly:set-option 'debug-skylines #t)
\score {
{
\repeat unfold 2 {
\mark "mark"
a,2_"fa" gisis'''!^"gg" |
\mark "m"
b,4 a'_"tx" c'2 \break
}
} \layout {
ragged-right = ##t
indent = #0
\context {
\Score
\override System #'skyline-horizontal-padding = #0.0
\override TimeSignature #'stencil = ##f
}
}
}
http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc#newcode204
lily/page-layout-problem.cc:204: Real minimum_distance =
up_skyline.distance (bottom_skyline_) + padding;
We need to call your distance here, no?
http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc#newcode266
lily/page-layout-problem.cc:266: Page_layout_problem::append_prob (Prob
*prob, Spring const& spring, Real padding)
This function is not called for either of our test cases.
http://codereview.appspot.com/3832046/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
