Re: [GSoC] Hello!

2014-05-16 Thread Cedric Bosdonnat
Hello Mihai, Welcome aboard! I'm also eager to start that great project with you ;) -- Cedric On Mon, 2014-05-12 at 23:06 +0300, Mihai Varga wrote: > Hello everyone ! > > > My name is Mihai and I have been selected to participate in this > year's GSoC program. I will be working on the SharePoi

GSoC mid-term evaluations NOW

2014-06-16 Thread Cedric Bosdonnat
Hi GSoC mentors, The mid-term evaluations are just now! So, head to Google Melange and submit them before Friday. In case you really can't fill the evaluation your self, ask either your co-mentor or one of your beloved admins (Fridrich, Thorsten or myself) to do it. Below are the questions of the

Re: GSoC mid-term evaluations NOW

2014-06-16 Thread Cedric Bosdonnat
Ooops! Sorry guys, wrong week... you have the questions in advance for next week ;) -- Cedric On Tue, 2014-06-17 at 08:06 +0200, Cedric Bosdonnat wrote: > Hi GSoC mentors, > > The mid-term evaluations are just now! So, head to Google Melange and > submit them before Friday. In cas

Re: GSoC mid-term evaluations NOW

2014-06-26 Thread Cedric Bosdonnat
Bjoern > > On Tue, Jun 17, 2014 at 08:06:30AM +0200, Cedric Bosdonnat wrote: > > The mid-term evaluations are just now! So, head to Google Melange and > > submit them before Friday. In case you really can't fill the evaluation > > your self, ask either your co-mentor o

Re: [GSoC] Varga Mihai - progress report week 6

2014-07-01 Thread Cedric Bosdonnat
Hi Mihai, On Tue, 2014-07-01 at 16:22 +0300, Mihai Varga wrote: > Last week I implemented a dialog which asks the user to open an URL in > the browser and a code from the one he has been redirected to. The > interaction was needed as the OneDrive authentication can not be > completed programmatica

GSoC wrap up

2014-09-18 Thread Cedric Bosdonnat
Hi mentors and students, I'll require each mentor/student team to provide me a blob about what they did. This will be used to write a wrap up blog post that Google can reblog later. Thanks for your help -- Cedric ___ LibreOffice mailing list LibreOffic

Re: [Libreoffice] ixion breakage in sw

2010-11-22 Thread Cedric Bosdonnat
On Tue, 2010-11-16 at 12:36 +0100, Miklos Vajna wrote: > On Tue, Nov 16, 2010 at 12:23:40PM +0100, Henrik /KaarPoSoft > wrote: > > It has been suggested to remove fields-table-formula.diff. > > However, in the "apply" file, it is listed under [Fixes] which is > > included in "Common", which is i

[Libreoffice] [UX] Some dirty stuffs around styles in calc

2010-12-01 Thread Cedric Bosdonnat
Hi all, The other day when playing with a calc document, I discovered an annoying "feature". Create a new spreadsheet, protect one of the sheets and try to modify the cell styles: nothing shows up when clicking on the "Modify..." context menu. I had to run a debug session in sc to understand that

[Libreoffice] Fix for fdo#31190 to review for 3.3

2010-12-02 Thread Cedric Bosdonnat
Hi all, I've fixed fdo#31190, and it looks like something that could be integrated in 3.3 but before pushing to the branch, I'ld like to have some peer review. The patch is attached to the issue. https://bugs.freedesktop.org/show_bug.cgi?id=31190 Regards, -- Cédric Bosdonnat LibreOffice hacker

[Libreoffice] Review fix for fdo#32039 for inclusion in 3.3

2010-12-02 Thread Cedric Bosdonnat
Caolan, Michael, Miklos, Could you please have a look at the patch attached to https://bugs.freedesktop.org/show_bug.cgi?id=32039 ? I'ld like to push that fix for 3.3 as the bug is a regression introduced by our rework of the RTF export filter. Regards, -- Cédric Bosdonnat LibreOffice hacker ht

Re: [Libreoffice] Contributing test cases

2010-12-03 Thread Cedric Bosdonnat
Hi Michael, On Fri, 2010-12-03 at 11:57 +, Michael Meeks wrote: > It failed after only a handful of documents on the attached with: > > #0 0xabd83b95 in > writerfilter::dmapper::DomainMapper_Impl::finishParagraph(boost::shared_ptr) > () >from /data/opt/OOInstall/program/../basis-

Re: [Libreoffice] LibreOffice-Plug-In for Netbeans?

2010-12-06 Thread Cedric Bosdonnat
Hi Andreas, On Sat, 2010-12-04 at 17:13 +0100, Andreas Mantke wrote: > there is already a Netbeans-Plug-In for OOo. But this plug-in doesn't work > for me > with LibreOffice and it's SDK. Because of this I'm curious, if someone is > working on > such a plug-in for LibreOffice. It's very unlik

Re: [Libreoffice] [UX] Some dirty stuffs around styles in calc

2010-12-06 Thread Cedric Bosdonnat
Hello Christoph, On Mon, 2010-12-06 at 23:54 +0100, Christoph Noack wrote: > thanks for having a look at that. And thanks for the good explanation! > It took me a while, since the problem is not only valid for Calc, but > also valid for all elements/documents that support protection. Hum, I shoul

[Libreoffice] Review of fdo#32172 for 3.3 inclusion

2010-12-09 Thread Cedric Bosdonnat
Hi caolan, all, Could you please review the commit for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32172 It could be nice to have it in 3.3 as well... Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonn

[Libreoffice] Any taker for a starmath bug?

2010-12-14 Thread Cedric Bosdonnat
Hello people, I know there are quite a few persons interested or knowing the starmath code... Is there any taker for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32362 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http:

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

2010-12-15 Thread Cedric Bosdonnat
On Tue, 2010-12-14 at 21:19 +0100, Jan Holesovsky wrote: > writer Done for the fix of i#115956. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Removing sw/source/filter/ww8/dump

2010-12-21 Thread Cedric Bosdonnat
Hi Caolan, others, I have wondered for a long time if sw/source/filter/ww8/dump is still used by someone... it doesn't even seems to be built. Would anyone oppose to this removal? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http

[Libreoffice] [REVIEW] Push patch to 3.3

2010-12-21 Thread Cedric Bosdonnat
Hi all, I have just finished a patch fixing a few enhanced fields issues like: * Not allowing to type before the field in protected mode * Import fields with 0-length content properly * Fix crash when exporting those imported fields The patch is sitting here: http://cgit.freedesktop.org/lib

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

2010-12-22 Thread Cedric Bosdonnat
Bonjour Guillaume, On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote: > I use LibreOffice almost every day and I'm interested in Open Source > softwares, so I would like to contribute. Then be welcomed among LibreOffice develers! > > I have grabbed the code and compile it. Then, i had

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

2010-12-22 Thread Cedric Bosdonnat
Hello Guillaume, On Wed, 2010-12-22 at 17:53 +0100, Guillaume Poussel wrote: > I was not sure about git diff or git format-patch. Next time it would > be better :) Don't hesitate to join the IRC channel #libreoffice to raise questions like this: there are several git experts hanging there (maybe

Re: [Libreoffice] Replacement table enhancement for Braille table

2011-01-03 Thread Cedric Bosdonnat
Hello Sophie, On Tue, 2010-12-28 at 17:12 +0300, Sophie Gautier wrote: > Now would it be possible to enhance the replacement table so that we can > execute the pattern *oe* to be replaced by the pattern *oeu* in each > word containing this first pattern, that could be at the beginning of > the

Re: [Libreoffice] Annoying cursor behavior on sw tables

2011-01-03 Thread Cedric Bosdonnat
Hi Octavio, On Wed, 2010-12-29 at 20:58 -0800, Octavio Alvarez wrote: > Now, look at this, this blog post documents the patch: :-O > > http://cedric.bosdonnat.free.fr/wordpress/?p=472 Hum, thanks for poking me on it... I would have skipped the thread otherwise. > The thing is that Window::Inval

[Libreoffice] unopkg --suppress-license

2011-01-04 Thread Cedric Bosdonnat
Hello hackers, I would like to make the --suppress-license option of unopkg skip the license in all cases instead of depending on what is in the extension's description.xml //simple-licen...@suppress-if-required]. http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Descript

Re: [Libreoffice] [REVIEW] unopkg --suppress-license

2011-01-05 Thread Cedric Bosdonnat
Hello Kohei, others, I have created a bug report for this (fdo#32840)... and fixed it in master branch. Could someone review it for a possible integration in 3.3 ? Regards, -- Cedric On Tue, 2011-01-04 at 16:09 -0500, Kohei Yoshida wrote: > On Tue, 2011-01-04 at 22:04 +0100, Cedric Bosdon

Re: [Libreoffice] [PATCH] set RPATH correctly in the internal ICU

2011-01-06 Thread Cedric Bosdonnat
Hi Petr, At first glance it looks OK to me, but I'm no build script expert... I may have missed some important stuffs. -- Cedric On Wed, 2011-01-05 at 20:22 +0100, Petr Mladek wrote: > Hi, > > our build service found broken RPATH in libicudata.so.42.1; it is fixed > by the attached patch > > C

Re: [Libreoffice] [PATCH] [PUSHED] Re: Annoying cursor behavior on sw tables

2011-01-06 Thread Cedric Bosdonnat
ons :) Regards, On Mon, 2011-01-03 at 09:00 -0800, Octavio Alvarez wrote: > On Mon, 03 Jan 2011 01:52:01 -0800, Cedric Bosdonnat > wrote: > >> The thing is that Window::Invalidate() gets called if I move or if I > >> type > >> inside a table cel

[Libreoffice] Review request

2011-01-11 Thread Cedric Bosdonnat
Hello, I'ld like to get a crasher fix around the enhanced fields into libreoffice-3-3 branch... Could anyone review and cherry-pick this commit? http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347377be119 Thanks, -- Cédric Bosdonnat LibreOffice hacker htt

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-25 Thread Cedric Bosdonnat
Hi David, What's the status of this patch? pushed or needs some tweaks? -- Cedric On Fri, 2011-01-21 at 09:39 +0100, David Tardon wrote: > On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: > > On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: > > > On Sat, 2011-

Re: [Libreoffice] sw/filter/ww1

2011-01-26 Thread Cedric Bosdonnat
On Tue, 2011-01-25 at 15:41 +, Caolán McNamara wrote: > Not quite, ww8 is "WinWord8", but handles the Microsoft Word 6, 7 and > 8+ binary formats. To complicate matters it handles Word for Windows 2 > file format as well, and some in-betweeny versions. > > ww1 is "Word for Windows 1" IIRC and

Re: [Libreoffice] [PATCH][PUSHED] ure: Some fixes to documentation (part 2)

2011-01-27 Thread Cedric Bosdonnat
Hello Aurimas, I just pushed your patch to the master branch. Thank you so much for all those IDL references fixes :) Feel free to continue providing patches like this one! On Tue, 2011-01-25 at 20:27 +0200, Aurimas Fišeras wrote: > Affected folders: > offapi/com/sun/star/form - offapi/com/sun/st

Re: [Libreoffice] [PATCH] Rename "Default Formatting" --> "Clear Direct Formatting"

2011-01-27 Thread Cedric Bosdonnat
Hello Octavio, Many thanks for those changes. I've pushed them in the master branch. Feel free to continue improving Writer like that :) On Fri, 2011-01-21 at 15:09 -0800, Octavio Alvarez wrote: > Hi. > > The purpose of the following set of patches is to rename "Default > Formatting" to "Clear D

Re: [Libreoffice] [PATCH] removed some bogus comments

2011-01-27 Thread Cedric Bosdonnat
Hello Suguru, First, many thanks for your patch! On Thu, 2011-01-27 at 01:43 +0900, suguru hirahara wrote: > I made a patch file. Please notice me if there's any mistake. Well, you removed entirely some comments containing references to some public bug reports (they look like #i12345#). In this

Re: [Libreoffice] Patches by two persons?

2011-01-28 Thread Cedric Bosdonnat
On Thu, 2011-01-27 at 17:51 +0100, Miklos Vajna wrote: > > Until now we have committed the patches, by me committing them, but as > > it seems we are doing a lot of patches, it would be nice to know what > > is the preferred way to do it: > > - Should we put both our names in the git patch file (th

Re: [Libreoffice] SCID_NEWDOCUMENT

2011-01-31 Thread Cedric Bosdonnat
On Fri, 2011-01-28 at 21:22 +, Nigel Hawkins wrote: > On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: > > I'm still translating comments and came across a constant named > > SCID_NEWDOCUMENT. When I asked opengrok the only place where this > > constant was found was the file reche

Re: [Libreoffice] [PATCH] Commented out some unused functions in calc

2011-01-31 Thread Cedric Bosdonnat
Hi Alfonso, On Sat, 2011-01-29 at 15:10 +, Alfonso Eusebio wrote: > Hi, > > I've been going through the list of identified unused functions in calc and > commenting out those that don't seem to be used anywhere. Why don't you simply remove them and check if it still builds? Regards, -- Cé

Re: [Libreoffice] [PATCH] added translation to description.xml

2011-01-31 Thread Cedric Bosdonnat
On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: > added Russian translation to dictionaries/ru_RU/description.xml Many thanks for your patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.

Re: [Libreoffice] [PATCH] easyhacks: remove bogus comments

2011-01-31 Thread Cedric Bosdonnat
Hello Suguru, Many thanks for taking my last comment in consideration. Your patch was nice: I simply removed some more instances of "OD" and pushed it. Keep providing patches like this one :) On Sat, 2011-01-29 at 18:20 +0900, Suguru Hirahara wrote: > Hello, > > some comments related with revisi

Re: [Libreoffice] [PATCH] added translation to description.xml

2011-01-31 Thread Cedric Bosdonnat
On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: > added Russian translation to dictionaries/ru_RU/description.xml Well I forgot to ask you... do you agree to push the patch under LGPLv3+ and MPL? -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration develope

Re: [Libreoffice] [PATCH] Easy hacks: removed double line spacing

2011-01-31 Thread Cedric Bosdonnat
Hello Christina, On Sun, 2011-01-30 at 22:29 +0100, Christina Roßmanith wrote: > lines already striked out in the list. Many thanks for your patch. I just pushed it... I suppose you provide it under LGPLv3+ and MPL as I already saw it in another of your emails, is that right? Regards, -- Cédric

Re: [Libreoffice] [Fwd: [PATCH] Easy hacks: remove double line spacing]

2011-01-31 Thread Cedric Bosdonnat
Hello Guillaume, On Sun, 2011-01-30 at 22:51 +0100, Guillaume wrote: > Can someone explain me why my patch has not been pushed ? The simple reason is that most of us were on week-end... > If I were wrong somewhere, I don't want to make the same mistake twice. > It was my first (really easy/small

Re: [Libreoffice] [PATCH] GTK: toolbar separator

2011-01-31 Thread Cedric Bosdonnat
Hi Lucas, Many thanks for your patch, I just have pushed it. On Sat, 2011-01-29 at 21:28 +0100, xapantu wrote: > Hi, > > Here is a patch to use gtk vseparator instead of native ones in the > toolbar, which are just a black line, and doesn't fit with gtk separator > which can have nice gradients,

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/core/access

2011-01-31 Thread Cedric Bosdonnat
On Sun, 2011-01-30 at 04:22 +0900, Suguru Hirahara wrote: > under LGPLv3+ / MPL. Pushed, but please pay attention to: * Avoid breaking the build with ill-formed comments * Provide several patches changing twice the same things in the same files but not 100% exactly in the same way. I had to ma

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/filter

2011-01-31 Thread Cedric Bosdonnat
On Sun, 2011-01-30 at 01:54 +0900, Suguru Hirahara wrote: > Hello, > here's another patch. > This one is also related with bogus comments. Pushed as well -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr __

Re: [Libreoffice] [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx

2011-01-31 Thread Cedric Bosdonnat
Hi Thomas, On Mon, 2011-01-31 at 09:58 +0100, Thomas Arnhold wrote: > does anyone need this macros? I removed them completely. I just pushed your patch here: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=b214264fbb55b1f33e8a50b42113137178da0125 If anyone complains about the remova

Re: [Libreoffice] (no subject)

2011-01-31 Thread Cedric Bosdonnat
Hello Antoine, Thanks for your patch. I just pushed it. Feel free to provide other patches like this one. BTW, you didn't mention anything, I supposed you were agreeing to provide the patch under LGPLv3+ / MPL... is that OK? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundat

Re: [Libreoffice] [PATCH] [PUSHED] Remove unused files

2011-01-31 Thread Cedric Bosdonnat
Hello Kurosawa-san, On Mon, 2011-01-31 at 16:53 +0900, KUROSAWA, Takeshi wrote: > Hi, > > I found some unused files in libs-gui/sv-tools/ and filters/binfilter/. > Actually they are not compiled. > Attached patches remove them. Many thanks for your patches. I just pushed them. I compiled them an

Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener

2011-01-31 Thread Cedric Bosdonnat
Hello Soeren and Thies, On Sat, 2011-01-29 at 18:04 +0100, Soeren Moeller wrote: > Now we have replaced tools/list with std::list in ScAddInListener, > here we used a list, as there is adding, removing, and searching on > this list, and no clear way to sort the elements. The patch comes in > three

[Libreoffice] [REVIEW] Fix for bug n#664516

2011-02-01 Thread Cedric Bosdonnat
Hi all, I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it? http://cgit.freedesktop.

Re: [Libreoffice] [REVIEWED] Fix for bug n#664516

2011-02-01 Thread Cedric Bosdonnat
Hello Michael, On Tue, 2011-02-01 at 13:57 +, Michael Meeks wrote: > On Tue, 2011-02-01 at 14:27 +0100, Cedric Bosdonnat wrote: > > I have just fixed the bug n#664516, around the new writer table formulas > > and would like to integrate it in 3.3 branch. This bug o

Re: [Libreoffice] Remove old Word 6.0/95 "save as" support

2011-02-02 Thread Cedric Bosdonnat
Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: > I'd like to get opinions (and preferably consensus) on removing old > Microsoft formats "save as" support, specifically: > Word 6.0 > Word 95 > Excel 5.0 > Excel 95 I would be all for it too... it's even an easy hack you could ac

Re: [Libreoffice] HTML formatting in comments?

2011-02-03 Thread Cedric Bosdonnat
You need to pay attention to the internal javadoc-like tool used for IDL files and some hxx files as well. This has some special tags... all the doc is here: http://api.openoffice.org/docs/DevelopersGuide/Appendix/IDLDocumentationGuide/IDLDocumentationGuide.xhtml and are valid for this one. I w

Re: [Libreoffice] Usability issue: no way to rotate an image on a frame

2011-02-03 Thread Cedric Bosdonnat
Hello Joshua, On Fri, 2011-02-04 at 00:58 -0600, Joshua Ismael wrote: > I have to rotate an image > but there's no way to do it, > at least not an obvious way: You probably mean you can't do it in Writer, right? In that case this is a known and old issue... thought it's no easy thing to hack. Re

Re: [Libreoffice] HTML formatting in comments?

2011-02-03 Thread Cedric Bosdonnat
Hi Thomas, On Thu, 2011-02-03 at 18:07 +0100, Thomas Arnhold wrote: > Ok, didn't know, that idl files get handled another way. How do we > clearly identify IDL and related files, which shouldn't be handled by > doxygen?! Are these only files with the idl extension? And is the > doxygen documentati

[Libreoffice] [REVIEW] fix for fontwork toolbar

2011-02-04 Thread Cedric Bosdonnat
Hi all, Could anyone review the fix for this quite annoying bug? https://bugs.freedesktop.org/show_bug.cgi?id=32872 The fix has been pushed to master as commit: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=05ef821abdff1ec4712cd4b054a21e4180b2298f It would be nice to have that in

[Libreoffice] [REVIEW] ugly diplay of toolbar menus in fontwork toolbar

2011-02-07 Thread Cedric Bosdonnat
Hello people, Since I fixed the toolbar menus on the fontwork toolbar, I saw that one of them as pretty badly shaped. The spacing menu was writing the text of the items over the controls that were supposed to be displayed on the left of it. Could anyone review this commit, sign it off and cherry-

[Libreoffice] [REVIEW] Fix for 35805 to cherry-pick in 3.4

2011-05-11 Thread Cedric Bosdonnat
Hello all, Could anyone review and cherry-pick this commit in 3-4? It fixes fdo#35805. http://cgit.freedesktop.org/libreoffice/writer/commit/?id=3fac8d73027a2d97bf4cb3e8ec0d6d9d69ad3410 Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration develop

[Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4

2011-05-11 Thread Cedric Bosdonnat
Hi all, Attached is a patch fixing the sw table formulas update in 3.4. Could someone review and sign it off? It's a partial revert from http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e The test in the if, was actually setting pNewVal... which w

Re: [Libreoffice] [REVIEWED] fix for #36915 and #36916

2011-05-12 Thread Cedric Bosdonnat
Hi Noel, On Thu, 2011-05-12 at 10:40 +0100, Noel Power wrote: > please see updated patch As told you on IRC, it's ok for me. I just signed it off and pushed it. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr

[Libreoffice] [REVIEW] fix for fdo#36524

2011-05-12 Thread Cedric Bosdonnat
Hi all, Could anyone review and sign-off this patch in 3.4 branch? The change from sal_True to sal_False was pretty complex to find out, but I just reverted it to the value it had in 3.3 sources. Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integratio

Re: [Libreoffice] [REVIEWED] Review request: http://pastebin.com/bgVxQKug

2011-05-12 Thread Cedric Bosdonnat
On Thu, 2011-05-12 at 06:17 -0600, Tor Lillqvist wrote: > OK to apply to the branch? Ok for me. Pushed. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOff

Re: [Libreoffice] [REVIEW] fix for fdo#36524

2011-05-13 Thread Cedric Bosdonnat
Hi all, I've just seen that there are cases where that change won't fit the original code. I'll need some more thinking to make it clean or check what it breaks. Don't push it now as it may introduce other bugs (potentially blockers) On Thu, 2011-05-12 at 17:14 +0200, Ce

[Libreoffice] [REVIEW] Fix for fdo#36826

2011-05-13 Thread Cedric Bosdonnat
Hi all, Could you review and signoff the attached patches for inclusion in 3.4 branch? The first patch is simply some cleanup to make sw build with debug symbols. The second is the fix for https://bugs.freedesktop.org/show_bug.cgi?id=36826 (paragraph borders hidden by paragraph background) Thank

Re: [Libreoffice] Fwd: LibreOffice 3.4.0 ,DEV300m103 (Build:4)

2011-05-13 Thread Cedric Bosdonnat
Hi Italo, without any more info from that guy I'ld say that this looks like a blocker that has been recently fixed and will be in the next version. On Fri, 2011-05-13 at 15:55 +0200, Italo Vignoli wrote: > I know this is not the right place for bugs, but I am definitely not the > right person to

Re: [Libreoffice] [LibreOffice][GSoC 2011][svgexport] weekly report

2011-05-16 Thread Cedric Bosdonnat
Hi Marco, On Mon, 2011-05-16 at 09:02 +0200, Marco wrote: > I'm still very busy with studies, indeed, anyway I started practicing > LibreOffice debugging with DDD, (thanks to moggi for his support on IRC) > I'd like to be able to debug it under Eclipse CDT, so I'm going to > investigate this possi

Re: [Libreoffice] [PUSHED] Fix for bug 33781 => No anti-aliasing in metafiles when anchor is "as char"

2011-05-16 Thread Cedric Bosdonnat
Hi Roland, Sorry for the delay reviewing your patch, but indeed it's harmless and fixing that bug. I've just signed it off and pushed it to 3.4 branch. Many thanks for your patch and keep providing good ones like this ;) Regards, On Sun, 2011-05-15 at 22:59 +0200, Roland Baudin wrote: > OK, nic

Re: [Libreoffice] [REVIEWED] fix for fdo#36951

2011-05-16 Thread Cedric Bosdonnat
Hi Andras, On Fri, 2011-05-13 at 10:32 +0200, Andras Timar wrote: > Could anyone review and sign-off this patch in 3.4 branch? It fixes the > layout of password dialog (e.g. File - Properties - Security, File - > Export to PDF - Security). It is not critical but it looks ugly. A harmless patch fi

[Libreoffice] [REVIEW] fix for fdo#37277

2011-05-17 Thread Cedric Bosdonnat
Hi all, could someone review, sign-off and push to 3.4 branch this patch fixing fdo#37277? Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From 63d51247bff1fdb6eebbc19983b881d8b5af8728 Mon Sep 17 00:

Re: [Libreoffice] .doc and .docx support in master

2011-05-18 Thread Cedric Bosdonnat
Hi Jon, On Tue, 2011-05-17 at 18:19 +0200, Jonathan Aquilina wrote: > I am trying to test out the master branch, and im noticing a major issue > with the .docx as well as the .doc import filters. > > .docx im guessing is still not implemented, and if that is the case what > stage is it at befor

[Libreoffice] [REVIEW] Fix for fdo#36688, undisplayed borders in calc

2011-05-18 Thread Cedric Bosdonnat
Hello all, Here is a fix for a regression (neither crash nor anything seriously damaging the program). It's just displaying some missing borders in calc. Could you review, sign-off and push to the 3.4.0 branch (or 3.4 if more appropriate)? Thanks, -- Cédric Bosdonnat LibreOffice hacker http://

Re: [Libreoffice] [REVIEW] fix for fod#36552

2011-05-18 Thread Cedric Bosdonnat
Hi Noel, The patch looks good to me. Still two other reviews to get it in 3.4.0 On Wed, 2011-05-18 at 16:27 +0100, Noel Power wrote: > Hi > I have a fix for https://bugs.freedesktop.org/show_bug.cgi?id=36552 > I'd like to get it into the 3.4 branch if > possiblehttp://cgit.freedesktop.org/libreof

[Libreoffice] [REVIEW] fix for fdo#34997

2011-05-18 Thread Cedric Bosdonnat
Hi all, Could you review the attached patch (sign it off, and so on)? It fixes a crash when reading some malformed ODT files. It would be great to have that one in 3.4. Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.b

Re: [Libreoffice] 3-4 build problem: sw module: ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’

2011-05-19 Thread Cedric Bosdonnat
Hi KAMI, On Thu, 2011-05-19 at 05:57 +0200, KAMI911 KAMI911 wrote: > /home/libo64/bootstrap/sw/source/core/view/viewsh.cxx:161: error: > ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’ > make: *** > [/home/libo64/bootstrap/solver/340/unxlngx6.pro/workdir/CxxObject/sw/source/core/v

[Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Cedric Bosdonnat
Hi all, could you please review / push this patch to 3.4 and 3.4.0? It's a simple fix that would save quite some crashes. Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From dad2c6ac2dba139364b93cb7

Re: [Libreoffice] Testing writerfilter import

2011-05-19 Thread Cedric Bosdonnat
Hi Miklos, On Thu, 2011-05-19 at 12:26 +0200, Miklos Vajna wrote: > Preparing for the GSoC project, I wanted to decide what is an easy way > to test an import filter. Given that the new RTF filter will be in > writerfilter, testing docx import is a good example, I guess. Sure, though we have no u

Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239

2011-05-19 Thread Cedric Bosdonnat
Hi Michael, On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: > Hi Cedric, > > On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: > > could you please review / push this patch to 3.4 and 3.4.0? It's a > > simple fix that would save quite some crashes. &

[Libreoffice] [REVIEW] fix for fdo#36615

2011-05-19 Thread Cedric Bosdonnat
Hi all, I just fixed another blocker for 3.4. Can you please review and push it? Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From 6fa0f51c89a18317be5b7181f3c2c68d46784a65 Mon Sep 17 00:00:00 2001

Re: [Libreoffice] [REVIEW] fix for fdo#36615

2011-05-20 Thread Cedric Bosdonnat
On Fri, 2011-05-20 at 00:47 -0600, Tor Lillqvist wrote: > > that list is a Gotcha it needs a comment at the end of it on master saying: > > "This list has > > to be sorted correctly !". > > Why not let the bleeping computer do the sorting the first time the list is > used? Proper division of lab

Re: [Libreoffice] minutes of tech. steering call ...

2011-05-20 Thread Cedric Bosdonnat
Hi all, Sorry, I couldn't join yesterday. I'm just wondering where the reviewboard action item went? is that a dropped idea or does it still deserves some action? On Thu, 2011-05-19 at 18:13 +0100, Michael Meeks wrote: > Attending: > Thorsten, Andras, Kendy, Norbert, Christian, Petr, >

Re: [Libreoffice] [REVIEWED] trivial PPTX import crash fix

2011-05-20 Thread Cedric Bosdonnat
On Thu, 2011-05-19 at 16:54 +0100, Michael Meeks wrote: > To avoid a NULL pointer de-reference, don't de-reference a null > pointer :-) I'd like to get this into 3.4.0 Ok for me too. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http

Re: [Libreoffice] [REVIEW] Compatibility option for old size of small caps text effect

2011-05-20 Thread Cedric Bosdonnat
On Fri, 2011-05-20 at 15:05 +0200, Lubos Lunak wrote: > Hello, > > I would like to backport > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16 > > to 3-4 and even 3-4-0. As the commit log says, we have changed the size of > small capitals font

Re: [Libreoffice] http://openoffice.org/bugzilla/show_bug.cgi?id=84159

2011-05-20 Thread Cedric Bosdonnat
On Fri, 2011-05-20 at 09:22 -0400, Marc Paré wrote: > I was just on the usenet openoffice group and this bug was mentioned as > being a problem with people working on larger files. As this seems to > have been fixed in the upcoming 3.4 version of OpenOffice I was > wondering if it was integrated

Re: [Libreoffice] http://openoffice.org/bugzilla/show_bug.cgi?id=84159

2011-05-20 Thread Cedric Bosdonnat
On Fri, 2011-05-20 at 15:38 +0200, Cedric Bosdonnat wrote: > On Fri, 2011-05-20 at 09:22 -0400, Marc Paré wrote: > > I was just on the usenet openoffice group and this bug was mentioned as > > being a problem with people working on larger files. As this seems to > > h

[Libreoffice] [REVIEW] Fix for fdo#37387

2011-05-20 Thread Cedric Bosdonnat
Hi all, I just fixed some UI problem with CTL. Could you please review the fix, sign it off and push it? The problem that may appear here is that I needed to reduce the available space for some strings. I'm not sure it fits for all locales thought it should be OK. Thanks, -- Cédric Bosdonnat L

[Libreoffice] [REVIEW] fix for fdo#37390

2011-05-20 Thread Cedric Bosdonnat
Hi all, Some people complained about LO not producing valid ODF files. Here is a hack that silences the validator for problems mentioned by fdo#37390 (the missing manifest:version was fixed quite a while ago). Drawback of the change: people actually using the grid may have loose that setting when

Re: [Libreoffice] Export hyperlinks to .doc

2011-05-23 Thread Cedric Bosdonnat
Hello Knut, Glad to see you around ;) On Fri, 2011-05-20 at 13:48 +0200, Knut Olav Bøhmer wrote: > Exporting hyperlinks to .doc is done wrong in LibreOffice Writer. > There is a flag (hlstmfIsAbsolute) that is set to 1. It should be 0, > because all links are exported relative. > > > > > Bef

Re: [Libreoffice] Unifying dev-install

2011-05-23 Thread Cedric Bosdonnat
On Sun, 2011-05-22 at 16:44 +0200, Bjoern Michaelsen wrote: > The attached patch makes "dev-install" use smoketest to create an > installation. This has another advantage: Sometimes people seem to > "forget" *cough* *cough* to run smoketest(*), and this will > conveniently take care of that for the

[Libreoffice] [REVIEW] Complete fix for fdo#32684

2011-05-23 Thread Cedric Bosdonnat
Hi all, That bug was badly fixed (by me) quite some times ago. Here is a correct fix (why did I add that code at all ?). Could you review it and push it in 3.4 and 3.4.0? More cleanup is needed but it'll end up in master: some options aren't used at all in that area. Thanks, -- Cédric Bosdonna

Re: [Libreoffice] [REVIEW] Complete fix for fdo#32684

2011-05-23 Thread Cedric Bosdonnat
Hi Michael, On Mon, 2011-05-23 at 12:20 +0100, Michael Meeks wrote: > On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote: > > That bug was badly fixed (by me) quite some times ago. Here is a > > correct fix (why did I add that code at all ?). Could you review it > > a

Re: [Libreoffice] about bug fdo 36519 ("writer8" instead of "ODF Text" in options UI)

2011-05-23 Thread Cedric Bosdonnat
Hi Jean-Baptiste, On Mon, 2011-05-23 at 07:30 +0200, Jean-Baptiste Faure wrote: > No suggestion to help me to fix this bug ? > I think this bug is a bad communication about the LibO's involment for ODF. Sure, read below: > Le 15/05/2011 11:31, Jean-Baptiste Faure a écrit : > > Hi, > > > > I try

Re: [Libreoffice] Writer, errors in debug mode

2011-05-23 Thread Cedric Bosdonnat
On Sun, 2011-05-22 at 22:50 +0200, Julien Nabet wrote: > Error: XHierarchicalNameAccess: Other/IsSquaredPageModeOther/ApplyCharUnit > /org.openoffice.Office.Writer/Layout/Other/IsSquaredPageModeOther/ApplyCharUnit > > From File > /home/maryline/compile-libreoffice/libo/unotools/source/config/co

Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Cedric Bosdonnat
On Mon, 2011-05-23 at 04:21 -0600, Tor Lillqvist wrote: > >>> On 2011-05-23 at 00:50, wrote: > > The problem here is that you are not allowed to access any element as long > > as the ptr_vector is empty. > > > I think we should include this patch in 3-4-0. > > Another crash introduced by a "Remo

Re: [Libreoffice] [REVIEW] fix for fdo#37390

2011-05-23 Thread Cedric Bosdonnat
Hi all, Don't apply that one... I had remorse all the week-end for all the non-conforming documents that may loose that property. I'll hack a better patch to still read the old property. On Fri, 2011-05-20 at 17:33 +0200, Cedric Bosdonnat wrote: > Hi all, > > Some people comp

Re: [Libreoffice] [REVIEW] fix for fdo#37390

2011-05-23 Thread Cedric Bosdonnat
Hi all, On Mon, 2011-05-23 at 14:06 +0200, Cedric Bosdonnat wrote: > Don't apply that one... I had remorse all the week-end for all the > non-conforming documents that may loose that property. I'll hack a > better patch to still read the old property. Here is an augmented pat

Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

2011-05-25 Thread Cedric Bosdonnat
Hello Markus, On Tue, 2011-05-24 at 21:35 +0200, Markus Mohrhard wrote: > here is a short patch that sets all specified borders during parsing > instead of only one border. The problem was that nBorderTyp was set > for every border with the correct value but SetBorderLine was only > called once af

[Libreoffice] [REVIEW] fix for i#115297

2011-05-25 Thread Cedric Bosdonnat
Hi all, Attached is a patch fixing correctly the relative flag for hyperlinks when exporting ww8 files. Sorry Knut, but I didn't integrate any of your patches as they were not fixing the bug properly (see troubles with http, ftp or other URLs like that) Can anyone review the patch, sign it off an

Re: [Libreoffice] [GSoc] Progress report - Visio import filter

2011-05-26 Thread Cedric Bosdonnat
Hi Fridrich, Eilidh, On Thu, 2011-05-26 at 09:39 +0200, Fridrich Strba wrote: > In our private conversation you asked for some guidance about how to > structure the library. Here are my basic thoughts (that are again my > thoughts that come from having contributed to several libraries, but > they

Re: [Libreoffice] about fonts embedding error

2011-05-26 Thread Cedric Bosdonnat
Hi Edmund, On Thu, 2011-05-26 at 10:54 +0300, Edmund Laugasson wrote: > I would like to ask - is there any bug with fonts embedding? I tried to > embed all fonts but they didn't - still were there misunderstandable > signs... Well, the dev list is not a good place to raise bugs... > I found th

Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

2011-05-27 Thread Cedric Bosdonnat
Hi Kendy, On Fri, 2011-05-27 at 07:43 +0200, Jan Holesovsky wrote: > > here is a short patch that sets all specified borders during parsing > > instead of only one border. The problem was that nBorderTyp was set > > for every border with the correct value but SetBorderLine was only > > called once

Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

2011-05-27 Thread Cedric Bosdonnat
Hello Markus, On Fri, 2011-05-27 at 14:02 +0200, Markus Mohrhard wrote: > yes there might still be some problems, I only tried to fix that > during pasting to calc all borders are drawn. I'm not familiar with > the RTF spec and the old code(before Cedric refactored it) was really > ugly and even u

Re: [Libreoffice] about bug fdo 36519 ("writer8" instead of "ODF Text" in options UI)

2011-05-30 Thread Cedric Bosdonnat
On Sun, 2011-05-29 at 11:40 +0200, Jean-Baptiste Faure wrote: > It works if I add a break statement when UIName is found : > > for(int nProp = 0; nProp < rProperties.getLength(); nProp++) > { > if(!pProperties[nProp].Name.compareToAscii("UIName")) > { > pPropert

  1   2   3   4   5   >