Hi all,
Attached is a patch fixing the sw table formulas update in 3.4. Could
someone review and sign it off? It's a partial revert from
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e
The test in the if, was actually setting pNewVal... which was never set
and causing troubles in some (potentially loads of) cases.
Thanks,
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
>From 8ee0b2582d21feaa4d31c1f24d392992fd7fdec9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= <cedric.bosdonnat....@free.fr>
Date: Wed, 11 May 2011 17:31:00 +0200
Subject: [PATCH] fdo#36667: Fixed update of table formulas, missing extraction of pNewVal
---
sw/source/core/table/swtable.cxx | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index 0c9e3dd..39c8566 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -2270,6 +2270,8 @@ void SwTableBoxFmt::Modify( const SfxPoolItem* pOld, const SfxPoolItem* pNew )
GetChgSet()->Get( RES_BOXATR_FORMAT )).GetValue();
rSet.GetItemState( RES_BOXATR_FORMULA, sal_False,
(const SfxPoolItem**)&pNewFml );
+ rSet.GetItemState( RES_BOXATR_VALUE, sal_False,
+ (const SfxPoolItem**)&pNewVal );
}
break;
--
1.7.3.4
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
