Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

30.01.2012 13:07, Stefan Knorr (Astron) пишет: the idea sounds good, ... patch is simple, and the details seem to be correct now. Thus, I've taken the liberty to replace "can" by "may" and then push to master. just added ':' to the sequence of characters http://cgit.freedesktop.org/libreoffice/

[Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

Hi, please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. Christina >From ac8d464245852f701478039f89ae876d6584fb88 Mon Sep 17 00:00:00 2001 From: Christina Rossmanith Date: Tue, 31 Jan 2012 10:07:19 +0100 Subject: [

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #157 from Rainer Bielefeld 2012-01-31 01:16:45 PST --- + "Bug 45409 - FILEOPEN particular .doc: Table of contents broken, internal reference information visible". Makes 3.5 useless for editing WORD documents, dataloss, saved with 3.5

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45409 -- Configure bugmail: https://bugs.

Re: [Libreoffice] [REVIEW] [3.5.0] Some simple polish for named ranges dialogue

On 30/01/12 19:21, Petr Mladek wrote: Stefan Knorr (Astron) píše v Po 30. 01. 2012 v 09:45 +0100: Hi, I know this is extremely late for a simple polish fix, but please consider http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cb0a4ab4f11dc015be1696c7c7751802171915 as well as http://cgi

Re: [Libreoffice] [PATCH] Remove unused code

Hi Elton First thanks for submitting your patch, it's appreciated however could I ask if you could please repost your patch as an attachment [1] ? patch content inline in a mail message just does't work as the mail client breaks the lines in such a way as the patch program no longer understand

Re: [Libreoffice] [PUSHED^2] Re: [REVIEWED] Fix reading .doc comments (fdo#45255)

Michael Stahl píše v Po 30. 01. 2012 v 22:42 +0100: > On 30/01/12 21:19, Caolán McNamara wrote: > > On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote: > >>Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we > >> had busted comment interop with .docx in 3.4 (so people us

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45409, which changed state. Bug 45409 Summary: FILEOPEN particular .doc: Table of contents broken, internal reference information visible https://bugs.freedesktop.org/show_bug.cgi?id=45409 What|Old Value

[Libreoffice] Simplified C++ configuration access

Hi all, configmgr is a dreaded beast. Its UNO API is notorious for re-using each and every generic UNO interface type that exists, in a way that makes it hard to see the forest for the trees. To add insult to injury, people always thought it a good idea to wrap the API in C++ "helper classe

Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

On 31/01/12 09:11, Chr. Rossmanith wrote: Hi, please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated can't afaics be reached and nSteps wo

[Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hi, ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build environment I couldn't test whether it really builds after removing the method. But I don't see why it shouldn't... Christina >From 053a691750697916fd5cb176bec886b6da13b630 Mon Sep 17 00:00:00 2001 From: Christina Ro

Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

Am 31.01.2012 11:43, schrieb Noel Power: On 31/01/12 09:11, Chr. Rossmanith wrote: please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated c

Re: [Libreoffice] [PATCH] Remove unused code

Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, sponsor of mirror.layerjet.com Language Maintainer of ReactOS Open Source operat

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hi Christina On 31/01/12 10:43, Chr. Rossmanith wrote: Hi, ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build environment I couldn't test whether it really builds after removing the method. But I don't see why it shouldn't... Christina I'd say commit it, can't see this

Re: [Libreoffice] [PUSHED][PATCH] Removed unused ImplSalLogFontToFontA()

31.01.2012 15:15, Noel Power пишет: Hi Christina On 31/01/12 10:43, Chr. Rossmanith wrote: Hi, ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build environment I couldn't test whether it really builds after removing the method. But I don't see why it shouldn't... Christina

Re: [Libreoffice] [PUSHED] partial patch for fdo#44551 libvisio: arrow head shapes not imported properly

Hello, Bruno On 31/01/12 00:35, Bruno Girin wrote: Please find attached a partial patch to import line marker shapes from Visio files. I would appreciate a review to confirm whether I am on the right path or whether I should do something different. Yes, currently this is the best approach to f

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

On 30/01/12 17:16, Cedric Bosdonnat wrote: Hi Michael, On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: On 26/01/12 19:30, Michael Stahl wrote: On 26/01/12 16:21, Cedric Bosdonnat wrote: Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.fre

Re: [Libreoffice] Simplified C++ configuration access

Hi Stephan, On Tue, 2012-01-31 at 11:31 +0100, Stephan Bergmann wrote: > To add insult to injury, people always thought it a good idea to > wrap the API in C++ "helper classes" that are themselves baroque > and obscure :-) > So I finally set out to simplify this (on the master branch to

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

On Mon, 2012-01-30 at 20:40 +0100, Albert Thuswaldner wrote: > Just a thought: should we push this to the 3.5 branch? This is a small > polish of the user experience and it might be good to have it in a > release soon Well - hopefully six months away is not -so- far - but I appreciate you

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 30/01/12 22:53, Andreas Schierl wrote: Hi, I found out that bugs https://bugs.freedesktop.org/show_bug.cgi?id=34611 https://bugs.freedesktop.org/show_bug.cgi?id=45376 are caused by a missing call to ClrContourCache( pObj ); in /sw/source/core/layout/pagechg.cxx: void lcl_Move

Re: [Libreoffice] Storage of user's configuration

Hi Stephan, On Tue, 2012-01-31 at 08:28 +0100, Stephan Bergmann wrote: > Martin, for this to keep working please add a nillable="false" attribute > to your new property in Common.xcs, see ... > "Fixed cppheader.xsl nillable treatment." (In addition to adding an > empty default so that the get

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

On Mon, 2012-01-30 at 16:35 -0500, Kohei Yoshida wrote: > increases its reference counter by one. The problem is, this counter is > unsigned 16-bit integer, and as soon as it goes above 65535 it rolls > back to zero, and eventually the token instance gets deleted > prematurely. Wow - tha

Re: [Libreoffice] [PUSHED] [3.5.0] Some simple polish for named ranges dialogue

2012/1/31 Noel Power : > On 30/01/12 19:21, Petr Mladek wrote: >> >> Stefan Knorr (Astron) píše v Po 30. 01. 2012 v 09:45 +0100: >>> >>> Hi, >>> >>> I know this is extremely late for a simple polish fix, but please >>> consider >>> >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cb0a4

Re: [Libreoffice] [PATCH] Remove unused code

On 31/01/12 11:05, Elton Chung wrote: Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. ok, pushed, thank, ps. next time don't chop off the header of the formatted patch 'cause '

Re: [Libreoffice] Storage of user's configuration

On 01/31/2012 12:37 PM, Michael Meeks wrote: Incidentally - do we expect that all properties will end up with a nillable="false" attribute on them in the end ? :-) No. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org htt

[Libreoffice] [PATCH] unusedcode.easy: Removed unused code (basegfx)

--- basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx |3 - basegfx/inc/basegfx/polygon/b2dpolygon.hxx | 20 basegfx/inc/basegfx/polygon/b3dpolygon.hxx |3 - basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx |3 - basegfx/inc/basegfx/range/b1drange.hxx |

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

Noel Power wrote: > I cc some writer experts who may suggest some > alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour wrapped drawing objects). > Can you confirm you

[Libreoffice] Fatal error building Windows release (Cygwin)

I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in wiki.documentfoundation.org/Development/Windows_Build_Dependencies but I’m unable to build the release. Full logs (including getting the source) at pastebin.com/u/walterLO Release libreoffice 3-5

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 12:23 PM, Michael Meeks wrote: Sounds like a great cleanup, I vaguely advertised it in my blog. Would it be possible to have a simple "convert just one-key" patch to some old code so newbies can get their cookie cutters correctly calibrated :-)

Re: [Libreoffice] Fatal error building Windows release (Cygwin)

looks like it's failing in the xmlreader module (part6 of your pastebin logs), but I don't know why. try doing this: source ./Env.Host.sh cd xmlreader build On 2012-01-31 14:59, walter wrote: I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in w

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > cc'ing Caolán as he might be interested because it doesn't turn up in > the unused.easy Its windows only code, and callcatcher can only see what gets compiled as its just a compiler wrapper and I run it under Linux. C. __

[Libreoffice] tracking ODF compliance issues

hi all, i'd like to have some easier way to track bugs related to ODF compliance in the bugzilla. what would be the best way to do this: - a new keyword, say "odf" or "odf_validation" - a tracking bug, that depends on all indidual ODF related bugs the OpenOffice.org issuezilla used a "odf_valida

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

Hi Kohei, On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > I'd like > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > cherry-picked to the 3-5 branch. It is probably too late for change > like this to be in the 3-5-0 branch so

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

Olivier Hallot schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Regina It has been decades since I handled groups, rings, fields, and functions in my french lycée. Now I am confused because it looks like the two terms are swapped between french and english... Regards Olivier In fren

[Libreoffice] R: Fatal error building Windows release (Cygwin)

The problem is Cannot open include file: 'sal/config.h' but this file exists in my 'git/libo/sal/inc/sal' directory !! Regards Walter = (1/1) Building module xmlreade

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi Ivan, On Tuesday, 2012-01-31 12:55:50 +0400, Ivan Timofeev wrote: > just added ':' to the sequence of characters > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a9d8c07ddf054930e1b000cc3c972a3d217d71c Yup, good catch. Technically there's also the limitation that a ' single quote ch

[Libreoffice] master vs. 3.5 regression ... (vcl/python) ...

Hi guys, I just noticed this printing: https://bugs.freedesktop.org/show_bug.cgi?id=45303 from master; looks like a particularly exciting memory corruption regression between python and vcl somewhere. Prolly of my own creation, but I wonder if it rings any bells. Supposedly it is

Re: [Libreoffice] R: Fatal error building Windows release (Cygwin)

yeah, the gbuild code that figures out the INCLUDE path is obviously a little wonky. As this point all I can suggest is doing: cd xmlreader rm -Rf wntmsci12.pro build Sometimes that sorts it out. On 2012-01-31 15:31, walter wrote: The problem is Cannot open include file: 'sal/config.h' bu

Re: [Libreoffice] Simplified C++ configuration access

On Tuesday 31 of January 2012, Stephan Bergmann wrote: > To get a property's value, all that is needed is to call the wrapper > class's static officecfg::Foo::Bar::Baz::Whatever::get member function, > which requires the XComponentContext as argument (use > comphelper::getProcessComponentContext in

[Libreoffice] R: R: Fatal error building Windows release (Cygwin)

A simple question. How can you compile The MASTER Win-x86_7-MinGW without any error ? Which environment is used ? Regards Walter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 30/01/12 13:54, Noel Grandin wrote: Hi Attached patch converts SdCustomShow to use std::vector. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html I hate these remove list etc. type patches as they tend to be tricky and tim

[Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx index 98f2df5..c8b1495 100644 --- a/sd/sou

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

sorry, that should be "converted to std::vector" On 2012-01-31 16:22, Noel Grandin wrote: Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Noel Power píše v Út 31. 01. 2012 v 11:24 +: > On 30/01/12 17:16, Cedric Bosdonnat wrote: > > Hi Michael, > > > > On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote: > >> On 26/01/12 19:30, Michael Stahl wrote: > >>> On 26/01/12 16:21, Cedric Bosdonnat wrote: > Hi all, > > Co

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 31/01/12 12:46, openoff...@schierla.de wrote: Noel Power wrote: I cc some writer experts who may suggest some alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour

Re: [Libreoffice] [PUSHED:3-5-0]]Fix for annoying bug fdo#35669

Updated subject. Petr Mladek píše v Út 31. 01. 2012 v 15:26 +0100: > Looked fine. Worked reasonable => pushed into 3-5-0, see > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > http://cgit.freedesktop.org/libreoffice/core/commit

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35669, which changed state. Bug 35669 Summary: Incorrect cross-references to illustrations and equations in master documents https://bugs.freedesktop.org/show_bug.cgi?id=35669 What|Old Value

[Libreoffice] R: R: Fatal error building Windows release (Cygwin)

The suggestion doesn't solve the problem. Regards Walter >>> cd xmlreader rm -Rf wntmsci12.pro build ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW][3.5][3.5.0?] fix for fdo#44836 (leaking page breaks)

Hi all, I just fixed some remaining leaking page breaks. Could someone review and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? http://cgit.freedesktop.org/libreoffice/core/commit/?id=9babbf346c4d6f76e8b3a243a00e73a173c16ba6 Thanks, -- Cedric _

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Hi Petr, Cedric, all, On 2012-01-31 at 15:26 +0100, Petr Mladek wrote: > Looked fine. Worked reasonable => pushed into 3-5-0, see > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=4632a18dae5e1770aa1da4ac55719a09c1ae461b > http://cgit.freedesktop.org/libreoffice/core/c

Re: [Libreoffice] [REVIEW][3-5] Prevent excessvie references to formula result tokens

Hi Eike, On Tue, 2012-01-31 at 14:27 +0100, Eike Rathke wrote: > Hi Kohei, > > On Monday, 2012-01-30 16:35:46 -0500, Kohei Yoshida wrote: > > > I'd like > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 > > > > cherry-picked to the 3-5 bra

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 11:31 AM, Stephan Bergmann wrote: At the next level, the new unotools/configuration.hxx header provides type-safe C++ wrappers for the various configuration entities on top of the lower level UNO services. For example, the utl::ConfigurationProperty class template can be used to wra

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed somethin

Re: [Libreoffice] Simplified C++ configuration access

On 31/01/12 15:06, Lubos Lunak wrote: > On Tuesday 31 of January 2012, Stephan Bergmann wrote: >> To get a property's value, all that is needed is to call the wrapper >> class's static officecfg::Foo::Bar::Baz::Whatever::get member function, >> which requires the XComponentContext as argument (use

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

On Tue, 2012-01-31 at 00:00 +0100, Regina Henschel wrote: > The term "inverse" is not correct in this context. It should be > "reciprocal" instead. > Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC. I agree Regina, you have unusually good English :-) Any chance

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? On 2012-01-31 17:24, Ivan Timofeev wrote: 31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 34432, which changed state. Bug 34432 Summary: firebird ODBC: LibO crashes on 64 bits https://bugs.freedesktop.org/show_bug.cgi?id=34432 What|Old Value |New Value

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

Rainer Bielefeld bielefeldundbuss.de> writes: > > Hi, > > Concerning the Virus Kazy.7720 Problem: Can you all please contact > support of your Antivirus Program supplier so that they can check and > rework their filters? So we can save much trouble with false alarms > normal users would see

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan ___ Li

Re: [Libreoffice] [REVIEW][3.5][3.5.0?] fix for fdo#44836 (leaking page breaks)

On Tue, 2012-01-31 at 15:48 +0100, Cedric Bosdonnat wrote: > I just fixed some remaining leaking page breaks. Could someone review > and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=9babbf346c4d6f76e8b3a243a00e73a1

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > cc'ing Caolán as he might be interested because it doesn't turn up in > > the unused.easy > > Its windows only code, and callcatcher can only see what gets compiled > as its just a

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

thanks, still working out how this STL stuff hangs together. On 2012-01-31 17:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 16:10 +, Michael Meeks wrote: > On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > > cc'ing Caolán as he might be interested because it doesn't turn up in > > > the unused.easy > > > > Its windows only co

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hello, On 31/01/12 17:10, Michael Meeks wrote: > Interesting (in a world with infinite time); would the mingw > cross-compile be call-catcher-able such that we could get a more precise > and comprehensive list ? Yes, at the level of callcatcher 1.1.3, I added the support for gnu assembler f

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someone else will spot it. Anyway thanks again for

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42543, which changed state. Bug 42543 Summary: Report Designer Wizard missing Label display and editing capability https://bugs.freedesktop.org/show_bug.cgi?id=42543 What|Old Value |New

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

I ran make check at the global level - does that not invoke the individual modules check targets? On 2012-01-31 18:17, Stephan Bergmann wrote: Looks like you missed to run make check: LOG> 1. removeByIndex("1") ...OK LOG> removing a non existent object to get an exception LOG> 2. removeByInde

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomShow->Remove(pPage->GetSdrPage()); <- using

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 05:19 PM, Noel Grandin wrote: I ran make check at the global level - does that not invoke the individual modules check targets? It does. Strange anyway. This failure is consistently reproducible for me and looks suspiciously like the remove problem discussed in this thread...

[Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

Hi, https://bugs.freedesktop.org/show_bug.cgi?id=42543 When you use the report designer, at some stage you get to a page (step 2) which is blank; but when you click there, you can edit the data. The problem is that commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=efc6b840a0423099d

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 03:06 PM, Lubos Lunak wrote: How usual is the case that one does not want to pass comphelper::getProcessComponentContext() to all these functions? Or in other words, why not simply make it the default argument value? Default value indeed looks like a smart move. (In principle,

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On Tuesday 31 of January 2012, Jan Holesovsky wrote: > As a fix, I propose this: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >e9d9979b5b699e6840454 > > Just get rid of the background image; in my opinion, it even looks > better without that, and is the least intr

Re: [Libreoffice] Simplified C++ configuration access

On 01/31/2012 04:25 PM, Michael Stahl wrote: default argument would make officecfg depend on comphelper, so you couldn't use the new headers from comphelper implementation. I just moved configuration.hxx from unotools to comphelper today (to then be able to use the officecfg headers in comphel

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I fixed the english terminology, according to the justifications by Regina. regards Olivier Em 31-01-2012 11:28, Regina Henschel escreveu: > Olivier Hallot schrieb: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi Regina >> >> It has

[Libreoffice] hoping that someone will be able to solve this problem - unable to build windows version using cygwin

I followed all the instructions in wiki.documentfoundation.org/Development/Native_Build and in wiki.documentfoundation.org/Development/Windows_Build_Dependencies but I’m unable to build the release. Full logs (including getting the source) at pastebin.com/u/walterLO Release libreoffice 3-5

[Libreoffice] [PUSHED] Re: [REVIEW] fdo#43965 fix RTF import of page break symbol

On 30/01/12 23:41, Miklos Vajna wrote: > Hi Michael, > > On Mon, Jan 30, 2012 at 10:07:50PM +0100, Michael Stahl > wrote: >>> See >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006 >> >> seems that with this change not only the new LN_PFPageBreak

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On 31/01/12 16:31, Lubos Lunak wrote: On Tuesday 31 of January 2012, Jan Holesovsky wrote: As a fix, I propose this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d e9d9979b5b699e6840454 Just get rid of the background image; in my opinion, it even looks better witho

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

On 31/01/12 17:31, Lubos Lunak wrote: > On Tuesday 31 of January 2012, Jan Holesovsky wrote: >> As a fix, I propose this: >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=03e17a141fbb4e1242d >> e9d9979b5b699e6840454 >> >> Just get rid of the background image; in my opinion, it even loo

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 15:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan nice cat

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:17, Stephan Bergmann wrote: On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someon

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:20, Ivan Timofeev wrote: 31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomSh

Re: [Libreoffice] [PUSHED 3-5] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

Hi julien2412, On Monday, 2012-01-30 12:24:07 -0800, julien2412 wrote: > Commited and pushed on master (commit > 10bfc4df5335c6cd2ae700df7485668d896998b5) > > PS : if it could be useful to push this on 3.5, just tell me :-) Just did so with my sign-off for 3-5, before someone with an incapable

Re: [Libreoffice] [PUSHED][3.5][3.5.0] fix for fdo#44836 (leaking page breaks)

Michael Meeks píše v Út 31. 01. 2012 v 15:56 +: > On Tue, 2012-01-31 at 15:48 +0100, Cedric Bosdonnat wrote: > > I just fixed some remaining leaking page breaks. Could someone review > > and cherry-pick it for 3.5 (and hopefully it's not too late for 3.5.0)? > > > > http://cgit.freedesktop.org

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().e

[Libreoffice] default build verbosity

hi all, a recurring problem with remote debugging newbie build problems is that the default build is silent. i wonder if it would make sense to change that: with default configure invocation, build system outputs the full command to the terminal/log, and there is an explicit configure option to s

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 17:31, Ivan Timofeev wrote: 31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().beg

Re: [Libreoffice] default build verbosity

On Tue, Jan 31, 2012 at 11:43 AM, Michael Stahl wrote: > hi all, > > a recurring problem with remote debugging newbie build problems is that > the default build is silent. > > i wonder if it would make sense to change that: > with default configure invocation, build system outputs the full command

Re: [Libreoffice] [PUSHED][PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:44, Noel Power пишет: hey I've already proved my (non) STL credentials :-) , but.. if we are to believe the old code then mpSdCustomShow->Remove(pPage->GetSdrPage()); would call Container::Remove( void* p ) which would call Container::Remove( Container::GetPos( p ) ) which afaics de

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi, >        Well - hopefully six months away is not -so- far - but I appreciate > your pain. Of course - in theory with triple review features can get > into the -3-5 branch, but string changes are less welcome I suspect. > Well, for me it is not that important. I just wanted to make sure before

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi, > However something I noticed is that there are still some problems with > entering the 'Prefix name" in the options, firstly the input box seems to be > overwritten by the label ( part of the input/edit field for the prefix is > missing until you type ) Hmm, strange, I haven't notice that mys

[Libreoffice] [PATCH] Remove unused code

This patch removes unused code as listed in unusedcode.easy From 4eaa8adb17c0334f08c83509644b45553254376e Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Tue, 31 Jan 2012 19:59:31 +0100 Subject: [PATCH] Remove unused code. --- chart2/source/view/axes/Tickmarks_Equidistant.cxx | 27 -

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Hi Ivan, On Tuesday, 2012-01-31 21:31:11 +0400, Ivan Timofeev wrote: > >should remove the first occurrence, care to fix ? > > so the exact equivalent of > > mpSdCustomShow->Remove(pPage->GetSdrPage()) > > will be: > > SdCustomShow::PageVec::iterator it = std::find( > mpSdCustomShow->Pages

Re: [Libreoffice] tracking ODF compliance issues

Michael Stahl píše v Út 31. 01. 2012 v 14:26 +0100: > hi all, > > i'd like to have some easier way to track bugs related to ODF compliance > in the bugzilla. > > what would be the best way to do this: > - a new keyword, say "odf" or "odf_validation" > - a tracking bug, that depends on all indidua

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

Hi Kohei, On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > Well, for expediting the process (since the release of 3.5.0 is > nearing), could you take this over? Sounds like you know exactly what > needs to get done, so it's probably better than me trying to figure this > out on my o

Re: [Libreoffice] [PUSHED] partial patch for fdo#44551 libvisio: arrow head shapes not imported properly

On 31/01/12 11:22, Fridrich Strba wrote: Hello, Bruno On 31/01/12 00:35, Bruno Girin wrote: Please find attached a partial patch to import line marker shapes from Visio files. I would appreciate a review to confirm whether I am on the right path or whether I should do something different. Yes

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 31/01/12 18:35, Albert Thuswaldner wrote: Additionally you still can get the prefix name to > be blank ( or at least I managed to do that ) by attempting to change the > name by delete, when all the name is deleted you get a message saying the > sheet prefix is illegal ( actually I find tha

Re: [Libreoffice] [REVIEW][3-5][3-5-0][3-4] Prevent excessvie references to formula result tokens

On Tue, 2012-01-31 at 20:54 +0100, Eike Rathke wrote: > Hi Kohei, > > On Tuesday, 2012-01-31 09:54:03 -0500, Kohei Yoshida wrote: > > > Well, for expediting the process (since the release of 3.5.0 is > > nearing), could you take this over? Sounds like you know exactly what > > needs to get done,

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On Tue, 2012-01-31 at 20:07 +, Noel Power wrote: > On 31/01/12 18:35, Albert Thuswaldner wrote: > >> Additionally you still can get the prefix name to > >> > be blank ( or at least I managed to do that ) by attempting to change > >> > the > >> > name by delete, when all the name is deleted y

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi Albert, On Tuesday, 2012-01-31 19:35:54 +0100, Albert Thuswaldner wrote: > > However something I noticed is that there are still some problems with > > entering the 'Prefix name" in the options, firstly the input box seems to be > > overwritten by the label ( part of the input/edit field for t

[Libreoffice] [PUSHD][PATCH] Remove unused code

On Tue, 2012-01-31 at 20:03 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

  1   2   >