31.01.2012 21:44, Noel Power пишет:
hey I've already proved my (non) STL credentials :-) , but.. if we are
to believe the old code then
mpSdCustomShow->Remove(pPage->GetSdrPage()); would call
Container::Remove( void* p ) which would call Container::Remove(
Container::GetPos( p ) ) which afaics deletes the first match :-) and
that's what your patch seems to do, don't know if there is a briefer way
to specify that but to me what you have looks fine
Ok. I'm not a STL expert, too.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2e17f8f6b6724d7e56d6583d79434372f6221bd
Marking as pushed, thanks a lot Noel! :)
Someone with more shiny eyes & more strong STL/Container knowledge may
find another gotchas...
Regards,
Ivan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
