On Mon, 2012-01-30 at 16:35 -0500, Kohei Yoshida wrote:
> increases its reference counter by one. The problem is, this counter is
> unsigned 16-bit integer, and as soon as it goes above 65535 it rolls
> back to zero, and eventually the token instance gets deleted
> prematurely.
Wow - that is annoying :-)
> As an aside, although it's not necessary for this fix, on master we
> should probably use unsigned 32-bit integer to store reference counter
> for this just to future-proof ourselves. 16-bit integer seems a bit too
> small for this purpose.
Right - although, of course what we really want is the sexy region
based re-design, so that we don't hit the next limit: 16k cols x 1m rows
is > 4G items too ;-) so ... clearly we need to share a lot more in such
cases.
Interesting bug though :-)
Thanks,
Michael
--
michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
