Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-02-06 Thread Stefan Knorr (Astron)
Hi, On 6 February 2012 20:49, Cor Nouws wrote: > Fine (for me) :-) Guess so, then. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-02-06 Thread Cor Nouws
Jan Holesovsky wrote (06-02-12 16:31) I've just pushed a change that makes it 2^(1/6) - ie. 6 steps to get double / half zoom: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4db617efd924ad7ff4ce6988771ad36612c329ec The values look like this: Zoom out: 100, 110, 125, 140, 160, 180, 20

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-02-06 Thread Jan Holesovsky
Hi Astron, Drew, Cor, Stefan Knorr (Astron) píše v Čt 26. 01. 2012 v 14:16 +0100: > I just checked, and must say that I can only second Cor and Drew in > that it is too quick now. Could we go back to 1.1 or maybe > 2^(1/8)=1.0905 (that should deliver a similar effect as 2^(1/4), no? – > I am bad

[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

2012-01-30 Thread Michael Stahl
On 30/01/12 15:43, Lionel Elie Mamane wrote: > I attach here the "less invasive" variant originally meant for > libreoffice-3-5. > > However, if people are happy with cherry-picking the (more invasive) > master commit, by all means, cherry-pick it. This would have the > advantage of not "forking"

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-26 Thread Cor Nouws
[ just 'reply' for the cc's ] Stefan Knorr (Astron) wrote (26-01-12 14:16) Hi, I just checked, and must say that I can only second Cor and Drew in that it is too quick now. Could we go back to 1.1 or maybe 2^(1/8)=1.0905 (that should deliver a similar effect as 2^(1/4), no? – I am bad at maths,

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-26 Thread Cor Nouws
[ just 'reply' for the cc's ] drew wrote (26-01-12 08:36) On Thu, 2012-01-26 at 08:21 +0100, Jan Holesovsky wrote: Hi Cor, On 2012-01-26 at 00:16 +0100, Cor Nouws wrote: Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better here, the 1.1 means way too much wheel rotation to inc

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-26 Thread Stefan Knorr (Astron)
Hi, I just checked, and must say that I can only second Cor and Drew in that it is too quick now. Could we go back to 1.1 or maybe 2^(1/8)=1.0905 (that should deliver a similar effect as 2^(1/4), no? – I am bad at maths, so this might be nonsense)? > Instead of increasing the step amount by five

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread drew
On Thu, 2012-01-26 at 08:21 +0100, Jan Holesovsky wrote: > Hi Cor, > > On 2012-01-26 at 00:16 +0100, Cor Nouws wrote: > > > >> Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better > > >> here, the 1.1 means way too much wheel rotation to increase / decrease > > >> the zoom consider

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Jan Holesovsky
Hi Cor, On 2012-01-26 at 00:16 +0100, Cor Nouws wrote: > >> Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better > >> here, the 1.1 means way too much wheel rotation to increase / decrease > >> the zoom considerably; but of course can be changed easily when another > >> [..] > > >

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Cor Nouws
Tim Hardeck wrote (25-01-12 15:29) On Wednesday 25 January 2012 12:46:02 Jan Holesovsky wrote: Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better here, the 1.1 means way too much wheel rotation to increase / decrease the zoom considerably; but of course can be changed easily w

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Stefan Knorr (Astron)
Sounds good. Had checked Tim's original patch yesterday and liked the behaviour so far. Astron. On 25/01/2012, Tim Hardeck wrote: > Hi Kendy, > > thanks for the commit and cleanup. I also thought that 1.2 was a better fit > so fine with me. > > Regards > Tim > > On Wednesday 25 January 2012 12:4

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Tim Hardeck
Hi Kendy, thanks for the commit and cleanup. I also thought that 1.2 was a better fit so fine with me. Regards Tim On Wednesday 25 January 2012 12:46:02 Jan Holesovsky wrote: > Hi Tim, > > On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote: > > > thanks for the information, I have attached a new

[Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Jan Holesovsky
Hi Tim, On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote: > thanks for the information, I have attached a new patch and also 25% is > enforced like Stefan requested. Great stuff - I've pushed that: http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d2ddc161e4b296febe9e54c3cfc9270310bfe

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments

2012-01-20 Thread Michael Stahl
On 20/01/12 13:50, Philipp Weissenbacher wrote: > Hi lo-devs, > Some more translations ... thanks, pushed (with some tweaks) notes: - "Vorlage" can mean either "template" (if it's a document) or "style" if it's some content element (the latter are called *FmtColl in writer) - there is no "too les

[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW-3-5] fdo#44025 isLast() erroneously returns true

2012-01-20 Thread Michael Stahl
On 19/01/12 20:47, Lionel Elie Mamane wrote: > Attached patch fixes fdo#44025; the original symptom is "search in a > database does not go beyond prefetch window". The underlying reason is > that dbaccess::ORowSetCache::isLast() returns true on the last line of > the *prefetch* *window* even if it

Re: [Libreoffice] [PUSHED] Re: [PATCH] Replaced SAL_INFO with SAL_WARN. Was: [PATCH] Replaced DBG_ERRORFILE with SAL_INFO.

2012-01-18 Thread Eike Rathke
Hi Michael, On Tuesday, 2012-01-17 23:34:22 +0100, Michael Stahl wrote: > thanks for the patches, pushed the whole lot. You were faster than me building over night ... just one nitpick, it's i18n not l18n ;-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=923934d0f41b5b54c9aa4491958cd19

[Libreoffice] [PUSHED] Re: [PATCH] Replaced SAL_INFO with SAL_WARN. Was: [PATCH] Replaced DBG_ERRORFILE with SAL_INFO.

2012-01-17 Thread Michael Stahl
On 17/01/12 14:52, Marcel Metz wrote: > Hello lo-devs, > > Eike Rathke asked me via IRC if I could replace the SAL_INFO calls with > SAL_WARN calls in the previous patch. The attached patches contain the > requested change. indeed, most of these look more like warnings to me. thanks for the patc

[Libreoffice] [PUSHED] Re: [PATCH][3-5] make building and installing of nsplugin more consistent

2012-01-17 Thread Michael Stahl
On 13/01/12 17:11, Matúš Kukan wrote: > Hi, > > I was now playing with nsplugin in master, so I created also patch for 3-5. > > It was installed only in without mozilla case but compiled also in the > other case. > So now in master and in the patch nsplugin is only for with mozilla case. > > But

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments and fix some English ones

2012-01-10 Thread Jan Holesovsky
Hi Philipp, On 2012-01-09 at 14:18 +0100, Philipp Weissenbacher wrote: > Here are two more patches. Thank you, pushed! :-) > Patch #1 contains a few FIXMEs. That's where my creativity failed me > and I just couldn't figure out what the original author meant. > Thus, I'd greatly appreciate feedb

[Libreoffice] [PUSHED] Re: [PATCH 1/3] Removed unnecessary tools/link.hxx includes.

2012-01-06 Thread Michael Stahl
On 06/01/12 20:47, Marcel Metz wrote: > Hello lo-devs, > > this patch series removes another batch of unused tools module > includes. The patches without suffix should be applied to the core > repository, the .binfilter.patch suffix should be applied to the > binfilter repository. I've tested the

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix EasyHack FDO42454, remove code associated with unused icons

2012-01-04 Thread Michael Meeks
On Thu, 2011-12-29 at 20:28 +0100, Jan Holesovsky wrote: > But I did not touch these (ie. did not use this part of your patch). > There is something more rotten going on - as you can see, the images > in .src use .bmp (!) suffix, not .png, so I suspect there is even more > unused code there, proba

Re: [Libreoffice] [PUSHED] Re: [PATCH] Translate German comments to English and correct the English ones

2012-01-04 Thread Philipp Weissenbacher
On 4 January 2012 14:07, Michael Stahl wrote: > On 04/01/12 12:57, Philipp Weissenbacher wrote: >> Hi all, >> >> Here's another patch that translates the German comments to English >> and fixes some errors in the English ones. > > thanks, pushed (tweaked the translations a bit in a follow-up) > >>

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments to English and correct the English ones

2012-01-04 Thread Michael Stahl
On 04/01/12 12:57, Philipp Weissenbacher wrote: > Hi all, > > Here's another patch that translates the German comments to English > and fixes some errors in the English ones. thanks, pushed (tweaked the translations a bit in a follow-up) > In htmltbl.cxx: > I interpreted 'tab' in some OSL_ENSURE

[Libreoffice] [PUSHED] Re: [PATCH] (3.5 Beta2) Fix for fdo#44280 [GUI] wrong position of 'Adding extension...' at Extension Manager dialog

2012-01-03 Thread Michael Stahl
On 29/12/11 19:10, Olivier Hallot wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi > > Please find enclosed a patch to fix fdo#44280 > > The patch was done in master and should be cerry picked in 3.5 ASAP thanks, looks much better with the patch! pushed to master and libreoffice-

[Libreoffice] [PUSHED] Re: [PATCH] Easyhack fdo#38831 - Convert some SvStrings to std::vector

2011-12-30 Thread Jan Holesovsky
Just adding [PUSHED] to the subject, sorry... Kendy On 2011-12-30 at 16:53 +0100, Jan Holesovsky wrote: > Hi Brad, > > On 2011-12-28 at 16:47 +1300, Brad Sowden wrote: > > > > Attached are 2 patches to covert come SvStrings to std::vector. > > > > I realised I missed some size_t conversions and

[Libreoffice] [PUSHED] Re: [PATCH] Fix for fdo43460 Part XXIV getLength() to isEmpty()

2011-12-30 Thread Jan Holesovsky
[PUSHED] in subject now, sorry :-( K. On 2011-12-30 at 13:04 +0100, Jan Holesovsky wrote: > Hi Olivier, > > On 2011-12-27 at 16:38 -0200, Olivier Hallot wrote: > > > Please find attached a partial fix for Easy Hack FDO43460 > > > > Part XXIII > > Modules > > lotuswordpro > > One more pushed :

[Libreoffice] [PUSHED] Re: [PATCH] Fix for fdo43460 Part XXIII getLength() to isEmpty()

2011-12-30 Thread Jan Holesovsky
Now with the [PUSHED] in subject too, sorry. K. On 2011-12-30 at 12:39 +0100, Jan Holesovsky wrote: > Hi Oliver, > > On 2011-12-27 at 11:11 -0200, Olivier Hallot wrote: > > > Please find attached a partial fix for Easy Hack FDO43460 > > > > Part XXIII > > Modules > > linguistic > > And even t

[Libreoffice] [PUSHED] Re: [PATCH] Fix for fdo43460 Part XXI getLength() to isEmpty()

2011-12-30 Thread Jan Holesovsky
Hi Olivier, On 2011-12-26 at 17:24 -0200, Olivier Hallot wrote: > Please find attached a partial fix for Easy Hack FDO43460 > > Part XXI > Modules > i18npool, idl, idlc, io, javaunohelper, jvmaccess Thank you a lot, pushed :-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=a17fb882569

[Libreoffice] [PUSHED] Re: [PATCH] Fix for fdo43460 Part XVIII getLength() to isEmpty()

2011-12-30 Thread Jan Holesovsky
Hi Gustavo, On 2011-12-26 at 15:49 -0200, Gustavo Pacheco wrote: > Partial fix for Easy Hack FDO43460 (part XVIII) for review. > Part XVIII > Module forms Very nice, pushed, thank you! :-) http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cfae09e5dafa477db210272949e253d4fb24349 R

[Libreoffice] [PUSHED] Re: [PATCH] Fix for fdo43460 Part XX getLength() to isEmpty()

2011-12-30 Thread Jan Holesovsky
Hi Olivier, On 2011-12-26 at 14:24 -0200, Olivier Hallot wrote: > Please find attached a partial fix for Easy Hack FDO43460 > > Part XX > Module > framework Great stuff, pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=18692cc1412bd7eca37d80d4345c0ae775d94ac5 Regards, Kendy __

[Libreoffice] [PUSHED] Re: [PATCH] fix EasyHack FDO42454, remove code associated with unused icons

2011-12-29 Thread Jan Holesovsky
Hi Gustavo, On 2011-12-20 at 16:19 -0200, Gustavo Pacheco wrote: > Fix for EasyHack FDO42454 > (https://bugs.freedesktop.org/show_bug.cgi?id=42454) in attachment for > review. Thank you very much for the patch! :-) - and sorry that it took so long to apply. I used most of that, please see: htt

Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Marcel Metz
On 21.12.2011 20:27, Michael Stahl wrote: > > pushed to master, with 2 small corrections: > > this here inverted the logic, Get == 0 means not found: > - if ( p != pAct && !rTable.Get( p->GetActionNumber() ) ) > + if ( p != pAct && rMap.find( p->GetActionNumber() ) != rMap.end() ) > > and in Sc

Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Eike Rathke
Hi Michael, On Wednesday, 2011-12-21 20:27:21 +0100, Michael Stahl wrote: > and in ScChangeTrack::Reject, the old code iterated from end to start > (dunno if that is important there, but why not use a reverse_iterator) Yes, rejections must happen in reverse order there, thanks for catching. E

[Libreoffice] [PUSHED] Re: [PATCH] Replace SwTxtPortionTable with std::map.

2011-12-21 Thread Michael Stahl
On 21/12/11 18:50, Marcel Metz wrote: > Hello lo-devs, > > this patch replaces yet another Table class use. > > regards Marcel Metz thanks for the patch, pushed to master regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.or

[Libreoffice] [PUSHED] Re: [PATCH] fdo#38832 Replace ScChangeActionTable with std::map.

2011-12-21 Thread Michael Stahl
On 21/12/11 16:18, Marcel Metz wrote: > Hello lo-devs, > > I've tested the patch with 'make check', but would like to point out > that the reviewer should take special care of the change in > 'sc/source/core/tool/chgtrack.cxx:3140-3160'. From my understanding > of the code the tools Table does not

[Libreoffice] [PUSHED] Re: [patch] translate some german comments in /svx

2011-12-20 Thread Michael Stahl
On 19/12/11 12:56, Noel Grandin wrote: > Hi > > More translations, work by Mike Whiteley and Noel Grandin, patch is > under MPL/LGPL+ > > Regards, Noel thanks for your patch, pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=c5ed0b8f95600c3ceacbcd4511dc3a7b4cabcbae

[Libreoffice] [PUSHED] Re: [PATCH] Translation of German comments in /svx/source/svdraw (part2)

2011-12-06 Thread Michael Stahl
On 05/12/11 14:27, Stefan Knorr (Astron) wrote: > Hello. > > As promised, here is the second part... a big thanks goes to Eike who... >> managed to get hold of an intact revision before ooo/DEV300_m101 was >> merged and converted it from *gasp* cp437 to utf-8 > > I am still unsure what to make of

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments

2011-11-30 Thread Jan Holesovsky
On 2011-11-30 at 10:15 +0100, Stefan Knorr (Astron) wrote: > Okay, pushed with a few modifications. Yay. Just marking the thread as [PUSHED], thank you both! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-19 Thread Tomofumi Yagi
Hi Michael, Cedric, Thank you for everything. (11/11/19 7:17), Michael Stahl wrote: hi Tomofumi, thank you for your patch; i have pushed it, but not as a fix to the bug 40831 :) (--) i am currently not sure if your patch is the right fix; i would assume that the cursor that points to the r

Re: [Libreoffice] [PUSHED] Re: [PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

2011-11-19 Thread Noel Power
Hi On 19/11/11 00:39, Jan Holesovsky wrote: Hi Niklas, [...] Thank you very much for the patch, great! :-) Please can you confirm that it is under our preferred license combo, LGPLv3+ / MPL? it is :-), see https://bugs.freedesktop.org/show_bug.cgi?id=40505#c5 Ideally in the form "This and

[Libreoffice] [PUSHED] Re: [PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

2011-11-18 Thread Jan Holesovsky
Hi Niklas, On 2011-11-18 at 10:10 +, Noel Power wrote: > > It's my first contribution to the source of LO so I hope I've done > > everything correctly. > > Please let me know otherwise. > > everything perfect, nice patch, commit is here > http://cgit.freedesktop.org/libreoffice/core/commit/?

[Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-18 Thread Michael Stahl
On 16/11/11 16:08, Tomofumi Yagi wrote: > I attached a revised patch. hi Tomofumi, thank you for your patch; i have pushed it, but not as a fix to the bug 40831 :) > On 17/11/11 09:27, Cedric Bosdonnat wrote: >> Hi Michael, >> >> On Wed, 2011-11-16 at 16:20 +0100, Michael Stahl wrote: >>> now

[Libreoffice] [PUSHED] Re: [PATCH] writer AnchoredObjects accessed after deletion under some circumstances

2011-11-18 Thread Michael Stahl
On 10/11/11 17:44, Caolán McNamara wrote: > So, I have a document which triggers the attached traces.txt if I close > the document before the layout completes. > > Here's what I think I see. The SwView goes away first, and the writer > layout hierarchy goes away with it. Then the SwDoc goes away.

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-26 Thread Cedric Bosdonnat
Hi Kohei, all, On Tue, 2011-10-25 at 09:46 -0400, Kohei Yoshida wrote: > The patch looks safe to me. Cedric, if it's okay with you, I'd like to > backport this to the 3.4 branch with my sign-off. What do you think? I'm all for it... I only don't have time these days as I'm attending/presenting

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-25 Thread Kohei Yoshida
On Mon, 2011-10-24 at 12:50 +0900, Tomofumi Yagi wrote: > Hi, > > So many thanks for reviewing and pushing the patch. > > > And,There is one more please. > > Please Consider backport the patch to 3.4, if possible. > > This broblem on LibleOffice 3.4 as stable version gives to user a very bad

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-23 Thread Tomofumi Yagi
Hi, So many thanks for reviewing and pushing the patch. And,There is one more please. PleaseConsiderbackport the patch to 3.4, if possible. This broblem on LibleOffice 3.4 as stable version gives to user a very bad feedback. I hope to fix Bug 37129 on LibleOffice 3.4. Regards, Tomofumi

[Libreoffice] [PUSHED] Re: [PATCH] SvUShorts -> std::vector

2011-10-20 Thread Ivan Timofeev
2011/10/20 Daniel Di Marco : > I replaced some more SvUShorts with std::vectors. http://cgit.freedesktop.org/libreoffice/core/commit/?id=593e4c36d2f199cc3b82be587bc7674c2f394d06 Pushed. Thank you! ;) ___ LibreOffice mailing list LibreOffice@lists.freedes

[Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-20 Thread Jan Holesovsky
On 2011-10-20 at 02:12 -0700, cbosdonnat wrote: > You're patch is nice, many thanks for it! I pushed it to master: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c2902ecbf135fae070ea032fa10a59bb76ec1b0 Just marking the patch as pushed :-) [in the mail thread]. Thank you a lot for tha

Re: [Libreoffice] [PUSHED] Re: [PATCH] fdo#41187: "Grid display" settings in Writer does not apply correctly to Page Preview

2011-10-07 Thread Takeshi Abe
Hi Kendy, Thank you for pushing it! On Fri, 07 Oct 2011 00:53:25 +0200, Jan Holesovsky wrote: > On 2011-10-06 at 20:25 +0900, Takeshi Abe wrote: > >> On fdo#41187 >> https://bugs.freedesktop.org/show_bug.cgi?id=41187 >> the reporter suggests that "Print grid" should be ignored unless "Display

Re: [Libreoffice] [PUSHED] Re: [PATCH] Replace WW8Bytes with ww::bytes

2011-10-07 Thread Maciej Rumianowski
2011/10/7 Jan Holesovsky > No need to, I took this approach > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1eda55a0670cd571d676b46d2ac19fe86d51a3f > > and modified your patches myself. I've pushed them under your name, as > all I did was a sed :-) > > > http://cgit.freedesktop.or

[Libreoffice] [PUSHED] Re: [PATCH] filter: PDF Export UI "page range" autofocus

2011-10-07 Thread Jan Holesovsky
Hi Maxim, On 2011-10-05 at 22:57 +0200, Maxim Iorsh wrote: > When the user selects "Pages" radio button in the Range section, it is very > reasonable to expect that she would now want to specify the range. Thus moving > the focus automatically to the page range edit box would save the user a mous

[Libreoffice] [PUSHED] Re: [PATCH] fdo#41187: "Grid display" settings in Writer does not apply correctly to Page Preview

2011-10-06 Thread Jan Holesovsky
Hi Takeshi, On 2011-10-06 at 20:25 +0900, Takeshi Abe wrote: > On fdo#41187 > https://bugs.freedesktop.org/show_bug.cgi?id=41187 > the reporter suggests that "Print grid" should be ignored unless "Display > grid" > is checked. > I am wondering if an easy trick that making "Print grid" checked/un

[Libreoffice] [PUSHED] Re: [PATCH] Replace WW8Bytes with ww::bytes

2011-10-06 Thread Jan Holesovsky
Hi Maciej, On 2011-10-05 at 22:02 +0200, Maciej Rumianowski wrote: > > That same would be allowed by > > class bytes : public std::vector > > { > > public: > > const sal_uInt8* data() const { return &front(); } > > ... > So if it is desired solution I can modify Patches? No need to, I took th

[Libreoffice] [PUSHED] Re: [PATCH] fix for bug fdo#41478: [UI] Add protect sheet command to sheet tab popup menu

2011-10-05 Thread Jan Holesovsky
Hi Olivier, On 2011-10-05 at 11:43 -0300, Olivier Hallot wrote: > The following patch fixes bug fdo#41478, enhancement to add the > command "Protect Sheet..." to the sheet context menu. Thank you a lot, pushed! :-) Regards, Kendy ___ LibreOffice mail

[Libreoffice] [PUSHED] Re: [PATCH] simplify IsEmpty() logic in autodoc

2011-10-05 Thread Jan Holesovsky
Hi Kevin, On 2011-10-04 at 19:02 -0400, Kevin Hunter wrote: > A simple driveby patch that makes use of the standard library. Nice catch! :-) Pushed. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskt

Re: [Libreoffice] [PUSHED] Re: [PATCH] typo in (private) member name

2011-08-22 Thread Lionel Elie Mamane
On Mon, Aug 22, 2011 at 03:25:18PM +0200, Jan Holesovsky wrote: > On 2011-08-14 at 17:11 +0200, Lionel Elie Mamane wrote: >> Patch attached. > Just marking it [PUSHED] - somebody has done that already :-) Yes, Norbert did, and marked it PUSHED, albeit not in *front* of the subject line, but mor

[Libreoffice] [PUSHED] Re: [PATCH] typo in (private) member name

2011-08-22 Thread Jan Holesovsky
Hi Lionel, On 2011-08-14 at 17:11 +0200, Lionel Elie Mamane wrote: > Patch attached. Just marking it [PUSHED] - somebody has done that already :-) Thank you! Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskto

[Libreoffice] [PUSHED] Re: [PATCH] Fix field values in export to docx

2011-08-05 Thread Jan Holesovsky
Hi Troy, Lubos, Lubos Lunak píše v Pá 29. 07. 2011 v 19:52 +0200: > > > > +sExpand.SearchAndReplaceAll( 0x0A, 0x0B ); > > > > > > This line looks strange. What is the reason for this? > > > > You'll find the same pattern in the binary .doc import/export. Newlines > > embedded in fields a

[Libreoffice] [PUSHED] Re: [PATCH] Add missing libdir path for qt4 detection

2011-08-04 Thread Lubos Lunak
On Wednesday 03 of August 2011, Tomáš Chvátal wrote: > 0001-Add-one-more-libdir-path-for-detection-with-qt4-on-3.patch Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

[Libreoffice] [PUSHED] Re: [PATCH] Import of xrefs to numbered paragraphs from docx

2011-08-01 Thread Lubos Lunak
On Friday 22 of July 2011, Troy Rollo wrote: > This replaces the earlier version of this patch, which was wrong for the > NUMBER_FULL_CONTEXT cross-reference type. > --- Pushed. If you had a testcase for these fixes, please provide them somewhere next time, it'd make reviewing of the patches muc

[Libreoffice] [PUSHED] Re: [PATCH] Fix parent level count in numbering from docx

2011-08-01 Thread Lubos Lunak
On Monday 01 of August 2011, Lubos Lunak wrote: > On Friday 22 of July 2011, Troy Rollo wrote: > > Before this patch, when importing from docx, if there were no parent > > numbering levels in the number formats for outline numbered paragraphs, > > the import would include all parent levels back to

[Libreoffice] [PUSHED] Re: [PATCH] Fix fdo#36868 - doc import list numbering error

2011-07-28 Thread Lubos Lunak
On Saturday 23 of July 2011, Troy Rollo wrote: > This patch appears to be fix fdo#36868. The problem is that the paragraph > style was never being assigned an outline list level. The saved file did > not have an sprmPOutLvl for that paragraph (although it did have one for > the level 0 style), just

[Libreoffice] [PUSHED] Re: [PATCH] Splash screen fix for multi-head on Linux (bug 33214)

2011-07-20 Thread Jan Holesovsky
Hi Josh, On 2011-07-20 at 14:40 +0930, Josh Heidenreich wrote: > Uses xinerama to get the size of the primary screen Beautiful, thank you! :-) Pushed to master, can you please confirm that your patch is under LGPLv3+ / MPL? What are you interested in next? Thank you a lot, Kendy

[Libreoffice] [PUSHED] Re: [PATCH] Re: svtools/source/contnr/imivctl1.cxx not matching imivctl1.hxx

2011-07-19 Thread Jan Holesovsky
Hi Maciej, On 2011-07-16 at 17:22 +0200, Maciej Rumianowski wrote: > > I have changed it and now building again if it works, I will send a > > Patch. It will be my first :) > > Patch in attachment, ofcourse on LGPL3+/GPL3+/MPL. Thank you very much for the patch! :-) Joseph has pushed it the oth

[Libreoffice] [PUSHED] Re: [PATCH] fix broken image paths in help fdo#37509

2011-06-27 Thread Caolán McNamara
On Mon, 2011-06-27 at 12:51 +0200, Andras Timar wrote: > Hi, > > Can someone please push this to 3-4. Looks sane to me, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Re: Autogen switch --with-agfa-monotype-fonts fails to download fonts tarball, Win32 build-only switch ?

2011-06-20 Thread Caolán McNamara
On Mon, 2011-06-20 at 12:10 +0200, Alexander Thurgood wrote: > Enclosed diff proposing change to configure switch help message text. Looks good, PUSHED. I sort of wonder why we have that in there at all actually, but anyway. C. ___ LibreOffice mailing

[Libreoffice] [PUSHED] Re: [PATCH] Support font effects "Capitals", "Lowercase" and "Title" in HTML export

2011-06-14 Thread Caolán McNamara
On Sun, 2011-06-12 at 19:03 +0300, Harri Pitkänen wrote: > Export Writer font effects "Capitals", "Lowercase" and "Title" (see Format -> > Character -> Font effects) to HTML using CSS text-transform property. Looks good to me, pushed, thanks for this. C.

[Libreoffice] [PUSHED] Re: [PATCH] Remaining translations of German comments from fdo#33424

2011-06-07 Thread Jan Holesovsky
Hi Korrawit, Korrawit Pruegsanusak píše v So 04. 06. 2011 v 17:09 +0700: > Anyway, there are some tiny parts that aren't committed yet, > which I don't know whether they're accidentally slipped, or > intentionally dropped. > So I attach that remaining parts for review. > Please feel free to comme

Re: [Libreoffice] [PUSHED] Re: [PATCH] Set GTK+ native mouse behaviour settings

2011-06-03 Thread Christian Dywan
Am Fri, 03 Jun 2011 10:30:30 +0100 schrieb Caolán McNamara: > Is there a confirmation email anywhere that states the lanedo > patches/submissions are under the LGPLv3+/MPL ? > > Its implied by > http://blog.documentfoundation.org/2011/05/31/lanedo-supports-libreoffice/ > I guess. I'm not sure if

[Libreoffice] [PUSHED] Re: [PATCH] Set GTK+ native mouse behaviour settings

2011-06-03 Thread Caolán McNamara
On Thu, 2011-04-28 at 12:40 +, Christian Dywan wrote: > This patch adds mouse behaviour settings for GTK+. > > Tested with for example double click time that renders me unable to double > click and works even without a restart. Nifty, I said to myself reading patches in threads unterminated

[Libreoffice] [PUSHED] Re: [PATCH] Display non printable characters on the end of line

2011-06-03 Thread Caolán McNamara
On Sat, 2011-04-30 at 01:19 +0200, Jan Holesovsky wrote: > Bartosz - can you please provide us with your full name, and also can > you confirm that your patch is under LGPLv3+ and MPL? I see this got pushed. Bartosz can you confirm the above question about LGPLv3+/MPL licensing of the patch ? C.

[Libreoffice] [PUSHED] Re: [PATCH] Don't print === decoration when running g grep

2011-05-18 Thread Christian Dywan
Am Fri, 6 May 2011 12:35:04 + schrieb Christian Dywan: > git grep -l is useless when the == are there because it no longer is > a plain list of filenames. I needed it for sed, so I patched it. I modified the patch to account for the changes made meanwhile, same functional difference, and pus

[Libreoffice] [PUSHED] Re: [PATCH] Unify Display Grid/ Grid Visible and other menu items

2011-05-18 Thread Christian Dywan
Am Mon, 09 May 2011 14:24:01 +0200 schrieb Fridrich Strba: > I would like to integrate this patch. Is it the final version and are > all parties happy with it? > > F. Sorry for the delay, being at UDS and other things kept me from it. I have a commit account now and pushed the diff as individua

[Libreoffice] [PUSHED] Re: [PATCH] Fix osl_Security::getHomeDir test under fakeroot

2011-05-09 Thread Fridrich Strba
Done! F. On Sun, 2011-05-08 at 14:23 +0200, Miklos Vajna wrote: > Hi, > > See the attached patch, I needed it to build 3.4beta4 under fakeroot > (for some reason I did not have this issue with beta3). > > Can someone sign it off and push to -3-4, please? > > Thanks. >

[Libreoffice] [PUSHED] Re: [PATCH] new color picker dialog for all applications

2011-05-06 Thread Jan Holesovsky
Hi Christian, On 2011-05-05 at 22:18 +0200, Christian Lippka wrote: > It replaces the old color picker with a new one. See here for a video > demo > > http://youtu.be/rPu6EmIxkIM?hd=1 > > To see it in the running office you can for example go to menu > tools->options->colors and press edit Bea

[Libreoffice] [PUSHED] Re: [PATCH] Enable native sumbenu arrow drawing and implement it in GTK+

2011-05-06 Thread Fridrich Strba
Great work Mitch :) Keep on sending nice patches ;) Pushed F. P.S.: Hope it builds :P On Fri, 2011-05-06 at 12:12 +0200, Michael Natterer wrote: > Attached patch does what the subject says. > > I'm not quite sure if I got everything right, especially > I can't make much sense of how the retur

[Libreoffice] [PUSHED] Re: [PATCH] Remove usage of List in SbiDdeControl

2011-05-06 Thread Fridrich Strba
Great work. Integrated now. F. On Wed, 2011-04-27 at 11:36 -0430, Rafael Dominguez wrote: > Well this patch is for windows only, but i develop only in linux, so > if anyone can please review it and test it for me. Thanks > ___ > LibreOffice mailing lis

[Libreoffice] [PUSHED] Re: [PATCH] Remove DECLARE_LIST(DdeConnections, DdeConnection*)

2011-05-06 Thread Fridrich Strba
Pushed. Thanks. F. On Wed, 2011-04-27 at 12:12 -0430, Rafael Dominguez wrote: > This is a windows only patch, please check it compiles fine and > without errors, thanks! > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://list

[Libreoffice] [PUSHED] Re: [PATCH] Remove DECLARE_LIST(DdeTopics, DdeTopic*) [Windows only]

2011-05-06 Thread Fridrich Strba
Pushed this one. Thanks for your great work. F. On Wed, 2011-04-27 at 16:57 -0430, Rafael Dominguez wrote: > Oops forgot to send patch > > On Wed, Apr 27, 2011 at 4:57 PM, Rafael Dominguez > wrote: > This is a windows only patch, please check that you can > compile it and check

[Libreoffice] [PUSHED] Re: [PATCH] Remove DECLARE_LIST(DdeItems, DdeItem*) [Windows]

2011-05-06 Thread Fridrich Strba
Landed in master. Thanks for your contribution. F. On Wed, 2011-04-27 at 17:50 -0430, Rafael Dominguez wrote: > Windows only patch, please check that it compiles without error and i > didnt forget anything, thanks!! > ___ > LibreOffice mailing list > L

[Libreoffice] [PUSHED] Re: [PATCH] Remove DECLARE_LIST(DdeTransactions, DdeTransaction*) [Windows only]

2011-05-06 Thread Fridrich Strba
Pushed to master. Thanks for your great work. f. On Wed, 2011-04-27 at 19:15 -0430, Rafael Dominguez wrote: > Windows only patch, please compile and check that theres no errors, > thanks > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.o

[Libreoffice] [PUSHED] Re: [PATCH] fdo#31251 Writer & Impress shadow consistency

2011-05-03 Thread Jan Holesovsky
Hi David, Sebastien, On 2011-05-03 at 14:37 +0200, David Tardon wrote: > > So - I like it, and would love to include for 3.4; one more review > > needed :-) - David? Cedric? > > +1 from me, even with the small glitches Great, thanks a lot! Pushed :-) Regards, Kendy _

[Libreoffice] [PUSHED] Re: [PATCH] Fixed bug regarding zero values not appearing (Bug 36748).

2011-05-03 Thread Jan Holesovsky
Hi Cassio, On 2011-05-01 at 18:27 +0100, Cassio Neri wrote: > It's probably unnecessary to say this but, for the avoidance of doubt, > my contribution is released under LGPLv3+ / MPL. > > > > Please find attached a patch to fix bug 36748. Very nice, thank you for that! :-) Kohei has already pus

[Libreoffice] [PUSHED] Re: [PATCH] Remove tools/list.hxx include

2011-05-02 Thread Jan Holesovsky
On 2011-04-27 at 11:56 -0430, Rafael Dominguez wrote: > Windows only patch, please review it and make sure it compiles without > issues on a windows pc, but it looks straightfoward thing so it should > be any issue with it. Thanks Seen this pushed :-) Regards, Kendy _

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused sstring files in bootstrp

2011-05-02 Thread Jan Holesovsky
Hi Rafael, Joseph, I see this pushed, so adding the right [PUSHED] prefix. Thank you for that! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Clean up GtkSettings use in GTK+ platform module

2011-04-29 Thread Jan Holesovsky
Hi Christian, On 2011-04-28 at 17:41 +, Christian Dywan wrote: > This patch cleans up the GTK+ module a bit, fixing theming bugs in > corner cases by using ONE way to get screen and settings, the > different variants were either wrong or needlessly confusing. Cool, thank you! Pushed. Regar

[Libreoffice] [PUSHED] Re: [PATCH] Removing the deprecated java.io.File.toURL() method.

2011-04-29 Thread Jan Holesovsky
Hi Cyril, On 2011-04-29 at 00:36 +0200, Cyril Roelandt wrote: > The attached patch replaces a call to File.toURL() by a call to > File.toURI() followed by a call to URI.toURL() in ActiveSyncDriver.java. Nice catch, thank you! Pushed :-) > Feel free to apply whatever free software licence you

[Libreoffice] [PUSHED] Re: [PATCH] Unify light gray checked color special case

2011-04-29 Thread Jan Holesovsky
Hi Christian, On 2011-04-29 at 11:03 +, Christian Dywan wrote: > Thusly I'm merging those into one function SetCheckedColorSpecialCase. Very nice! Thank you, pushed :-) > Notably OSX doesn't set the colour at all - a look from a Mac > developer is probably a good idea. Can be a follow-up

[Libreoffice] [PUSHED] Re: [PATCH] Error dialog when a component is missing

2011-04-26 Thread Lubos Lunak
On Friday 22 of April 2011, Kohei Yoshida wrote: > Hi Lubos, > > On Fri, 2011-04-22 at 15:36 +0200, Lubos Lunak wrote: > > Hello, > > > > could somebody review the attached patch for bnc#689116? When e.g. > > Writer is not installed (which can happen with split rpms) and one tries > > to open a te

[Libreoffice] [PUSHED] Re: [PATCH] Only accelerators in Edit popup on Windows and KDE

2011-04-21 Thread Jan Holesovsky
Hi, On 2011-04-19 at 14:01 +0200, Lubos Lunak wrote: > By setting I don't mean a configurable setting, but a style setting, i.e. > the > StyleSettings vcl class. There are already settings for things like palette, > widget sizes, cursor blink time, whether to show icons in menus and other >

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused chunk of toolbar menu code

2011-04-19 Thread Lubos Lunak
On Tuesday 19 of April 2011, Christian Dywan wrote: > I stumbled upon a big chunk of code that's commented out in > ToolbarMenu::implPaint not touched since November 2005. Pushed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list Li

[Libreoffice] [PUSHED] Re: [PATCH] fixes for some cppcheck warnings

2011-04-18 Thread Caolán McNamara
On Fri, 2011-04-15 at 16:32 -0300, Kayo Hamid wrote: > On Fri, 15 Apr 2011 16:25:32 -0300, Kayo Hamid > wrote: > > Just variableScope, sending for review. pushed, thanks for this. Poking at this area, the DWORD err is unused, but the typical pattern elsewhere is to call ImplWriteLastError on th

[Libreoffice] [PUSHED] Re: [PATCH] Remove unneeded minus and plus keyboard aliases

2011-04-15 Thread Jan Holesovsky
Hi Christian, On 2011-04-15 at 12:51 +, Christian Dywan wrote: > The various KeysymNameReplacement arrays all contain XK_plus and XK_minus but > in fact no existing keyboard layout has labels other than literal "+" and "-" > for these keys. Removing these means that it becomes clearer what la

[Libreoffice] [PUSHED] Re: [PATCH] Remove more code using M1310 and M1400

2011-04-12 Thread Fridrich Strba
And the topic is messenger again :) F On 12/04/11 09:49, Francois Tigeot wrote: On Mon, Apr 11, 2011 at 12:07:23PM +0200, Fridrich Strba wrote: The topic says it all And that's good. I have missed a few occurences. This next patch takes care of them. _

[Libreoffice] [PUSHED] Re: [PATCH] Remove M1310 and M1400

2011-04-11 Thread Fridrich Strba
The topic says it all F. On 09/04/11 09:35, Francois Tigeot wrote: On Sat, Apr 09, 2011 at 09:02:35AM +0200, Francois Tigeot wrote: There are also M1310 and M1400 checks, but M1310 and M1400 are not defined anywhere and can be safely removed. The attached patch removes all occurences of M131

[Libreoffice] [PUSHED] Re: [PATCH] Change accel key back to "D" for "Clear direct formatting"

2011-04-06 Thread Jan Holesovsky
Hi Octavio, Octavio Alvarez píše v Ne 03. 04. 2011 v 16:32 -0700: > Now that "~Default Formatting" is named "~Clear Direct Formatting" it > makes "C" not go directly to "Clear Direct Formatting" because there were > other menu items already using "~C". I submit these patches to set it back

[Libreoffice] [PUSHED] Re: [PATCH] fix obvious bug in VCL that prevent glyph-fallback for one glyph-missing character at the end of string

2011-03-24 Thread Caolán McNamara
On Thu, 2011-03-24 at 21:27 +0700, Samphan Raruenrom wrote: > While working on other bugs, we found this bug in > vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx . When > there is only one character at the end of the string that require > glyph-fallback, the bug prevent glyph-fallba

[Libreoffice] [PUSHED] Re: [PATCH] Fix and enable more unit tests in sal/qa/rtl

2011-03-18 Thread Caolán McNamara
On Thu, 2011-03-17 at 14:50 +0100, Theo van Klaveren wrote: > Hello again, > > More unit test hacking. Only the ones that work are enabled. Looks good, pushed, thanks for these. > Some questions that are coming up: > > - Some unit tests contain .xsce files that seem to be used to tell > told t

[Libreoffice] [PUSHED] Re: [PATCH] Add non blank characters in meta informations

2011-03-17 Thread Jan Holesovsky
Hi Arnaud, On 2011-03-12 at 17:31 +0100, Arnaud Versini wrote: > This patch add non blank count in Writter metafile information's. Looks great to me - pushed, thanks! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

[Libreoffice] [PUSHED] Re: [PATCH 1/2] Remove reference to unavailable bugtrackers

2011-03-14 Thread Caolán McNamara
On Mon, 2011-03-07 at 12:25 +0100, Martin Kepplinger wrote: > This removes references to some internel bugtrackers that are (according to > http://wiki.documentfoundation.org/Development/FAQ ) not available to the > community in writer/starmath. I see you pushed these already, as an aside, in case

  1   2   3   4   >