On 30/01/12 15:43, Lionel Elie Mamane wrote: > I attach here the "less invasive" variant originally meant for > libreoffice-3-5. > > However, if people are happy with cherry-picking the (more invasive) > master commit, by all means, cherry-pick it. This would have the > advantage of not "forking" these codepaths between 3.5 and 3.6, which > means these codepaths will get more testing and if a remaining bug is > discovered, then when we correct the bug in both of them by just > cherry-picking from master to libreoffice-3-5 in future. It has the > disadvantage that, well, more invasive change close to > release. <shrug>
because i'm tired now i found this one much easier to review, and pushed it to libreoffice-3-5-0 :) >> From 19ef5bcc8d9dbcf965f79495e1afd86ac0f22c31 Mon Sep 17 00:00:00 2001 >> From: Lionel Elie Mamane <lio...@mamane.lu> >> Date: Tue, 24 Jan 2012 22:21:41 +0100 >> Subject: [PATCH] use proper sizes for SQL(Get|Set)StmtAttr > >> Fixes fdo#34432 (driver smashes our stack) > >> Continuation of >> commit 9a466d9718cceeb4ace9e3352a173c7b62387eee >> Author: Lionel Elie Mamane <lio...@mamane.lu> >> Date: Tue Nov 29 17:49:36 2011 +0100 > >> ODBC: use right integer length to get Statement Options > > > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
