https://bugs.freedesktop.org/show_bug.cgi?id=35673
Kohei Yoshida changed:
What|Removed |Added
Depends on|32826 |
--
Configure bugmail: https://bugs.fre
Regain in size and win your woman's awareness http://norlander.nl/cv5ahasb.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Caolan,
I tried to build libreoffice but got error in svx.
/home/ubuntu/git/gsoc/svx/source/unodraw/unoshap2.cxx: In constructor
‘SvxShapeGroup::SvxShapeGroup(SdrObject*, SvxDrawPage*)’:
/home/ubuntu/git/gsoc/svx/source/unodraw/unoshap2.cxx:104: error:
‘stderr’ was not declared in this scope
/
On Fri, 2011-05-20 at 22:25 +0200, Andras Timar wrote:
> Hi,
>
> Please review and push to 3-4 and 3-4-0. Trivial cosmetic fix.
Beautifully done. I pushed this to -3-4 with my sign off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOff
Hi,
Please review and push to 3-4 and 3-4-0. Trivial cosmetic fix.
Thanks,
Andras
>From 1abdbc1db5d8620455ee7e29594f2777423642e9 Mon Sep 17 00:00:00 2001
From: Andras Timar
Date: Fri, 20 May 2011 22:21:40 +0200
Subject: [PATCH] fdo#37418, fix a layout problem in Export text (CSV) dialog
---
sc
Hi Matus,
On Fri, 2011-05-20 at 19:17 +0200, Matúš Kukan wrote:
> so I hope everything is prepared to move commandimages.
> - I will duplicate one problematic image into res/
> - change a little packimages makefile
> - and replace all 'res/commandimagelist' strings with 'cmd'
Sounds good
2011/5/20 Cedric Bosdonnat :
> Hi all,
>
> I just fixed some UI problem with CTL. Could you please review the fix,
> sign it off and push it?
>
> The problem that may appear here is that I needed to reduce the
> available space for some strings. I'm not sure it fits for all locales
> thought it sho
Hi there,
so I hope everything is prepared to move commandimages.
- I will duplicate one problematic image into res/
- change a little packimages makefile
- and replace all 'res/commandimagelist' strings with 'cmd'
On 8 May 2011 17:13, Andras Timar wrote:
> Hi Matus,
> 2011.05.08. 11:24 keltezés
On Fri, 2011-05-20 at 12:20 -0400, Kohei Yoshida wrote:
> and I'm having hard time coming up with a good filter rule in Evolution
> to include all of these. Evolution doesn't support regexp search which
> also adds to the difficulty.
Ah, never mind. You can choose to include all mails in the th
On Fri, 2011-05-20 at 18:46 +0200, Petr Mladek wrote:
> Kohei Yoshida píše v St 18. 05. 2011 v 00:02 -0400:
> > On Tue, 2011-05-17 at 23:21 -0430, Rafael Dominguez wrote:
> > > Fix accessing vector out of its boundaries preventing possible crash,
> > > this is for 3.4 branch and master.
> >
> > Lo
Kohei Yoshida píše v St 18. 05. 2011 v 00:02 -0400:
> On Tue, 2011-05-17 at 23:21 -0430, Rafael Dominguez wrote:
> > Fix accessing vector out of its boundaries preventing possible crash,
> > this is for 3.4 branch and master.
>
> Looks good. Pushed to master, and to -3-4 branch with my sign-off.
On Fri, 2011-05-20 at 12:11 -0400, Kohei Yoshida wrote:
> On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
>
> > Not marked as a mostly annoying bug, but it is a crasher, so perhaps
> >
On Fri, 2011-05-20 at 10:45 +0200, Jan Holesovsky wrote:
> Hi all,
>
> I've seen some patches that were reviewed, but not pushed into the -3-4
> branch (!!!), so just to remind you:
>
> - the first reviewer pushes to libreoffice-3-4 (commits/cherry-picks
> with -s to get the Signed-off-by: mess
On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
> Not marked as a mostly annoying bug, but it is a crasher, so perhaps
> should be cherry-picked to the -3-4 or even -3-4-0 branches?
if
On Fri, 2011-05-20 at 11:33 -0400, Kohei Yoshida wrote:
> The patch looks good. You have my review & pushed to the -3-4 branch.
I forgot to say it would be nice to push this to the 3-4-0 branch as
well. It needs two more sign-off's.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
On Fri, 2011-05-20 at 13:22 +0200, Markus Mohrhard wrote:
> Hello all,
>
> here is my second patch for the bugs related to the autofilter.
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=e1d6a1c542ca2b21f11c581fa6e4be6235deb3af
> Autofilters disappeared if a sheet was deleted or inserte
On Thu, 2011-05-19 at 16:54 +0100, Michael Meeks wrote:
> To avoid a NULL pointer de-reference, don't de-reference a null
> pointer :-) I'd like to get this into 3.4.0
Looks sane to me. You have a third. The bracket style is not what we
normally use in this code base though. I don't know
Hi all,
Some people complained about LO not producing valid ODF files. Here is a
hack that silences the validator for problems mentioned by fdo#37390
(the missing manifest:version was fixed quite a while ago).
Drawback of the change: people actually using the grid may have loose
that setting when
On Fri, 2011-05-20 at 05:48 +0200, Markus Mohrhard wrote:
> so now a reworked patch. It only fixes the problem that the global
> anonymous db data was imported to the subtotal database range even if
> it should have been mapped to the sheet local db data.
>
> It would still be nice to get this in
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Rainer Bielefeld changed:
What|Removed |Added
Depends on||37030
--- Comment #114 from Rainer Bi
Hi KAMI,
On Fri, 2011-05-20 at 14:44 +0200, Kálmán „KAMI” Szalai wrote:
> Yesterday issued ./g -f pull -r command and all repos updated. I "make
> clean"-ed sw module and rebuilded it. with same fail. after that I did
> "make clean" but I have this error. How can I check if my repos are
> up-to-da
Hi,
On 2011-05-20 at 15:30 +0100, Michael Meeks wrote:
> > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16
> > >
> > > to 3-4 and even 3-4-0. As the commit log says, we have changed the size
> > > of
> > > small capitals font effect and thi
On Fri, 2011-05-20 at 15:30 +0100, Michael Meeks wrote:
> On Fri, 2011-05-20 at 15:33 +0200, Cedric Bosdonnat wrote:
> > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16
> > >
> > > to 3-4 and even 3-4-0. As the commit log says, we have changed
Hi all,
I just fixed some UI problem with CTL. Could you please review the fix,
sign it off and push it?
The problem that may appear here is that I needed to reduce the
available space for some strings. I'm not sure it fits for all locales
thought it should be OK.
Thanks,
--
Cédric Bosdonnat
L
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Petr Mladek changed:
What|Removed |Added
Depends on||37390
--
Configure bugmail: https://bugs.
Please, see here, that the patch actually added 1 line:
http://svn.services.openoffice.org/opengrok/diff/DEV300_m106/basctl/source/basicide/baside2b.cxx?r2=%2FDEV300_m106%2Fbasctl%2Fsource%2Fbasicide%2Fbaside2b.cxx%40275666%3Ad11c441ed074&r1=%2FDEV300_m106%2Fbasctl%2Fsource%2Fbasicide%2Fbaside2b.c
Hi Christian,
On Tue, 2011-05-10 at 23:25 +0200, Christian Lohmaier wrote:
> It uses SvStream, and also has the stream set to little endian, but
> then doesn't make use of the SvStream's read operations (that would
> take care of bigendian → littleendian conversion, but manually reads
;-)
On Tue, 2011-05-10 at 13:01 +0200, Jacek Wolszczak wrote:
> Attached hereto are 3 patches:
For book-keeping, these seem to have been merged a while ago ;-)
Thanks Jacek !
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
___
On Friday 20 of May 2011, Kálmán „KAMI” Szalai wrote:
> Hi,
>
>
> Yesterday issued ./g -f pull -r command and all repos updated. I "make
> clean"-ed sw module and rebuilded it. with same fail. after that I did
> "make clean" but I have this error. How can I check if my repos are
> up-to-date? I use
On Fri, 2011-05-20 at 15:33 +0200, Cedric Bosdonnat wrote:
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16
> >
> > to 3-4 and even 3-4-0. As the commit log says, we have changed the size of
> > small capitals font effect and this can break
Forgot to add: A regression example is Bug 37405 – Undo is broken in
Basic IDE
https://bugs.freedesktop.org/show_bug.cgi?id=37405
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eilidh,
Pushed to libvisio. Thanks.
On Fri, 2011-05-20 at 14:12 +0100, Tibby Lickle wrote:
> First patch for libvisio, I'm not used to external code review on my
> C++ code so be as harsh as you need to be.
Nah, I want to be nice in the beginning. You never boil a frog by
throwing it into a boi
Giving you first signoff and pushing to 3-4
Fridrich
On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
>
> A proper fix would be to make sure the code doesn't even get into a
> situa
On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
Pushed to libreoffice-3-4 :-)
Thanks,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, it
I suggest to review the last change to baside2b.cxx on master, because
this doesn't fix anything and causes regressions. At last, all previous
changes to that file such as code cleanup and translations were removed
by this last patch.
Please, look at the history:
http://opengrok.libreoffice.or
Bring more enjoyment to your life, get a magicpil!
http://activess.net/2a3b2a3.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hah,
Ignore my previous slightly sharp mail wrt. testing - I had forgotten
you're doing all this great marketing research & work :-)
On Fri, 2011-05-20 at 09:07 -0400, Marc Paré wrote:
> The object of this exercise is to see if we could have the release
> notes, on the website page, rele
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 36915, which changed state.
Bug 36915 Summary: Beanshell scripts don't work
https://bugs.freedesktop.org/show_bug.cgi?id=36915
What|Old Value |New Value
--
Hi Marc,
On Fri, 2011-05-20 at 09:22 -0400, Marc Paré wrote:
> I was just on the usenet openoffice group and this bug was mentioned as
> being a problem with people working on larger files. As this seems to
> have been fixed in the upcoming 3.4 version of OpenOffice I was
> wondering if it was
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
A proper fix would be to make sure the code doesn't even get into a situation
where it feels the need to try to use elements in an empty vector, but
whatever...
Not marked as a mostly annoying
On Fri, 2011-05-20 at 15:38 +0200, Cedric Bosdonnat wrote:
> On Fri, 2011-05-20 at 09:22 -0400, Marc Paré wrote:
> > I was just on the usenet openoffice group and this bug was mentioned as
> > being a problem with people working on larger files. As this seems to
> > have been fixed in the upcomin
On Fri, 2011-05-20 at 09:22 -0400, Marc Paré wrote:
> I was just on the usenet openoffice group and this bug was mentioned as
> being a problem with people working on larger files. As this seems to
> have been fixed in the upcoming 3.4 version of OpenOffice I was
> wondering if it was integrated
On Fri, 2011-05-20 at 15:05 +0200, Lubos Lunak wrote:
> Hello,
>
> I would like to backport
> http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16
>
> to 3-4 and even 3-4-0. As the commit log says, we have changed the size of
> small capitals font
On Wed, 2011-04-27 at 19:55 -0400, Peter Teeson wrote:
> Both OpenOffice 3.3.0 and LibreOffice 3.3.2 exhibit this behaviour.
> Steps to reproduce:
> (0) Launch either app
> (1) New spreadsheet
> (2) Format/Cells...
> Crash!
This will almost certainly turn out to be triggered by a specific fo
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 37015, which changed state.
Bug 37015 Summary: Scripting other than Basic unavailable
https://bugs.freedesktop.org/show_bug.cgi?id=37015
What|Old Value |New Value
I was just on the usenet openoffice group and this bug was mentioned as
being a problem with people working on larger files. As this seems to
have been fixed in the upcoming 3.4 version of OpenOffice I was
wondering if it was integrated into our latest upcoming version of
LibreOffice.
It seem
Hi,
First patch for libvisio, I'm not used to external code review on my
C++ code so be as harsh as you need to be.
E.
From b8f734c46d7bbcdfb155dba92048c7f7440986bf Mon Sep 17 00:00:00 2001
From: Tibby Lickle
Date: Fri, 20 May 2011 13:58:44 +0100
Subject: [PATCH] implementation of isSupported fo
Hi Michael et al
It was suggested during the confcall that we should perhaps concentrate
on this issue on the mailing list. I think that the idea is that members
on the projects list are prepared to expedite issues here a little more
quickly than on the other lists.
The object of this exerci
Hello,
I would like to backport
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee52672e77c6e5fe601d0ed3c416a60b16
to 3-4 and even 3-4-0. As the commit log says, we have changed the size of
small capitals font effect and this can break layout of documents that rely
on the o
Hi,
Yesterday issued ./g -f pull -r command and all repos updated. I "make
clean"-ed sw module and rebuilded it. with same fail. after that I did
"make clean" but I have this error. How can I check if my repos are
up-to-date? I used status for it. I will try with LibreOfficeLinux
distro. Is it pr
Hi,
Sorry for the delay I a bit overloaded my daily work. What should we
check first if this extension works with vanilla LibreOffice? Can you
install and test its functionality. I committed all patches to master
what I pushed to 3-4.
Best regards,
KAMI
05/20/2011 02:28 PM keltezéssel, Alexander
On Wed, 2011-05-18 at 20:51 +0100, Michael Meeks wrote:
> Hi David,
>
> On Wed, 2011-05-18 at 12:22 +0200, David Tardon wrote:
> > Caolan fixed similar build problem in Fedora some time ago. Does the
> > attached patch allow you finish the build?
>
> Urk - I guess we should have that in mas
Darn, I forgot to mention that it does actually get downloaded now with
the appropriate autogen switch and successive make, but it doesn't work
when built on a master build, unless it has been fixed since then by
someone (not me, thats for sure). The menu entries are there, they just
don't do anyth
Hi Michael,
Le 20/05/11 13:30, Michael Meeks a écrit :
> Hi Alex,
>
> On Tue, 2011-05-10 at 12:30 +0200, Alexander Thurgood wrote:
>> So I grepped, but am at a loss to understand what happened, other than
>> that the extension appears to have been deactivated in some of the
>> distro-config files,
It's related to this bug:
http://openoffice.org/bugzilla/show_bug.cgi?id=115297
However, don't use the attachments on the bug-report, they are wrong.
2011/5/20 Knut Olav Bøhmer
>
> 2011/5/20 Knut Olav Bøhmer
>
>> Hi,
>>
>> Exporting hyperlinks to .doc is done wrong in LibreOffice Writer. The
On Fri, May 20, 2011 at 6:05 AM, Noel Power wrote:
> I really wish to stress the 'learn' aspect because I think reviews are a key
> way for people to learn about the code ( no joke I think I learn something
> new every day on this list from the reviews that I read ) imho we should
> make it as ea
2011/5/20 Knut Olav Bøhmer
> Hi,
>
> Exporting hyperlinks to .doc is done wrong in LibreOffice Writer. There is
> a flag (hlstmfIsAbsolute) that is set to 1. It should be 0, because all
> links are exported relative.
>
>
My patch is tested in OpenOffice.org 3.2.1
<-cut->
> Anyway, this is very
Hi,
Exporting hyperlinks to .doc is done wrong in LibreOffice Writer. There is a
flag (hlstmfIsAbsolute) that is set to 1. It should be 0, because all links
are exported relative.
Before I make a patch, give me input on this.
B - hlstmfIsAbsolute (1 bit): A bit that specifies whether this hyper
Hi Alex,
On Tue, 2011-05-10 at 12:30 +0200, Alexander Thurgood wrote:
> So I grepped, but am at a loss to understand what happened, other than
> that the extension appears to have been deactivated in some of the
> distro-config files, and yet it is still listed as an extension in scp2 :
H
Hi there,
On Sat, 2011-05-14 at 12:35 +0400, LRN wrote:
> This bug is almost 4-years old -
> http://openoffice.org/bugzilla/show_bug.cgi?id=78701
Ho hum; so I read the bug, and I read the code - and I removed bogus
class, and a superstitious mis-understanding of the visibility
annotatio
Hello all,
here is my second patch for the bugs related to the autofilter.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=e1d6a1c542ca2b21f11c581fa6e4be6235deb3af
Autofilters disappeared if a sheet was deleted or inserted because we
forgot to update the db data.
Otherwise the db data sti
On 20/05/11 08:27, Cedric Bosdonnat wrote:
Hi all,
Sorry, I couldn't join yesterday. I'm just wondering where the
reviewboard action item went? is that a dropped idea or does it still
deserves some action?
I meant to say something when this was originally floated but got
distracted. I think the
Hi John,
On Mon, 2011-05-16 at 12:05 +1200, John Gillanders wrote:
> What I am actually trying to achieve is a way to hook into events in
> OpenOffice so that I am able to catch all edits that a user does to a
> Writer document and do something with the related information (I need
> to receive the
> All versions I have installed on the previous. I use more
> languages than Polish and English -
And you do mean user interface languages, right? (Those languages are what are
automatically selected (or actually de-selected) on installation. Don't confuse
with languages for which writing ai
Hi Robert,
On 2011-05-20 at 12:30 +0200, Robert Dargaud wrote:
> This short message to give a file with datapilot who crash LibO 3.4RC1.
>
> ooo.bobiciel.com/tests_documents/testLibO_34rc1_proto_time_line_pour_defauts.ods
>
> On the second sheet :
> Clic on A2 ==> crash
> Or right clic on A2 /
On Thu, May 19, 2011 at 12:52:41PM +0200, Cedric Bosdonnat
wrote:
> As you'll work on the tokenizer, I think it would be nice to introduce
> some kind of tokens dumper replacing the dmapper that would dump what
> goes in the dmapper. That would possibly provide some way to isolate
> whether the i
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 36613, which changed state.
Bug 36613 Summary: LO 3.4 Beta 2 - Hover over icons produces the wrong behavior
https://bugs.freedesktop.org/show_bug.cgi?id=36613
What|Old Value |New Value
--
> Looks fine to me. We should of course try to fix it in a pleasant way
> on master ;-) and I love that:
Did that, now it is called nHighlight and not assigned (or passed) any
sal_False or sal_True values, but integers.
--tml
___
LibreOffice mailing
W dniu 2011-05-20 01:23, Thorsten Behrens pisze:
Please be aware that LibreOffice 3.4 RC1 is not yet
ready for production use, you should continue to use LibreOffice 3.3.2
for that.
The release is available for Windows, Linux and Mac OS X from our QA
builds download page at
Hi,
This short message to give a file with datapilot who crash LibO 3.4RC1.
ooo.bobiciel.com/tests_documents/testLibO_34rc1_proto_time_line_pour_defauts.ods
On the second sheet :
Clic on A2 ==> crash
Or right clic on A2 / refresh ==> crash
Same bug on WinXP SP3 and MacOX 10.6
No problem with
Hi,
On 2011-05-20 at 11:04 +0100, Noel Power wrote:
> > I prefer Michael's version, so +1 for that ( although I don't agree
> > with the ugly comment, to me it shows the intentional bypassing of the
> > dynamic binding )
> > ___
> I committed that version to 3.4 branch, I'm sorry I forgot t
On Fri, 2011-05-20 at 03:17 -0600, Tor Lillqvist wrote:
> --- a/vcl/source/window/toolbox.cxx
> +++ b/vcl/source/window/toolbox.cxx
> @@ -3494,7 +3494,8 @@ void ToolBox::ImplDrawItem( sal_uInt16 nPos, sal_Bool
> bHighlight, sal_Bool bPain
> MetricVector* pVector = bLayout ?
> &mpData->m_pLa
Signed off and pushed to libreoffice-3-4-0 branch
f.
On Fri, 2011-05-20 at 03:33 -0600, Tor Lillqvist wrote:
> >> sal_uInt16 bHighlight = sal_False
> >
> > I think this should become sal_uInt16 bHighlight = 0, or even
> > nHighlight; the 'b' prefix suggests it is a bool [and it is not ;-)]
>
>
On 20/05/11 10:43, Noel Power wrote:
On 20/05/11 10:02, Michael Meeks wrote:
I prefer Michael's version, so +1 for that ( although I don't agree
with the ugly comment, to me it shows the intentional bypassing of the
dynamic binding )
___
I committed that version to 3.4 branch, I'm sorry
On 20/05/11 10:02, Michael Meeks wrote:
Weelll ... it seems that (for all its ugliness) the more common way of
doing this inside button.cxx's draw code (cf. ImplDrawPushButtonFrame)
seems to be this:
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index c77d14
>> sal_uInt16 bHighlight = sal_False
>
> I think this should become sal_uInt16 bHighlight = 0, or even
> nHighlight; the 'b' prefix suggests it is a bool [and it is not ;-)]
Good point, will do that in master. Actually I think I would prefer to use an
enum even for the three apparently intended
Hi Lucas,
On 2011-05-19 at 21:53 +0200, xapantu wrote:
> sal_uInt16 bHighlight = sal_False
I think this should become sal_uInt16 bHighlight = 0, or even
nHighlight; the 'b' prefix suggests it is a bool [and it is not ;-)]
Tor - when you are pushing this, can you please update it?
[Actually - t
On Thu, 2011-05-19 at 12:31 -0500, Norbert Thiebaud wrote:
> > I just fixed another blocker for 3.4. Can you please review and push it?
> +1
Pushed to 3.4.0
Thanks guys,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
Your patch(es) fixed the problem on Windows, too, as far as I could see. Pushed
to master. Thanks!
For 3-4 and 3-4-0, I think we should do only this hunk:
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -3494,7 +3494,8 @@ void ToolBox::ImplDrawItem( sal_uInt16 nPos, sa
Hi Kohei,
On Fri, 2011-05-20 at 00:45 -0400, Kohei Yoshida wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=36690
>
> and I would like to push this to the -3-4 branch and possibly to the
> -3-4-0 branch as well. The patch is against vcl.
..
> Calc races during print preview when the sheet c
Hi Radek,
On 2011-05-19 at 18:04 +0200, Radek Doulík wrote:
> I would like to push fixes for pptx export for 3-4 and 3-4-0 branches.
> The pptx export is currently broken as the export component is not
> instantiated.
>
> I am looking for 3 reviews. It has 5 parts, 3 of them are cherry-picks
> f
> It was due to a cast between sal_Bool and sal_uInt16.
Excellent work discovering this example of horrible coding. Will commit (unless
somebody beats me to it) once I have verified that it fixes the problem on
Windows, too.
--tml
___
LibreOffice ma
Hi all,
I've seen some patches that were reviewed, but not pushed into the -3-4
branch (!!!), so just to remind you:
- the first reviewer pushes to libreoffice-3-4 (commits/cherry-picks
with -s to get the Signed-off-by: message automatically)
- the third reviewer cherry-picks the commit(s) fro
On Thu, 2011-05-19 at 16:54 +0100, Michael Meeks wrote:
> To avoid a NULL pointer de-reference, don't de-reference a null
> pointer :-) I'd like to get this into 3.4.0
Ok for me too.
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http
On 19/05/11 16:54, Michael Meeks wrote:
To avoid a NULL pointer de-reference, don't de-reference a null
pointer :-) I'd like to get this into 3.4.0
Thanks,
Michael.
looks sane to me +1
___
LibreOffice mailing list
Libr
On Thu, 2011-05-19 at 20:12 +, Markus Mohrhard wrote:
> I think this patch is fine too. So if my sign counts you have a second.
Of course ! :-) we love to get reviews from people with your level of
expertise, it is most healthy. The question post RC1 is: will it crash
and/or cause mor
On Thu, 2011-05-19 at 20:37 +0200, Julien Nabet wrote:
> Argh ! I had just missed this operator. I should have waited for the
> next day before sending this mail :-)
Heh :-)
> > Or did I miss something ? presumably another cppcheck false-positive
> > that needs filing& fixing (?).
> To avoid a NULL pointer de-reference, don't de-reference a null
> pointer :-) I'd like to get this into 3.4.0
You've my '+1 '
frozenB.
--
\ Katarina Machalkova
\\\__o LibO developer
__\\\'/_ & hedgehog painter
signature.asc
Description
Hi Michael,
On 2011-05-19 at 16:54 +0100, Michael Meeks wrote:
> To avoid a NULL pointer de-reference, don't de-reference a null
> pointer :-) I'd like to get this into 3.4.0
Sure, looks good :-) Reviewed and pushed to libreoffice-3-4, 2 more
needed to cherry-pick that to libreoffice-3-4.
On Fri, 2011-05-20 at 00:47 -0600, Tor Lillqvist wrote:
> Why not let the bleeping computer do the sorting the first time the
> list is used? Proper division of labour between programmer and
> computer is nice.
Hey ho :-) well, ideally we could do compile-time sorting, so we don't
have to
On Fri, 20 May 2011 09:27:21 +0200
Cedric Bosdonnat
wrote:
> Hi all,
>
> Sorry, I couldn't join yesterday. I'm just wondering where the
> reviewboard action item went? is that a dropped idea or does it still
> deserves some action?
Still to be done, but wont be done next week.
Best,
Bjoern
-
> Then it may be better to change that algorithm into something more
> readable and not requiring the list to be sorted?
Something like gperf? Might be overkill, lots of work that I think might need
plenty of iterations in setting up the makefilery? Much work for little (?)
gain. But of course t
Last review is from me. I got similar mess in writerperfect once :)
F.
On 19/05/11 21:30, Michael Meeks wrote:
On Thu, 2011-05-19 at 18:04 +0200, Radek Doulík wrote:
I am looking for 3 reviews. It has 5 parts, 3 of them are cherry-picks
from master and 2 additional are necessary because build
Hi all,
Sorry, I couldn't join yesterday. I'm just wondering where the
reviewboard action item went? is that a dropped idea or does it still
deserves some action?
On Thu, 2011-05-19 at 18:13 +0100, Michael Meeks wrote:
> Attending:
> Thorsten, Andras, Kendy, Norbert, Christian, Petr,
>
On Fri, 2011-05-20 at 00:47 -0600, Tor Lillqvist wrote:
> > that list is a Gotcha it needs a comment at the end of it on master saying:
> > "This list has
> > to be sorted correctly !".
>
> Why not let the bleeping computer do the sorting the first time the list is
> used? Proper division of lab
95 matches
Mail list logo
