>> sal_uInt16 bHighlight = sal_False > > I think this should become sal_uInt16 bHighlight = 0, or even > nHighlight; the 'b' prefix suggests it is a bool [and it is not ;-)]
Good point, will do that in master. Actually I think I would prefer to use an enum even for the three apparently intended possible values of bHighlight, but even that won't cause a compilation error when used illogically, enums are automatically cast to/from integral types (including sal_Bool), aren't they? > [Actually - this is a 2nd sign-off ;-)] --tml _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
