On 20/05/11 10:02, Michael Meeks wrote:

        Weelll ... it seems that (for all its ugliness) the more common way of
doing this inside button.cxx's draw code (cf. ImplDrawPushButtonFrame)
seems to be this:

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index c77d14a..6932cdb 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1522,7 +1522,7 @@ void PushButton::Draw( OutputDevice* pDev, const Point&  
rPos, const Size&  rSize,
          else
              aStyleSettings.SetFaceColor( 
GetSettings().GetStyleSettings().GetFaceColor() );
          aSettings.SetStyleSettings( aStyleSettings );
-        pDev->SetSettings( aSettings );
+        pDev->OutputDevice::SetSettings( aSettings );
      }
      pDev->SetTextFillColor();


        I'd feel happier with that personally too, it also seems to fix the
bug.

        Thanks !

                Michael.

I prefer Michael's version, so +1 for that ( although I don't agree with the ugly comment, to me it shows the intentional bypassing of the dynamic binding )
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to