Re: GSoC History plugin

2015-06-24 Thread Joshua Joseph
On Wed, Jun 24, 2015 at 1:47 PM, Pali Rohár wrote: > On Wednesday 24 June 2015 13:40:51 Joshua Joseph wrote: > > On Wed, Jun 24, 2015 at 1:25 PM, Pali Rohár > wrote: > > > > > On Wednesday 24 June 2015 12:28:29 Joshua Joseph wrote: > > > > On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár > > > wrot

Re: GSoC History plugin

2015-06-24 Thread Pali Rohár
On Wednesday 24 June 2015 13:40:51 Joshua Joseph wrote: > On Wed, Jun 24, 2015 at 1:25 PM, Pali Rohár wrote: > > > On Wednesday 24 June 2015 12:28:29 Joshua Joseph wrote: > > > On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár > > wrote: > > > > > > > On Wednesday 24 June 2015 11:40:14 Joshua Joseph

Re: GSoC History plugin

2015-06-24 Thread Joshua Joseph
On Wed, Jun 24, 2015 at 1:25 PM, Pali Rohár wrote: > On Wednesday 24 June 2015 12:28:29 Joshua Joseph wrote: > > On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár > wrote: > > > > > On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > > > > Hi > > > > > > > > On Mon, Jun 22, 2015 at 1:27 PM, Pal

Re: GSoC History plugin

2015-06-24 Thread Pali Rohár
On Wednesday 24 June 2015 12:28:29 Joshua Joseph wrote: > On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár wrote: > > > On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > > > Hi > > > > > > On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár > > wrote: > > > > > > > > > > > > > > > > Then post your i

Re: GSoC History plugin

2015-06-24 Thread Joshua Joseph
On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár wrote: > On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > > Hi > > > > On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár > wrote: > > > > > > > > > > > > Then post your interface for review and comments. > > > > > > See it here: > > > https://githu

Re: GSoC History plugin

2015-06-24 Thread Pali Rohár
On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > Hi > > On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár wrote: > > > > > > > > Then post your interface for review and comments. > > > > See it here: > https://github.com/josh-wambua/kopete/blob/database_helper/plugins/history3/databasehelper.

Re: GSoC History plugin

2015-06-24 Thread Joshua Joseph
Hi On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár wrote: > > > > Then post your interface for review and comments. > > See it here: https://github.com/josh-wambua/kopete/blob/database_helper/plugins/history3/databasehelper.h > -- > Pali Rohár > pali.ro...@gmail.com > _

Re: GSoC History plugin

2015-06-22 Thread Pali Rohár
On Monday 22 June 2015 12:53:08 Joshua Joseph wrote: > On Sat, Jun 20, 2015 at 6:21 PM, Pali Rohár wrote: > > > > > > Joshua > > > > Ok, looks good. Maybe also timestamp and message should not be null... > > > > Now to implement it! > > > > > Yes...I am now working on the Db classes. > Then pos

Re: GSoC History plugin

2015-06-22 Thread Joshua Joseph
On Sat, Jun 20, 2015 at 6:21 PM, Pali Rohár wrote: > > > Joshua > > Ok, looks good. Maybe also timestamp and message should not be null... > > Now to implement it! > > Yes...I am now working on the Db classes. > -- > Pali Rohár > pali.ro...@gmail.com > >

Re: GSoC History plugin

2015-06-21 Thread Pali Rohár
On Sunday 21 June 2015 18:44:02 m...@jtalk.me wrote: > Why would you use TEXT type for internal identifiers? Integral > indices are way more effective for selection. > It means to store full protocol dependent identifier. For jabber it would be full JID (with resource) which is string property,

Re: GSoC History plugin

2015-06-21 Thread me
Why would you use TEXT type for internal identifiers? Integral indices are way more effective for selection. 20.06.2015, 20:21, "Pali Rohár" : > On Saturday 20 June 2015 17:07:06 Joshua Joseph wrote: >>  On Sat, Jun 20, 2015 at 5:35 PM, Pali Rohár >>  wrote: >>  > On Saturday 20 June 2015 16:31

Re: GSoC History plugin

2015-06-20 Thread Pali Rohár
On Saturday 20 June 2015 17:07:06 Joshua Joseph wrote: > On Sat, Jun 20, 2015 at 5:35 PM, Pali Rohár > wrote: > > On Saturday 20 June 2015 16:31:50 Joshua Joseph wrote: > > > On Sat, Jun 20, 2015 at 5:22 PM, Pali Rohár > > > > > > > wrote: > > > > On Saturday 20 June 2015 15:56:05 Joshua Joseph

Re: GSoC History plugin

2015-06-20 Thread Joshua Joseph
On Sat, Jun 20, 2015 at 5:35 PM, Pali Rohár wrote: > On Saturday 20 June 2015 16:31:50 Joshua Joseph wrote: > > On Sat, Jun 20, 2015 at 5:22 PM, Pali Rohár > wrote: > > > On Saturday 20 June 2015 15:56:05 Joshua Joseph wrote: > > > > On Sat, Jun 20, 2015 at 4:38 PM, Pali Rohár > > > > > > > > >

Re: GSoC History plugin

2015-06-20 Thread Pali Rohár
On Saturday 20 June 2015 16:31:50 Joshua Joseph wrote: > On Sat, Jun 20, 2015 at 5:22 PM, Pali Rohár wrote: > > On Saturday 20 June 2015 15:56:05 Joshua Joseph wrote: > > > On Sat, Jun 20, 2015 at 4:38 PM, Pali Rohár > > > > > > > > > wrote: > > > > > I had not thought of that. :) > > > > > >

Re: GSoC History plugin

2015-06-20 Thread Joshua Joseph
On Sat, Jun 20, 2015 at 5:22 PM, Pali Rohár wrote: > On Saturday 20 June 2015 15:56:05 Joshua Joseph wrote: > > On Sat, Jun 20, 2015 at 4:38 PM, Pali Rohár > > wrote: > > > > I had not thought of that. :) > > > > > > > > > Same for Contact: Does not it make sense to store > > > > > Kopete::Conta

Re: GSoC History plugin

2015-06-20 Thread Pali Rohár
On Saturday 20 June 2015 15:56:05 Joshua Joseph wrote: > On Sat, Jun 20, 2015 at 4:38 PM, Pali Rohár > wrote: > > > I had not thought of that. :) > > > > > > > Same for Contact: Does not it make sense to store > > > > Kopete::Contact representing room? Or do you think it is not > > > > needed at

Re: GSoC History plugin

2015-06-20 Thread Joshua Joseph
On Sat, Jun 20, 2015 at 4:38 PM, Pali Rohár wrote: > > > > > I had not thought of that. :) > > > > > Same for Contact: Does not it make sense to store Kopete::Contact > > > representing room? Or do you think it is not needed at all? > > > > Yes. I will change to Kopete::Contact. > > > > I think yo

Re: GSoC History plugin

2015-06-20 Thread Pali Rohár
On Saturday 20 June 2015 15:22:52 Joshua Joseph wrote: > On Fri, Jun 19, 2015 at 7:03 PM, Pali Rohár > wrote: > > On Friday 19 June 2015 16:54:57 Joshua Joseph wrote: > > > On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár > > > > > > > wrote: > > > > On Friday 19 June 2015 09:59:17 Joshua Joseph wro

Re: GSoC History plugin

2015-06-20 Thread Joshua Joseph
On Fri, Jun 19, 2015 at 7:03 PM, Pali Rohár wrote: > On Friday 19 June 2015 16:54:57 Joshua Joseph wrote: > > On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár > wrote: > > > > > On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: > > > > On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár > > > wrote: >

Re: GSoC History plugin

2015-06-19 Thread Pali Rohár
On Friday 19 June 2015 16:54:57 Joshua Joseph wrote: > On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár wrote: > > > On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: > > > On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár > > wrote: > > > > > > > > > > > > I get it now. > > > > > > > > > > We will ha

Re: GSoC History plugin

2015-06-19 Thread Joshua Joseph
On Fri, Jun 19, 2015 at 10:33 AM, Pali Rohár wrote: > On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: > > On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár > wrote: > > > > > > > > > I get it now. > > > > > > > > We will have to store the contactId() also. I will need to get good > > > > column

Re: GSoC History plugin

2015-06-19 Thread Pali Rohár
On Friday 19 June 2015 09:59:17 Joshua Joseph wrote: > On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár wrote: > > > > > > I get it now. > > > > > > We will have to store the contactId() also. I will need to get good > > > column names > > > to avoid confusion with the foreign key columns. > > > > >

Re: GSoC History plugin

2015-06-19 Thread Joshua Joseph
On Thu, Jun 18, 2015 at 10:07 PM, Pali Rohár wrote: > > > I get it now. > > > > We will have to store the contactId() also. I will need to get good > > column names > > to avoid confusion with the foreign key columns. > > > > See my yesterday email where I proposed to store pluginId() as protocol

Re: GSoC History plugin

2015-06-18 Thread Pali Rohár
On Thursday 18 June 2015 20:21:42 Joshua Joseph wrote: > On Thu, Jun 18, 2015 at 8:59 PM, Pali Rohár > wrote: > > > I intended for the account field to be protocol > > > dependant, as you had said earlier, so that jabber can store full > > > JID. > > > > But then you cannot show history! You will

Re: GSoC History plugin

2015-06-18 Thread Joshua Joseph
On Thu, Jun 18, 2015 at 8:59 PM, Pali Rohár wrote: > > > > > I intended for the account field to be protocol > > dependant, as you had said earlier, so that jabber can store full > > JID. > > > > But then you cannot show history! You will get Kopete::Acount::accountId > and you cannot match anyth

Re: GSoC History plugin

2015-06-18 Thread Pali Rohár
On Thursday 18 June 2015 15:57:45 Joshua Joseph wrote: > On Thu, Jun 18, 2015 at 1:35 PM, Pali Rohár > wrote: > > On Thursday 18 June 2015 10:58:36 Joshua Joseph wrote: > > > On Wed, Jun 17, 2015 at 5:27 PM, Pali Rohár > > > > > > > wrote: > > > > On Wednesday 17 June 2015 14:20:05 Pali Rohár wr

Re: GSoC History plugin

2015-06-18 Thread Joshua Joseph
On Thu, Jun 18, 2015 at 1:35 PM, Pali Rohár wrote: > On Thursday 18 June 2015 10:58:36 Joshua Joseph wrote: > > On Wed, Jun 17, 2015 at 5:27 PM, Pali Rohár > wrote: > > > > > On Wednesday 17 June 2015 14:20:05 Pali Rohár wrote: > > > > On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > >

Re: GSoC History plugin

2015-06-18 Thread Pali Rohár
On Thursday 18 June 2015 10:58:36 Joshua Joseph wrote: > On Wed, Jun 17, 2015 at 5:27 PM, Pali Rohár wrote: > > > On Wednesday 17 June 2015 14:20:05 Pali Rohár wrote: > > > On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > > > > > And for handling problem with jabber resource now I got th

Re: GSoC History plugin

2015-06-18 Thread Joshua Joseph
On Wed, Jun 17, 2015 at 5:27 PM, Pali Rohár wrote: > On Wednesday 17 June 2015 14:20:05 Pali Rohár wrote: > > On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > > > > And for handling problem with jabber resource now I got this idea: > > > > > > > > What about storing this? > > > > * proto

Re: GSoC History plugin

2015-06-17 Thread Joshua Joseph
On Wed, Jun 17, 2015 at 5:27 PM, Pali Rohár wrote: > On Wednesday 17 June 2015 14:20:05 Pali Rohár wrote: > > On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > > > > And for handling problem with jabber resource now I got this idea: > > > > > > > > What about storing this? > > > > * proto

Re: GSoC History plugin

2015-06-17 Thread Pali Rohár
On Wednesday 17 June 2015 14:20:05 Pali Rohár wrote: > On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > > > And for handling problem with jabber resource now I got this idea: > > > > > > What about storing this? > > > * protocol > > > * account > > > * contact > > > * from_id > > > * to_id

Re: GSoC History plugin

2015-06-17 Thread Pali Rohár
On Wednesday 17 June 2015 15:11:22 Joshua Joseph wrote: > > And for handling problem with jabber resource now I got this idea: > > > > What about storing this? > > * protocol > > * account > > * contact > > * from_id > > * to_id > > * from_name > > * to_name > > > > (from|to)_id will be full protco

Re: GSoC History plugin

2015-06-17 Thread Joshua Joseph
Quick comments before I update the schema: On Wed, Jun 17, 2015 at 2:24 PM, Pali Rohár wrote: > Hi, > > still I see there couple of problems: > > 1) Why is group_type needed which just specify protocol? Protocol is > already present in messages table. > > 2) I would prefer to have integer primar

Re: GSoC History plugin

2015-06-17 Thread Pali Rohár
On Wednesday 17 June 2015 13:08:37 Joshua Joseph wrote: > Pali, > Here is an updated schema, correcting the above: > > > --Groups table: > > CREATE TABLE "groups"( > "group_id" Text NOT NULL ,--Unique identifier for the group > "description" Text , -- A human readable description of the

Re: GSoC History plugin

2015-06-17 Thread Joshua Joseph
On Wed, Jun 17, 2015 at 12:46 PM, Pali Rohár wrote: > Great, but there are missing descriptions what column means... > > > CREATE TABLE "groups"( > > "group_id" Text NOT NULL , > > "description" Text , > > "subject" Text , > > "group_type" Text > > Hm ? > > > ); > > > > > > CREATE TABLE "mess

Re: GSoC History plugin

2015-06-17 Thread Pali Rohár
On Wednesday 17 June 2015 12:40:10 Joshua Joseph wrote: > On Wed, Jun 17, 2015 at 12:19 PM, Pali Rohár wrote: > > > On Tuesday 16 June 2015 20:33:36 Joshua Joseph wrote: > > > On Tue, Jun 16, 2015 at 7:49 PM, Pali Rohár > > wrote: > > > > > > > On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrot

Re: GSoC History plugin

2015-06-17 Thread Joshua Joseph
On Wed, Jun 17, 2015 at 12:19 PM, Pali Rohár wrote: > On Tuesday 16 June 2015 20:33:36 Joshua Joseph wrote: > > On Tue, Jun 16, 2015 at 7:49 PM, Pali Rohár > wrote: > > > > > On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrote: > > > > On Tue, Jun 16, 2015 at 6:49 PM, kaushik > > > > wrote: >

Re: GSoC History plugin

2015-06-17 Thread Pali Rohár
On Tuesday 16 June 2015 20:33:36 Joshua Joseph wrote: > On Tue, Jun 16, 2015 at 7:49 PM, Pali Rohár wrote: > > > On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrote: > > > On Tue, Jun 16, 2015 at 6:49 PM, kaushik > > > wrote: > > > > @Joshua, Can you look into these things and update the readme

Re: GSoC History plugin

2015-06-16 Thread Joshua Joseph
On Tue, Jun 16, 2015 at 7:49 PM, Pali Rohár wrote: > On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrote: > > On Tue, Jun 16, 2015 at 6:49 PM, kaushik > > wrote: > > > @Joshua, Can you look into these things and update the readme > > > accordingly. Do let us know when you are done with it or ha

Re: GSoC History plugin

2015-06-16 Thread Pali Rohár
On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrote: > On Tue, Jun 16, 2015 at 6:49 PM, kaushik > wrote: > > @Joshua, Can you look into these things and update the readme > > accordingly. Do let us know when you are done with it or have any > > doubts. > > Sure Kaushik. I am working on it right

Re: GSoC History plugin

2015-06-16 Thread Pali Rohár
On Tuesday 16 June 2015 17:29:24 kaushik wrote: > On 16 June 2015 at 11:10, Pali Rohár wrote: > > On Tuesday 16 June 2015 10:54:15 kaushik wrote: > > > >> And second I still do not see how you want to handle multi > > > >> user chats correctly. You are adding session to chat message, > > > >> but

Re: GSoC History plugin

2015-06-16 Thread Joshua Joseph
On Tue, Jun 16, 2015 at 6:49 PM, kaushik wrote: > > > @Joshua, Can you look into these things and update the readme accordingly. > Do let us know when you are done with it or have any doubts. > > Sure Kaushik. I am working on it right now. > > ___ > k

Re: GSoC History plugin

2015-06-16 Thread kaushik
On 16 June 2015 at 11:29, kaushik wrote: > > > On 16 June 2015 at 11:10, Pali Rohár wrote: > >> On Tuesday 16 June 2015 10:54:15 kaushik wrote: >> > >> And second I still do not see how you want to handle multi user chats >> > >> correctly. You are adding session to chat message, but >> > >> Kop

Re: GSoC History plugin

2015-06-16 Thread kaushik
On 16 June 2015 at 11:10, Pali Rohár wrote: > On Tuesday 16 June 2015 10:54:15 kaushik wrote: > > >> And second I still do not see how you want to handle multi user chats > > >> correctly. You are adding session to chat message, but > > >> Kopete::ChatSession is not useful here. It is destroyed i

Re: GSoC History plugin

2015-06-16 Thread Pali Rohár
On Tuesday 16 June 2015 10:54:15 kaushik wrote: > >> And second I still do not see how you want to handle multi user chats > >> correctly. You are adding session to chat message, but > >> Kopete::ChatSession is not useful here. It is destroyed if you close > >> chat window, but some multi user chat

Re: GSoC History plugin

2015-06-16 Thread kaushik
On 16 June 2015 at 10:25, Joshua Joseph wrote: > > > On Tue, Jun 16, 2015 at 12:00 AM, Pali Rohár wrote: > >> .. I do not know if these messages should be >> > > logged or not. >> > >> > I think these messages (user joined, left) should be logged. They can >> > provide >> > context when someone

Re: GSoC History plugin

2015-06-16 Thread Pali Rohár
On Tuesday 16 June 2015 17:25:00 Joshua Joseph wrote: > On Tue, Jun 16, 2015 at 12:00 AM, Pali Rohár wrote: > > > .. I do not know if these messages should be > > > > logged or not. > > > > > > I think these messages (user joined, left) should be logged. They can > > > provide > > > context when

Re: GSoC History plugin

2015-06-16 Thread Joshua Joseph
On Tue, Jun 16, 2015 at 12:00 AM, Pali Rohár wrote: > .. I do not know if these messages should be > > > logged or not. > > > > I think these messages (user joined, left) should be logged. They can > > provide > > context when someone is reviewing the history later. > > > > https://github.com/jos

Re: GSoC History plugin

2015-06-15 Thread Pali Rohár
On Sunday 14 June 2015 16:36:35 Joshua Joseph wrote: > On Sun, Jun 14, 2015 at 5:25 PM, Pali Rohár wrote: > > On Sunday 14 June 2015 16:13:39 Joshua Joseph wrote: > > > On Sun, Jun 14, 2015 at 5:08 PM, Pali Rohár > > > > > > > > > wrote: > > > > Quick look at database schema: > > > > > > > > C

Re: GSoC History plugin (Was: Re: Kopete - GSoC 2015)

2015-06-14 Thread Joshua Joseph
On Sun, Jun 14, 2015 at 5:25 PM, Pali Rohár wrote: > On Sunday 14 June 2015 16:13:39 Joshua Joseph wrote: > > On Sun, Jun 14, 2015 at 5:08 PM, Pali Rohár > > wrote: > > > Quick look at database schema: > > > > > > Columns: > > > entry_id (int, primary key) > > > timestamp (text) > > > protocol (

Re: GSoC History plugin (Was: Re: Kopete - GSoC 2015)

2015-06-14 Thread Pali Rohár
On Sunday 14 June 2015 16:13:39 Joshua Joseph wrote: > On Sun, Jun 14, 2015 at 5:08 PM, Pali Rohár > wrote: > > Quick look at database schema: > > > > Columns: > > entry_id (int, primary key) > > timestamp (text) > > protocol (text) - (the protocol in use) > > direction (text) - (either incoming

Re: GSoC History plugin (Was: Re: Kopete - GSoC 2015)

2015-06-14 Thread Joshua Joseph
On Sun, Jun 14, 2015 at 5:08 PM, Pali Rohár wrote: > Quick look at database schema: > > Columns: > entry_id (int, primary key) > timestamp (text) > protocol (text) - (the protocol in use) > direction (text) - (either incoming or outgoing) > local_id (text) - (the account being used locally) > rem