On Sunday 14 June 2015 16:36:35 Joshua Joseph wrote: > On Sun, Jun 14, 2015 at 5:25 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > > On Sunday 14 June 2015 16:13:39 Joshua Joseph wrote: > > > On Sun, Jun 14, 2015 at 5:08 PM, Pali Rohár > > > <pali.ro...@gmail.com> > > > > > > wrote: > > > > Quick look at database schema: > > > > > > > > Columns: > > > > entry_id (int, primary key) > > > > timestamp (text) > > > > protocol (text) - (the protocol in use) > > > > direction (text) - (either incoming or outgoing) > > > > local_id (text) - (the account being used locally) > > > > remote_id (text) - (the remote account) > > > > message (text) - the content of the message > > > > > > > > This is not sufficient for multi user chat messages! > > > > > > > > I know at least two different types of multi user chat types > > > > used: > > > > > > > > 1) chat rooms - every message from sender is sent to chat room > > > > and every received message is either from remote contact to > > > > chat room or from chat root to local contact or from remote > > > > contact to local contact > > > > > > > > 2) multi user chat - every message is sent from sender (local > > > > contact) to every received in multi user chat -- there is no > > > > chat room, just list of receivers > > > > > > We were discussing of having a groups table, where every group > > > conversation is stored with a group_id. > > > > Then please update draft API. Do not forget to include also room > > name (somewhere) and also that room name do not have to be > > present. > > > > > > Plus some protocols provide additional information about sender > > > > and receiver. E.g. in jabber we have "resource" which is part > > > > of every contact (local or remote). > > > > > > > > Some messages could have priority or type (e.g. IRC messages > > > > /me, ...). This is not handed here. > > > > > > > > And what is "message"? Plain text? Html message? or something > > > > else? > > > > > > I'll add a message_type column. > > > > Look at Kopete::Message class. It supports more then type. Plus > > think about messages like incoming file transfer or user joined > > chat conversation... I do not know if these messages should be > > logged or not. > > I think these messages (user joined, left) should be logged. They can > provide > context when someone is reviewing the history later. >
https://github.com/josh-wambua/kopete/blob/proposal/proposal.md I looked at updated info in git and I'm still not happy with it... First storage structure does not allow to save any (relevant/useful) information about messages what Kopete::Message class supports http://api.kde.org/4.x-api/kdenetwork-apidocs/kopete/libkopete/html/classKopete_1_1Message.html And second I still do not see how you want to handle multi user chats correctly. You are adding session to chat message, but Kopete::ChatSession is not useful here. It is destroyed if you close chat window, but some multi user chats are still active (e.g. in skype) even if you close chat window. Something similar will be in IRC plugin too (I believe). Also I do not know where or how will be stored something like jabber resource name... As I told at the beginning of GSoC, rewriting history plugin is not easy and new plugin should have fixed all design problems of previous implementations. And first I want to see working storage format... -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
