On Tuesday 16 June 2015 17:25:00 Joshua Joseph wrote: > On Tue, Jun 16, 2015 at 12:00 AM, Pali Rohár <pali.ro...@gmail.com> wrote: > > > .. I do not know if these messages should be > > > > logged or not. > > > > > > I think these messages (user joined, left) should be logged. They can > > > provide > > > context when someone is reviewing the history later. > > > > > > > https://github.com/josh-wambua/kopete/blob/proposal/proposal.md > > > > I looked at updated info in git and I'm still not happy with it... > > > > First storage structure does not allow to save any (relevant/useful) > > information about messages what Kopete::Message class supports > > > > > > http://api.kde.org/4.x-api/kdenetwork-apidocs/kopete/libkopete/html/classKopete_1_1Message.html > > > > > I updated the page to add some relevant message information. >
I think that there are too many columns in table where will be stored messages due to handling message content. What about storing *all* messages in HTML format? Converting plain text messages to HTML is easy and Qt already have needed function for it. And it should be already implemented in existing history plugin. Storing file transfers into history database sounds like bad idea. Notification (not content of received file!!) about received file could be useful. But I rather see option to disable storing file transfers and internal messages (user joined chat, user is online, ...). Also have you though about possibility of editing chat messages? Some protocols like Skype or Jabber support editing sent messages. And it would be cool if your history plugin API was prepared also for this use case... Once we decide final version of API and storage format it will be hard to change it (again). > > > And second I still do not see how you want to handle multi user chats > > correctly. You are adding session to chat message, but > > Kopete::ChatSession is not useful here. It is destroyed if you close > > chat window, but some multi user chats are still active (e.g. in skype) > > even if you close chat window. Something similar will be in IRC plugin > > too (I believe). > > > > I am in communication with Kaushik about that, so we can see how best to > handle multi user chats. > And for this part I'm very interested. Please move discussion to mailing list... > > > > > Also I do not know where or how will be stored something like jabber > > resource name... > > And this part I still do not see... > > As I told at the beginning of GSoC, rewriting history plugin is not easy > > and new plugin should have fixed all design problems of previous > > implementations. And first I want to see working storage format... > > > > -- > > Pali Rohár > > pali.ro...@gmail.com > > > > _______________________________________________ > > kopete-devel mailing list > > kopete-devel@kde.org > > https://mail.kde.org/mailman/listinfo/kopete-devel > > > > > > -- Pali Rohár pali.ro...@gmail.com _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
