On Wednesday 17 June 2015 12:40:10 Joshua Joseph wrote:
> On Wed, Jun 17, 2015 at 12:19 PM, Pali Rohár <pali.ro...@gmail.com> wrote:
> 
> > On Tuesday 16 June 2015 20:33:36 Joshua Joseph wrote:
> > > On Tue, Jun 16, 2015 at 7:49 PM, Pali Rohár <pali.ro...@gmail.com>
> > wrote:
> > >
> > > > On Tuesday 16 June 2015 17:58:04 Joshua Joseph wrote:
> > > > > On Tue, Jun 16, 2015 at 6:49 PM, kaushik <roideunive...@gmail.com>
> > > > > wrote:
> > > > > > @Joshua, Can you look into these things and update the readme
> > > > > > accordingly. Do let us know when you are done with it or have any
> > > > > > doubts.
> > > > >
> > > > > Sure Kaushik. I am working on it right now.
> > > > >
> > > >
> > > > Another thing:
> > > >
> > > > I think it can be useful to store also display name of contact which
> > > > sent/received message. This is specially needed for jabber MUC, where
> > > > sender is room name with resource specified by sender. So display name
> > > > is there needed for identifying user...
> > > >
> > > >
> > > Yes I thought so. I have already added a contact_name field.
> > >
> >
> > When you finish it, please write database SQL schema (for SQLite) and
> > sent it to mailing list for review.
> >
> 
> Hi,
> 
> This is the SQL for the current tables:
> 

Great, but there are missing descriptions what column means...

> CREATE TABLE "groups"(
> "group_id" Text  NOT NULL  ,
> "description" Text  ,
> "subject" Text  ,
> "group_type" Text

Hm ?

> );
> 
> 
> CREATE TABLE "messages"(
> "entry_id" Integer Primary Key Autoincrement  NOT NULL  ,
> "timestamp" Text  ,      "message" Text  ,
> "contact_name" Text  ,

Which? Local or remote?

> "subject" Text  ,

Why there is duplicate subject ?

> "importance" Text  ,
>  "background_color" Text  ,

Is not this part of HTML message?

>  "is_group_message" Integer   DEFAULT (0),
>  "group_id" Text  ,

Cannot be both columns reduced to just one?

>  "protocol" Text  ,
>  "direction" Text  ,
>  "local_id" Text  ,
>  "remote_id" Text
>  );
> 
> 

And where will be stored something like jabber resource?

-- 
Pali Rohár
pali.ro...@gmail.com
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to