Re: Review Request 112519: trim KStyle

2013-09-18 Thread Wojciech Kapuscinski
> > "whitespace" issues now. Copy & Paste error :) I'll fix whitespace issues - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40252 --

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Wojciech Kapuscinski
61d3 staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 Diff: http://git.reviewboard.kde.org/r/112519/diff/ Testing --- It builds and tests looks OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Re: Review Request 112519: trim KStyle

2013-09-17 Thread Wojciech Kapuscinski
ewboard.kde.org/r/112519/#review40185 --- On Sept. 6, 2013, 7:48 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Review Request 112682: move solid/networking_win.cpp to tier1/solid

2013-09-12 Thread Wojciech Kapuscinski
solid/networking_win.cpp Diff: http://git.reviewboard.kde.org/r/112682/diff/ Testing --- It builds on linux Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 112519: trim KStyle

2013-09-06 Thread Wojciech Kapuscinski
this does not work :) > > Christoph Feck wrote: > Thinking twice, it wouldn't hurt to have them in Qt, but I am not sure if > QStyle additions are welcomed upstream, considering it's "done". If useful "runtime extension" should stay :) On Sept. 4, 2013,

Re: Review Request 112519: trim KStyle

2013-09-06 Thread Wojciech Kapuscinski
http://git.reviewboard.kde.org/r/112519/diff/ Testing --- It builds and tests looks OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112519: trim KStyle

2013-09-06 Thread Wojciech Kapuscinski
staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 Diff: http://git.reviewboard.kde.org/r/112519/diff/ Testing --- It builds and tests looks OK Thanks, Wojciech Kapuscinski ___ Kde-f

Review Request 112571: enable clearButton in kpassworddialog

2013-09-06 Thread Wojciech Kapuscinski
clearButton in kpassworddialog Diffs - tier1/kwidgetsaddons/src/kpassworddialog.cpp dfab3e9 tier1/kwidgetsaddons/src/kpassworddialog.ui e007454 Diff: http://git.reviewboard.kde.org/r/112571/diff/ Testing --- manually tested kpassworddialog and clear icon appears Thanks, Wojciech

Review Request 112557: Remove all links to libkdeqt5staging

2013-09-06 Thread Wojciech Kapuscinski
/knotifications/tests/CMakeLists.txt fa93a01 staging/kservice/src/desktoptojson/CMakeLists.txt 1c2fd40 tier1/kconfig/src/kconf_update/CMakeLists.txt 08a3771 Diff: http://git.reviewboard.kde.org/r/112557/diff/ Testing --- it builds and tests looks OK Thanks, Wojciech Kapuscinski

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-04 Thread Wojciech Kapuscinski
g/r/112479/#comment29023> should be kbookmarks_export.h - Wojciech Kapuscinski On Sept. 4, 2013, 4:59 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.rev

Review Request 112519: trim KStyle

2013-09-04 Thread Wojciech Kapuscinski
ks OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-27 Thread Wojciech Kapuscinski
looks OK File Attachments patch generated with --find-copies-harder http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/k4style.patch Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-23 Thread Wojciech Kapuscinski
ui/k4style.cpp index 63506476..563aa81 100644 - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/#review38393 -------

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-22 Thread Wojciech Kapuscinski
patch generated with --find-copies-harder http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/k4style.patch Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-22 Thread Wojciech Kapuscinski
/files/2013/08/22/k4style.patch Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112172: reenable QLineEdit clear button

2013-08-20 Thread Wojciech Kapuscinski
aead573 staging/xmlgui/src/kbugreport.cpp 1d14faf staging/xmlgui/src/kedittoolbar.cpp 9e18c85 Diff: http://git.reviewboard.kde.org/r/112172/diff/ Testing --- it build and tests looks OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks

Review Request 112172: reenable QLineEdit clear button

2013-08-20 Thread Wojciech Kapuscinski
/kbugreport.cpp 1d14faf staging/xmlgui/src/kedittoolbar.cpp 9e18c85 Diff: http://git.reviewboard.kde.org/r/112172/diff/ Testing --- it build and tests looks OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Wojciech Kapuscinski
/WeaverGui/CMakeLists.txt f92577c Diff: http://git.reviewboard.kde.org/r/111945/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Wojciech Kapuscinski
--- It builds and tests looks OK. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski
. Testes with other changes (CMake part1, part2) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski
, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
kde.org/r/112051/#review37676 --- On Aug. 13, 2013, 11:06 a.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-13 Thread Wojciech Kapuscinski
/CMakeLists.txt 3f17e9a staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776 Diff: http://git.reviewboard.kde.org/r/112060/diff/ Testing --- it builds (with prefix removed) and tests looks OK. Testes with other changes (CMake part1, part2) Thanks, Wojciech Kapuscinski

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-13 Thread Wojciech Kapuscinski
, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
://git.reviewboard.kde.org/r/112051/diff/ Testing --- It builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-13 Thread Wojciech Kapuscinski
--- It builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-13 Thread Wojciech Kapuscinski
To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37557 --- On Aug. 9, 2013, 2:33 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-13 Thread Wojciech Kapuscinski
(still in progress) Diffs - staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 Diff: http://git.reviewboard.kde.org/r/112046/diff/ Testing --- It builds and tests looks OK (with manual test) Thanks, Wojciech Kapuscinski ___

Review Request 112046: reduce itmeviews test dependency

2013-08-13 Thread Wojciech Kapuscinski
ging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 Diff: http://git.reviewboard.kde.org/r/112046/diff/ Testing --- It builds and tests looks OK (with manual test) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-13 Thread Wojciech Kapuscinski
looks OK. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-09 Thread Wojciech Kapuscinski
cleanup (tier2 subdir) Diffs - tier2/kauth/src/CMakeLists.txt 2ceff81 tier2/kauth/src/ConfigureChecks.cmake cab1d01 Diff: http://git.reviewboard.kde.org/r/111985/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-09 Thread Wojciech Kapuscinski
. Description --- Task from kdelibs cleanup (tier2 subdir) Diffs - tier2/kauth/src/CMakeLists.txt 2ceff81 tier2/kauth/src/ConfigureChecks.cmake cab1d01 Diff: http://git.reviewboard.kde.org/r/111985/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-09 Thread Wojciech Kapuscinski
On Aug. 9, 2013, 2:33 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111945/ > ---

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-09 Thread Wojciech Kapuscinski
/CMakeLists.txt 6e0e450 tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c Diff: http://git.reviewboard.kde.org/r/111945/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-09 Thread Wojciech Kapuscinski
I should go? :) (NOTE: changing LINK_PUBLIC in future is BIC) - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review37406 --------

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-08 Thread Wojciech Kapuscinski
tier1/sonnet/tests/CMakeLists.txt 6e0e450 tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c Diff: http://git.reviewboard.kde.org/r/111945/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski ___ Kde

Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-08 Thread Wojciech Kapuscinski
/CMakeLists.txt 6e0e450 tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c Diff: http://git.reviewboard.kde.org/r/111945/diff/ Testing --- It builds and tests looks OK. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 111605: move kfreediskspace to kde4support

2013-07-23 Thread Wojciech Kapuscinski
--- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111653: Move KDEUI tests in their modules

2013-07-23 Thread Wojciech Kapuscinski
26877> It will be ported away form KWidgetsAddons (see previous comment). kmodifierkeyinfotest use KLed form KWidgetAddons only for "fancy" GUI. Without changes in kguiaddons I think this patch is ok - Wojciech Kapuscinski On July 23, 2013, 2:15

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

2013-07-21 Thread Wojciech Kapuscinski
ttp://git.reviewboard.kde.org/r/111424/#comment26817> this framework is called now KWidgets staging/ktextwidgets/autotests/CMakeLists.txt <http://git.reviewboard.kde.org/r/111424/#comment26816> this framework is called now KWidgets - Wojciech Kapuscinski On July 21, 2013, 1:54 p.m., And

Re: Review Request 111605: move kfreediskspace to kde4support

2013-07-19 Thread Wojciech Kapuscinski
://git.reviewboard.kde.org/r/111605/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

2013-07-19 Thread Wojciech Kapuscinski
same way like jenkins) all tests OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111605: move kfreediskspace to kde4support

2013-07-19 Thread Wojciech Kapuscinski
kfreediskspace to kde4support Diffs - kio/CMakeLists.txt 04b1495 kio/kfile/kdiskfreespace.h fcaee8d kio/kfile/kdiskfreespace.cpp staging/kde4support/src/CMakeLists.txt 137ada2 Diff: http://git.reviewboard.kde.org/r/111605/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski

Re: Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-11 Thread Wojciech Kapuscinski
d42 staging/kwidgets/src/actions/kstandardaction.cpp 0c3733a tier1/kwidgetsaddons/src/CMakeLists.txt 82d42db Diff: http://git.reviewboard.kde.org/r/111453/diff/ Testing --- Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list

Re: Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-11 Thread Wojciech Kapuscinski
src/actions/kstandardaction.cpp 0c3733a tier1/kwidgetsaddons/src/CMakeLists.txt 82d42db Diff: http://git.reviewboard.kde.org/r/111453/diff/ Testing --- Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.

Re: Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-11 Thread Wojciech Kapuscinski
src/actions/kstandardaction.cpp 0c3733a tier1/kwidgetsaddons/src/CMakeLists.txt 82d42db Diff: http://git.reviewboard.kde.org/r/111453/diff/ Testing --- Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-de

Re: Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-11 Thread Wojciech Kapuscinski
ing --- Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-11 Thread Wojciech Kapuscinski
ttp://git.reviewboard.kde.org/r/111453/diff/ Testing --- Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111453: move kacceleratormanager to KWidgetAddons

2013-07-08 Thread Wojciech Kapuscinski
cpp 990b093 kdeui/shortcuts/kacceleratormanager_private.h ab04d42 staging/kwidgets/src/actions/kstandardaction.cpp 0c3733a tier1/kwidgetsaddons/src/CMakeLists.txt 82d42db Diff: http://git.reviewboard.kde.org/r/111453/diff/ Testing --- Thanks, Wojciech Kapuscin

Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

2013-06-27 Thread Wojciech Kapuscinski
/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111270/diff/ Testing (updated) --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 111285: reduce KCompletion test dependency

2013-06-27 Thread Wojciech Kapuscinski
KCompletion test dependency Diffs - staging/kcompletion/tests/CMakeLists.txt cc7b548 staging/kcompletion/tests/kcomboboxtest.cpp 7d95ead Diff: http://git.reviewboard.kde.org/r/111285/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski

Re: Review Request 111236: move kcombobox and khistorycombobox to KCompletion framework.

2013-06-27 Thread Wojciech Kapuscinski
/kcompletion/src/CMakeLists.txt e502554 staging/kcompletion/tests/CMakeLists.txt e8e39f3 Diff: http://git.reviewboard.kde.org/r/111236/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 111277: remove KdeUiProxyStyle from KHTML

2013-06-27 Thread Wojciech Kapuscinski
KdeUiProxyStyle from KHTML Diffs - khtml/rendering/render_form.cpp 6c465d3 khtml/rendering/render_form.h cfd23d8 Diff: http://git.reviewboard.kde.org/r/111277/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel

Re: Review Request 111232: move klineedit and kcompletionbox to KCompletion framework

2013-06-27 Thread Wojciech Kapuscinski
sts/CMakeLists.txt fd8aa7b kdeui/CMakeLists.txt 6d79682 staging/kde4support/src/CMakeLists.txt 551181c staging/kemoticons/tests/CMakeLists.txt 3c59e7e Diff: http://git.reviewboard.kde.org/r/111232/diff/ Testing --- it builds Thanks, Wojciech Kapuscin

Re: Review Request 111232: move klineedit and kcompletionbox to KCompletion framework

2013-06-26 Thread Wojciech Kapuscinski
ing/kde4support/src/CMakeLists.txt 551181c staging/kemoticons/tests/CMakeLists.txt 3c59e7e Diff: http://git.reviewboard.kde.org/r/111232/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-de

Review Request 111236: move kcombobox and khistorycombobox to KCompletion framework.

2013-06-25 Thread Wojciech Kapuscinski
: http://git.reviewboard.kde.org/r/111236/diff/ Testing --- it builds Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111232: move klineedit and kcompletionbox to KCompletion framework

2013-06-25 Thread Wojciech Kapuscinski
ing/kcompletion/tests/CMakeLists.txt e8e39f3 staging/kde4attic/src/CMakeLists.txt 0cf1be7 staging/kde4support/src/CMakeLists.txt 551181c staging/kemoticons/tests/CMakeLists.txt 3c59e7e Diff: http://git.reviewboard.kde.org/r/111232/diff/ Testing --- it builds Thanks, Wojci

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Wojciech Kapuscinski
Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
(CMakeLists.txt in kdeui). Not sure what to do because kwallettest requires kwalletd - Wojciech Kapuscinski On June 18, 2013, 10:38 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
-CREATION staging/kwallet/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-18 Thread Wojciech Kapuscinski
/tests/kwallettest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/05/diff/ Testing --- It builds on Linux. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
/CMakeLists.txt bb26c4e staging/kde4support/src/kdeui/kviewstatesaver.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111002/diff/ Testing --- it builds and tests all OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
-CREATION staging/kde4support/src/CMakeLists.txt bb26c4e staging/kde4support/src/kdeui/kviewstatesaver.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111002/diff/ Testing --- it builds and tests all OK Thanks, Wojciech Kapuscinski

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34334 --- On June 13, 2013, 6:12 p.m., Wojciech Kapuscinski wrote: > > ---

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-17 Thread Wojciech Kapuscinski
tests/kjobtrackerstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110995/diff/ Testing --- it builds and my tests shows now regressions (except plural translations (s) ) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-14 Thread Wojciech Kapuscinski
it builds and my tests shows now regressions (except plural translations (s) ) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-13 Thread Wojciech Kapuscinski
tests/kjobtrackerstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110995/diff/ Testing --- it builds and my tests shows now regressions (except plural translations (s) ) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing lis

Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-13 Thread Wojciech Kapuscinski
: http://git.reviewboard.kde.org/r/111002/diff/ Testing --- it builds and tests all OK Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-13 Thread Wojciech Kapuscinski
tests/kjobtrackerstest.h PRE-CREATION staging/kjobwidgets/tests/kjobtrackerstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110995/diff/ Testing --- it builds and my tests shows now regressions (except plural translations (s) ) Thanks, Wojciech Kapusc

Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-13 Thread Wojciech Kapuscinski
sting --- it builds and my tests shows now regressions (except plural translations (s) ) Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110845: Move kdeui/itemviews to ItemViews framework

2013-06-05 Thread Wojciech Kapuscinski
/ktreewidgetsearchlinetest.cpp PRE-CREATION staging/itemviews/tests/kwidgetitemdelegatetest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110845/diff/ Testing --- It builds. Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel

Review Request 110837: Port away ItemViews from KLineEdit and i18n

2013-06-05 Thread Wojciech Kapuscinski
/ktreewidgetsearchline.cpp a6927f0 kdeui/itemviews/kwidgetitemdelegatepool.cpp 0ea4f02 Diff: http://git.reviewboard.kde.org/r/110837/diff/ Testing --- It builds, all tests passed Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel mailing list

Re: Review Request 110733: move kpixmapsequence, kpixmapsequenceoverlaypainter, kpixmapsequencewidget to KIconThemes

2013-05-30 Thread Wojciech Kapuscinski
iewboard.kde.org/r/110733/#review33450 --- On May 30, 2013, 4:33 p.m., Wojciech Kapuscinski wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 110733: move kpixmapsequence, kpixmapsequenceoverlaypainter, kpixmapsequencewidget to KIconThemes

2013-05-30 Thread Wojciech Kapuscinski
/kpixmapsequenceoverlaypaintertest.h PRE-CREATION staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110733/diff/ Testing --- Build tested Thanks, Wojciech Kapuscinski ___ Kde-frameworks-devel