> On Sept. 4, 2013, 10:20 p.m., Christoph Feck wrote: > > staging/frameworkintegration/src/kstyle/kstyle.h, line 98 > > <http://git.reviewboard.kde.org/r/112519/diff/2/?file=187028#file187028line98> > > > > The "runtime element extension" should probably stay. They are useful, > > and Qt/QStyle does not offer anything similar. > > > > (Actually, these static functions are what I proposed to move to a new > > namespace KStyle, but since it apparently has been decided to keep KStyle > > as a class, this does not work :) > > Christoph Feck wrote: > Thinking twice, it wouldn't hurt to have them in Qt, but I am not sure if > QStyle additions are welcomed upstream, considering it's "done".
If useful "runtime extension" should stay :) On Sept. 4, 2013, 10:20 p.m., Wojciech Kapuscinski wrote: > > Regarding the eventFilter, I would kill it. Making labels a click-buddy for > > other widgets should not depend on the used style, so if the feature is > > really needed, it should be proposed upstream. > > > > Then you can also kill drawKStylePrimitive(). agreed. This belongs to "style". KStyle in KF5 only should enforce some of the user settings consistently across the styles. - Wojciech ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review39383 ----------------------------------------------------------- On Sept. 6, 2013, 3:11 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112519/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 3:11 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > KStyle 2/3: Remove everything from KStyle which is not a reimplementation of > the following methods: polish, unpolish, eventFilter, styleHint, > pixelMetrics, standardIcons. > > > Note: > Probably we can remove drawKStylePrimitive (and a lot enums/structs in > kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter > correctly and this is material for 3/3 KStyle task :) > > > Diffs > ----- > > staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 > staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 > > Diff: http://git.reviewboard.kde.org/r/112519/diff/ > > > Testing > ------- > > It builds and tests looks OK > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
