----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/ -----------------------------------------------------------
(Updated Sept. 6, 2013, 3:11 p.m.) Review request for KDE Frameworks. Changes ------- Kill drawKStylePrimitive(), remove everything from eventFilter (see Christoph Feck comment), restore "runtime element extension". Description ------- KStyle 2/3: Remove everything from KStyle which is not a reimplementation of the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, standardIcons. Note: Probably we can remove drawKStylePrimitive (and a lot enums/structs in kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter correctly and this is material for 3/3 KStyle task :) Diffs (updated) ----- staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 Diff: http://git.reviewboard.kde.org/r/112519/diff/ Testing ------- It builds and tests looks OK Thanks, Wojciech Kapuscinski
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
