> On Sept. 17, 2013, 11:32 p.m., Christoph Feck wrote: > > What exactly is the plan for "KStyle 3/3"? I see many more cruft that could > > be removed for the KF5 version, in particular, all the enums. If that's the > > idea, please ship this in the meantime.
>From KF5 wiki "3/3 From what remains of KStyle after the previous two tasks, >evaluate what is here to enforce platform settings and what might make style >developers life too hard, keep only the parts about platform settings and let >go the rest". In KF5 world oxygen-style and others must subclass KStyle because we want enforce some users settings (activate item on single click, show icons/text on buttons/menu, animate widget etc). And yes probably we can get rid off all enums :) > On Sept. 17, 2013, 11:32 p.m., Christoph Feck wrote: > > staging/frameworkintegration/src/kstyle/kstyle.cpp, line 274 > > <http://git.reviewboard.kde.org/r/112519/diff/4/?file=190172#file190172line274> > > > > Could you check the diff on reviewboard site? Here, I see many red > > "whitespace" issues now. Copy & Paste error :) I'll fix whitespace issues - Wojciech ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40252 ----------------------------------------------------------- On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112519/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2013, 1:54 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa. > > > Description > ------- > > KStyle 2/3: Remove everything from KStyle which is not a reimplementation of > the following methods: polish, unpolish, eventFilter, styleHint, > pixelMetrics, standardIcons. > > > Note: > Probably we can remove drawKStylePrimitive (and a lot enums/structs in > kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter > correctly and this is material for 3/3 KStyle task :) > > > Diffs > ----- > > staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 > staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 > > Diff: http://git.reviewboard.kde.org/r/112519/diff/ > > > Testing > ------- > > It builds and tests looks OK > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
