----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111232/ -----------------------------------------------------------
(Updated June 27, 2013, 6:38 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Description ------- move klineedit and kcompletionbox to KCompletion framework Notes: KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)). Can we cut dependency do KIconThemes too? Diffs (updated) ----- staging/kde4attic/src/CMakeLists.txt 0cf1be7 staging/kcompletion/tests/CMakeLists.txt e8e39f3 staging/kcompletion/src/config-kcompletion.h.cmake PRE-CREATION staging/kcompletion/src/CMakeLists.txt e502554 staging/kcompletion/autotests/CMakeLists.txt f497c9a security/crypto/CMakeLists.txt e890d33 kutils/CMakeLists.txt bfe8541 kross/ui/CMakeLists.txt 65e1abb knewstuff/knewstuff3/CMakeLists.txt 41ea203 kioslave/http/kcookiejar/CMakeLists.txt 2dae665 kfile/CMakeLists.txt bc48bf7 kdeui/widgets/klineedit_p.h 7c58f2d kdeui/widgets/klineedit.cpp 24920a8 kdeui/widgets/klineedit.h 7ac22f6 kdeui/widgets/kcompletionbox.cpp kdeui/widgets/kcompletionbox.h 6e10dcf kdeui/tests/klineedittest.cpp kdeui/tests/klineedittest.h kdeui/tests/klineedit_unittest.cpp kdeui/tests/CMakeLists.txt fd8aa7b kdeui/CMakeLists.txt 6d79682 staging/kde4support/src/CMakeLists.txt 551181c staging/kemoticons/tests/CMakeLists.txt 3c59e7e Diff: http://git.reviewboard.kde.org/r/111232/diff/ Testing ------- it builds Thanks, Wojciech Kapuscinski
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
