Re: Using KWallet from non-KDE apps (G.Chrome...)

2018-01-14 Thread Valentin Rusu
urned to Firefox so don't know more. For that to work, you need to have a KDE session going in the background. That session will initialize the dbus services and among them the kwalletd service. From that point on, the client-side libraries will talk to it. -- Valentin Rusu IRC: valir

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-12-13 Thread Valentin Rusu
- > > (Updated Oct. 16, 2015, 4:52 p.m.) > > > Review request for KDE Frameworks and Valentin Rusu. > > > Repository: kwallet > > > Description > --- > > A use-case: kwallet gets locked with lockscreen, eg. on Plas

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

2015-12-13 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/#review89411 --- Ship it! Ship It! - Valentin Rusu On Dec. 12, 2015, 10:59

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

2015-12-13 Thread Valentin Rusu
> On Dec. 13, 2015, 1:01 a.m., Nick Shaforostoff wrote: > > i suggest using: > > > > #ifdef Q_OS_WIN > > #define U QLatin1String > > #else > > #define U QStringLiteral > > #endif Patrick's approach corresponds to a widespread practice in KF5 sources. It also has the advantage to always use

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-11-06 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review88114 --- Ship it! Ship It! - Valentin Rusu On Oct. 16, 2015, 4:52

Re: [kubuntu-devel] Re: git moves

2015-08-12 Thread Valentin Rusu
* Martin Klapetek [2015-08-12 12:25:27 -0400]: > On Tue, Aug 11, 2015 at 7:30 AM, Jonathan Riddell wrote: > > > On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: > > > * Jonathan Riddell [2015-08-05 18:11:56 +0200]: > > > > > &

Re: git moves

2015-08-11 Thread Valentin Rusu
le and users would have all the required pieces together. If nobody is against this merging - and to be sure I copy kde-frameworks-devel - then it's a matter of importing the kwallet-map repo into a directory under kwallet/src/runtime. I could help with that. -- Valenti

Re: Review Request 124567: Add missing date, releaseinfo + productname to kwallet-query.1.docbook

2015-08-01 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124567/#review83293 --- Ship it! Ship It! - Valentin Rusu On July 31, 2015, 6:28

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-28 Thread Valentin Rusu
* Martin Klapetek [2015-07-28 10:10:46 -]: > Oops I've pushed this by mistake with other commit, if you think > there's anything that should be changed, please reopen this and > I'll revert it. > No, it's OK, thanks for this. ___ Kde-frameworks-d

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Valentin Rusu
e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124487/ > --- > > (Updated July 27, 2015, 11:22 a.m.) > > > Review request for KDE Frameworks and Valentin Rusu. > > > Repository: kwallet >

Re: Review Request 124487: Couple misc small fixes in kwallet

2015-07-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124487/#review83057 --- Ship it! Ship It! - Valentin Rusu On July 27, 2015, 11:22

Re: Review Request 124372: Fix crash when MigrationAgent::isEmptyOldWallet() check fails

2015-07-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124372/#review83016 --- Ship it! Ship It! - Valentin Rusu On July 16, 2015, 1:11

Re: Review Request 124413: Enable PAM opening KWallet again

2015-07-27 Thread Valentin Rusu
> On July 27, 2015, 8:02 a.m., Valentin Rusu wrote: > > Ship It! and thanks for this. - Valentin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#re

Re: Review Request 124413: Enable PAM opening KWallet again

2015-07-27 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review83014 --- Ship it! Ship It! - Valentin Rusu On July 21, 2015, 5:27

Re: kwallet-query moved to kdereview

2015-06-14 Thread Valentin Rusu
* Luigi Toscano [2015-06-14 13:32:26 +0200]: > Valentin Rusu ha scritto: > > > The kwallet-query tool is now part of KF5::Wallet. I'll now request > > kdereview/kwallet-query repository removal. > > src/runtime/kwallet-query/src/querydriver.cpp:153:47: error: ‘clas

Re: kwallet-query moved to kdereview

2015-06-14 Thread Valentin Rusu
* Valentin Rusu [2015-05-29 22:32:46 +0200]: > * David Narvaez [2015-05-28 09:53:55 -0400]: > > > On Sun, May 24, 2015 at 3:39 PM, Valentin Rusu wrote: > > > Hello, > > > > > > Seems to me that quite some time passed since my request and nobody >

Re: Proposal: move KWalletManager inside KWallet framework

2015-06-13 Thread Valentin Rusu
* Valentin Rusu [2015-06-13 18:29:46 +0200]: > * Stefan Bruens [2015-06-13 18:16:21 +0200]: > > > On Tuesday 02 June 2015 23:15:46 Stefan Bruens wrote: > > > On Friday 29 May 2015 22:31:00 Valentin Rusu wrote: > > > > Ok, I should also test this. Do you hav

Re: Proposal: move KWalletManager inside KWallet framework

2015-06-13 Thread Valentin Rusu
* Stefan Bruens [2015-06-13 18:16:21 +0200]: > On Tuesday 02 June 2015 23:15:46 Stefan Bruens wrote: > > On Friday 29 May 2015 22:31:00 Valentin Rusu wrote: > > > Ok, I should also test this. Do you have a KDE commiter account? Can you > > > push a branch with your p

KWalletManager frameworks branch merged to master

2015-06-13 Thread Valentin Rusu
Hello, Please be advised that kdeutils/kwalletmanager is now KF5 based as I just merged the frameworks branch to the master branch. -- Valentin Rusu IRC: valir ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-29 Thread Valentin Rusu
lletd5. > > I have checked with nm-applet5 (org.kde.kwalletd5) and akonadi > (org.kde.kwalletd), both can retrieve their secrets from kwalletd5. > Ok, I should also test this. Do you have a KDE commiter account? Can you push a branch with your patched code, in the KWallet framework, please? -- Valentin Rusu IRC: valir ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-28 Thread Valentin Rusu
welcome! > > Kind regards, > > Stefan > > -- > Stefan Brüns / Bergstraße 21 / 52062 Aachen > home: +49 241 53809034 mobile: +49 151 50412019 > work: +49 2405 49936-424 > > ___ > Kde-frameworks-devel mailing list > Kde-

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-26 Thread Valentin Rusu
* Valentin Rusu [2015-05-26 23:56:05 +0200]: > * Albert Astals Cid [2015-05-26 23:52:18 +0200]: > > > El Dimarts, 26 de maig de 2015, a les 23:31:38, Valentin Rusu va escriure: > > > * Albert Astals Cid [2015-05-26 21:42:25 +0200]: > > > > El Dimarts, 2

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-26 Thread Valentin Rusu
* Albert Astals Cid [2015-05-26 23:52:18 +0200]: > El Dimarts, 26 de maig de 2015, a les 23:31:38, Valentin Rusu va escriure: > > * Albert Astals Cid [2015-05-26 21:42:25 +0200]: > > > El Dimarts, 26 de maig de 2015, a les 08:52:13, Valentin Rusu va escri

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-26 Thread Valentin Rusu
* Albert Astals Cid [2015-05-26 21:42:25 +0200]: > El Dimarts, 26 de maig de 2015, a les 08:52:13, Valentin Rusu va escriure: > > Hello, > > > > Since the release 15.04 I see more and more users puzzled about their > > KDE Wallet set-up. For example, see this [

Proposal: move KWalletManager inside KWallet framework

2015-05-25 Thread Valentin Rusu
ng me know this) -- Valentin Rusu IRC: valir ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122959: Minor cleanup of KWallet private/public deps

2015-03-14 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122959/#review77480 --- Ship it! Ship It! - Valentin Rusu On March 14, 2015, 7:25

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72750 --- Ship it! Looks goot to me. - Valentin Rusu On Dec. 29

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Valentin Rusu
gt; > > Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin > Rusu. > > > Repository: kwallet > > > Description > --- > > 1. Create a new wallet "foo" > 2. immediately remove the 'kwalletd5&#

Re: Where are kwalletd autotests?

2014-11-01 Thread Valentin Rusu
On 01/11/14 02:19:05, Albert Astals Cid wrote: > > El Dissabte, 1 de novembre de 2014, a les 00:23:57, David Faure va escriure: > > On Friday 31 October 2014 01:00:41 Albert Astals Cid wrote: > > > kwalletd has autotests in kde-runtime in kdelibs4 world but can't find > > > them > > > in KF5 land.

Re: Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-10-07 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120387/#review68063 --- Ship it! Ship It! - Valentin Rusu On Sept. 27, 2014, 11

Re: DrKonqi placement

2014-04-03 Thread Valentin Rusu
s KF5::JobWidgets KF5::Completion KF5::Wallet Qt5::DBus > > Woh! > KF5::Wallet is for the convenience log-in into bugs.kde.org. I 'hinks that's nice on it :-) -- Valentin Rusu irc: valir signature.asc Description: This is a digitally signed message part. ___

Re: KF5 Update Meeting Minutes 2014-w10

2014-03-05 Thread Valentin Rusu
Hello, Catching up with KF5 progress... On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: > * Repository merges for kwallet and kdnssd still reported as pending... What's that? Is that about merging 4.xx repository with the KF5 one? > * afiestas has kwallet patches in need of review

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
lver.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs Diffs - src/kdecore/netsupp.h ef3c3e8263683e8e707e8ee5b0204dad1fb37ecc Diff: https://git.reviewboard.kde.org/r/115433/diff/ Testing --- kde4support now builds. Thanks, Val

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/#review48766 --- On Feb. 2, 2014, 10:38 a.m., Valentin Rusu wrote: >

Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
rc/kdecore/netsupp.h ef3c3e8263683e8e707e8ee5b0204dad1fb37ecc Diff: https://git.reviewboard.kde.org/r/115433/diff/ Testing --- kde4support now builds. Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://ma

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/#review48500 --- Ship it! Ship It! - Valentin Rusu On Jan. 28, 2014, 10:28

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Valentin Rusu
org/r/115367/#comment34291> Please apply this option also in tests/CMakeLists.txt - Valentin Rusu On Jan. 28, 2014, 8:40 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Tier status of attica & kwallet

2014-01-28 Thread Valentin Rusu
On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > On 01/23/2014 08:21 AM, Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > >> > Sure, the framework itself is still tier 2...but the repo also includes > kwalletd

Re: Review Request 115364: Update tier number

2014-01-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/#review48495 --- Ship it! Ship It! - Valentin Rusu On Jan. 28, 2014, 5:14

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Valentin Rusu
On Tuesday, January 28, 2014 04:40:51 PM Kevin Ottens wrote: > * teo is planning to help on the kwallet and secret service front; > * he's waiting to hear back from valentin rusu; teo already contacted me, suggesting IRC meeting during working hours. Unfortunately, I won't b

Re: Tier status of attica & kwallet

2014-01-24 Thread Valentin Rusu
On Friday, January 24, 2014 07:22:22 AM Kevin Ottens wrote: > On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: > > On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > > > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > > > On Thurs

Re: Review Request 115164: Keep tests together

2014-01-24 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48248 --- Ship it! Looks good to me. - Valentin Rusu On Jan. 22

Re: Tier status of attica & kwallet

2014-01-24 Thread Valentin Rusu
On Saturday, January 25, 2014 01:49:51 AM Michael Palimaka wrote: > On 01/24/2014 09:21 AM, Alex Merry wrote: > > On 23/01/14 21:50, Valentin Rusu wrote: > >> On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > >>> On 01/23/2014 08:21 AM, Valentin

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-24 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48242 --- Ship it! Ship It! - Valentin Rusu On Jan. 22, 2014, 11:23

Re: Tier status of attica & kwallet

2014-01-23 Thread Valentin Rusu
On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > On 01/23/2014 08:21 AM, Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > Sure, the framework itself is still tier 2...but the repo also includes > kwalletd which definitel

Re: Tier status of attica & kwallet

2014-01-23 Thread Valentin Rusu
On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > > Hi, > > > > > > attica seems to have been absorbed as a fra

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-23 Thread Valentin Rusu
> On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: > > src/api/KWallet/CMakeLists.txt, line 100 > > <https://git.reviewboard.kde.org/r/115218/diff/1/?file=235142#file235142line100> > > > > The interface will be strictly the same. New features will be added t

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-22 Thread Valentin Rusu
tps://git.reviewboard.kde.org/r/115218/#comment34033> The interface will be strictly the same. New features will be added to secret service. That's why I didn't consider changing it's name. And, btw, changing it's name will make users think that changes have been (or will be) done to this A

Re: Tier status of attica & kwallet

2014-01-22 Thread Valentin Rusu
in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 > it includes kwalletd which depends on higher tier frameworks - does it > still belong in tier 2? kwallet-framework is still tier2, as there are no higher dependencies, AFAIK. -- Valentin Rusu irc: valir ___

Re: ECM version changed (Re: KDE Frameworks 5 TP1 tarballs)

2014-01-20 Thread Valentin Rusu
On Monday, January 20, 2014 11:48:51 PM Albert Astals Cid wrote: > El Dilluns, 20 de gener de 2014, a les 23:39:32, Valentin Rusu va escriure: > > On Monday, January 20, 2014 01:44:37 AM šumski wrote: > > > On Saturday 11 of January 2014 11:15:47 Mich

Re: CI environment, kwallet & tests that pop windows

2014-01-20 Thread Valentin Rusu
On Monday, January 20, 2014 12:32:04 PM David Faure wrote: > On Sunday 19 January 2014 23:02:09 Valentin Rusu wrote: > > Hello, > > > > kwallet-framework tests now (correctly) work when launched from a KF5 > > session. kwalletd pop-ups password dialogs using KF5/Qt5 (y

Re: Jenkins build became unstable: ktexteditor_master_qt5 #61

2014-01-19 Thread Valentin Rusu
org/mailman/listinfo/kde-frameworks-devel Now tests fail because kwalletd pops windows and I don't now how to handle them from the tests - see my other mail "CI environment, kwallet & tests that pop windows". -- Valentin Rusu irc: valir __

CI environment, kwallet & tests that pop windows

2014-01-19 Thread Valentin Rusu
tests? -- Valentin Rusu irc: valir signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-19 Thread Valentin Rusu
On Wednesday, January 15, 2014 11:15:54 AM Alex Merry wrote: > On 15/01/14 07:36, Valentin Rusu wrote: > > On 01/15/2014 07:16 AM, Ben Cooksley wrote: > >> It seems you are relying on D-Bus auto-launching. Is this the case? > > > > Yes, the kwallet API uses DBus ac

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-15 Thread Valentin Rusu
On 01/15/2014 12:15 PM, Alex Merry wrote: > On 15/01/14 07:36, Valentin Rusu wrote: >> On 01/15/2014 07:16 AM, Ben Cooksley wrote: >>> It seems you are relying on D-Bus auto-launching. Is this the case? >> >> Yes, the kwallet API uses DBus activation to get kwalle

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-14 Thread Valentin Rusu
On 01/15/2014 07:16 AM, Ben Cooksley wrote: > On Wed, Jan 15, 2014 at 11:44 AM, Valentin Rusu wrote: >> On 01/14/2014 11:41 PM, KDE CI System wrote: >>> See <http://build.kde.org/job/kwallet-framework_master_qt5/21/changes> >>> >>> _

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-14 Thread Valentin Rusu
On 01/14/2014 11:41 PM, KDE CI System wrote: > See > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-14 Thread Valentin Rusu
On 01/12/2014 07:59 PM, Valentin Rusu wrote: > Hello, > > Please be informed that I successfully imported the git history of > kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. > The code is ready to be pushed, but there are 430 commits waiting on my > loc

Re: Build failed in Jenkins: kwallet-framework_master_qt5 #18

2014-01-14 Thread Valentin Rusu
On 01/14/2014 05:45 PM, KDE CI System wrote: > See > > -- > Started by user gateau Would you mind triggering a new build? The module metadata is now updated and I'm pretty sure that was the origin

Re: kwallet-framework optionally depends on kdepimlibs

2014-01-14 Thread Valentin Rusu
On 01/14/2014 06:27 PM, Treeve Jelbert wrote: > src/runtime/kwalletd/CMakeLists.txt: > > find_package(Gpgme) # Called by FindQGpgme, but since we call some gpgme > # functions ourselves we need to link against it > directly. > find_package(QGpgme) # provided by kdepimlibs >

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-14 Thread Valentin Rusu
On 01/14/2014 10:38 AM, Aurélien Gâteau wrote: > On Mon, Jan 13, 2014, at 23:53, Valentin Rusu wrote: >> On 01/13/2014 10:05 PM, Valentin Rusu wrote: >>> On 01/12/2014 07:59 PM, Valentin Rusu wrote: >>>> Hello, >>>> >>>> Please be in

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 10:05 PM, Valentin Rusu wrote: > On 01/12/2014 07:59 PM, Valentin Rusu wrote: >> Hello, >> >> Please be informed that I successfully imported the git history of >> kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. >> The code is

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/12/2014 07:59 PM, Valentin Rusu wrote: > Hello, > > Please be informed that I successfully imported the git history of > kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. > The code is ready to be pushed, but there are 430 commits waiting on my > loc

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 08:40 PM, Kevin Ottens wrote: > On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: >> On 01/13/2014 07:54 PM, David Faure wrote: >>> On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: >>>> 2014/1/13 David Faure : >>>> >&g

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 07:54 PM, David Faure wrote: > On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: >> 2014/1/13 David Faure : >> >> If you rename kwallet to kwalletmanager and kwallet-framework to >> kwallet, people with a clone of "kwallet.git" will get a mess the next >> time they pull from t

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Valentin Rusu
On 01/13/2014 05:17 PM, Kevin Ottens wrote: > Hello, > > On Monday 13 January 2014 10:05:26 David Faure wrote: >> On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: >> >> Do you also plan on doing something with the "kwallet" repository, >> i.e.

kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-12 Thread Valentin Rusu
push it. After that, and if no one objects, I'll do the "git rm -rf kwalletd" from frameworks branch of kde-runtime, also adjusting the main CMakeLists.txt. From now on kwalletd will live here: kwallet-framework/src/runtime/kwalletd -- Valentin Rusu (IRC valir, KDE vrusu) KSe

Re: KF5Config - module config won't get right include path

2014-01-11 Thread Valentin Rusu
On 01/11/2014 01:26 PM, Alex Merry wrote: > On 11/01/14 09:32, Valentin Rusu wrote: >> /home/kde5/src/frameworks/kwallet-framework/src/runtime/kwalletd/main.cpp:24:19: >> fatal error: KConfig: No such file or directory >> #include > > My local copy looks fine, and al

KF5Config - module config won't get right include path

2014-01-11 Thread Valentin Rusu
or directory #include ^ compilation terminated. What should I change in order to get it compiling? I think that something's missing from the KConfig framework build files, but I'm still trying to figure it out... Thanks, -- Valentin Rusu (IRC valir, KDE vrusu)

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-02 Thread Valentin Rusu
> On Oct. 2, 2013, 6:51 p.m., Valentin Rusu wrote: > > Ship It! Thanks for doing this! - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#re

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41142 --- Ship it! Ship It! - Valentin Rusu On Oct. 2, 2013, 12:53

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

2013-09-26 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/#review40891 --- Ship it! Ship It! - Valentin Rusu On Sept. 26, 2013, 8:13

Re: potential duplicate repositories for kwallet

2013-09-23 Thread Valentin Rusu
On 09/22/2013 09:43 AM, Treeve Jelbert wrote: > There is a kwallet repo as a result of splitting kdeutils. > > On my system,this installs: > > /opt/qt4/bin/kwalletmanager > /opt/qt4/lib/kde4/kcm_kwallet.so These are from utils/kwallet, which is the "KDE Wallet Manager" tool. This is not the KWal

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-30 Thread Valentin Rusu
On 08/29/2013 06:20 PM, Kevin Ottens wrote: > Hello, > > On Wednesday 28 August 2013 20:26:45 Albert Astals Cid wrote: >> If you bundle lots of stuff in the tarball you may end up "wrongly" >> increasing your dependencies and people won't use the framework because "it >> depends on QtNetwork" or s

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/25/2013 12:39 PM, Kevin Krammer wrote: > On Sunday, 2013-08-25, Valentin Rusu wrote: >> On 08/24/2013 02:32 PM, Kevin Krammer wrote: >>> On Saturday, 2013-08-24, Albert Astals Cid wrote: >>>> El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/24/2013 01:43 PM, Albert Astals Cid wrote: > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: >> >> * Another piece of software related to kwallet is KWalletManager from >> kdeutils. I think that component should also be detached from kdeu

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/24/2013 02:32 PM, Kevin Krammer wrote: > On Saturday, 2013-08-24, Albert Astals Cid wrote: >> El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: >>> >>> * AFAIK, frameworks should be independent and self-contained. kwallet >>&

Fwd: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
tasks as quick as possible. Thanks for reading and I'd be grateful for a quick reply on these topics. Regards, -- Valentin Rusu (IRC valir, KDE vrusu) KSecretsService (former KSecretService, KWallet replacement) signature.asc Description: OpenPGP digital signature _

Re: Review Request 111105: Create KWallet framework and move kwallet.h and others

2013-06-19 Thread Valentin Rusu
> On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote: > > hmmm strange. kwallettest is unit test but was in manual tests > > (CMakeLists.txt in kdeui). > > Not sure what to do because kwallettest requires kwalletd Perhaps we could use this kdeui splitting opportunity to bring here kwalletd

Re: KF5 Update Meeting 2013-w20

2013-05-16 Thread Valentin Rusu
n the day ? > At 4pm I'm at work, and so can't attend. Same for me. At 4pm I'm at work. And my regular job is not for KDE ;-) -- Valentin Rusu (vrusu) IRC: valir ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https:/

Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-27 Thread Valentin Rusu
)’: /home/kde5/src/kf5-qt5/kdelibs- frameworks/kdeui/dialogs/kedittoolbar.cpp:860:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] make[1]: *** [kdeui/CMakeFiles/kdeui.dir/all] Error 2 make: *** [all] Error 2 -- Valentin Rusu (vrusu) IRC: va

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
/kglobalaccel.h ed68bba > kdeui/shortcuts/kglobalaccel.cpp 36dbab7 > kdeui/shortcuts/kglobalaccel_p.h 04feaba > > Diff: http://git.reviewboard.kde.org/r/109019/diff/ > > > Testing > --- > > Code compiles > > > Thanks, > > Valentin Rusu > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
--- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-27 Thread Valentin Rusu
vate ;-) - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28188 --- On Feb. 26, 2013, 7:28 p.m., Valentin Rusu

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-26 Thread Valentin Rusu
: http://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Valentin Rusu
://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-25 Thread Valentin Rusu
uts.contains(action); - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review27994 --- On Feb. 22, 2013, 10:59 p.m., Valen

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-22 Thread Valentin Rusu
/kglobalaccel_p.h 04feaba Diff: http://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-22 Thread Valentin Rusu
s an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review27809 --- On Feb. 20, 2013, 10:32 p.m., Valentin Rusu wrote: > > ---

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-20 Thread Valentin Rusu
all failure. > On Feb. 19, 2013, 7:20 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kglobalaccel.cpp, line 426 > > <http://git.reviewboard.kde.org/r/109019/diff/1/?file=114352#file114352line426> > > > > Why const here? It forces you to const_cast l

Re: Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-20 Thread Valentin Rusu
ba Diff: http://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

2013-02-18 Thread Valentin Rusu
/shortcuts/kglobalaccel.h ed68bba kdeui/shortcuts/kglobalaccel.cpp 36dbab7 kdeui/shortcuts/kglobalaccel_p.h 04feaba Diff: http://git.reviewboard.kde.org/r/109019/diff/ Testing --- Code compiles Thanks, Valentin Rusu ___ Kde-frameworks-devel

Fwd: Re: lib or lib64?

2013-02-16 Thread Valentin Rusu
On Saturday 16 February 2013 11:50:22 Alexander Neundorf wrote: > On Saturday 16 February 2013, Valentin Rusu wrote: > > On Friday 15 February 2013 21:52:31 Alexander Neundorf wrote: > > > On Friday 15 February 2013, Treeve Jelbert wrote: > > > > How can I f

Re: lib or lib64?

2013-02-16 Thread Valentin Rusu
rks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement) ___ Kde-frameworks-devel mailing list Kde

Re: Plans and status Frameworks5, Plasma2, Qt5 and Wayland

2013-01-19 Thread Valentin Rusu
DE 4.xx version on top of Qt5? Or that figure only refers to KWin's version? > > Cheers, Cheers, -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement) ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 107973: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-14 Thread Valentin Rusu
--- Code builds OK. KGestureMap is not actually used, though, as KGestureMap::eventFilter method return false right away. Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
h your suggestion, as it avoids introducing another symbol (ActionShapeGestures). - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review24635 ---

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
://git.reviewboard.kde.org/r/107973/diff/ Testing --- Code builds OK. KGestureMap is not actually used, though, as KGestureMap::eventFilter method return false right away. Thanks, Valentin Rusu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2012-12-30 Thread Valentin Rusu
kdeui/shortcuts/kgesturemap.h 56b42b6 kdeui/shortcuts/kgesturemap.cpp 1350dbe Diff: http://git.reviewboard.kde.org/r/107973/diff/ Testing --- Code builds OK. KGestureMap is not actually used, though, as KGestureMap::eventFilter method return false right away. Thanks, Valentin

  1   2   >