----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72750 -----------------------------------------------------------
Ship it! Looks goot to me. - Valentin Rusu On Dec. 29, 2014, 1:17 p.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120388/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 1:17 p.m.) > > > Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin > Rusu. > > > Repository: kwallet > > > Description > ------- > > 1. Create a new wallet "foo" > 2. immediately remove the 'kwalletd5' directory > 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which > will create "foo.kwl") > > Kwalletmanager still lists the wallet and new data can be added to the > wallet, but this data will be lost once the wallet is closed since the salt > has been deleted and therefore the wallet cannot be opened again. > > > Diffs > ----- > > src/runtime/kwalletd/backend/kwalletbackend.cc b072cec > src/runtime/kwalletd/kwalletd.h b94df15 > src/runtime/kwalletd/kwalletd.cpp 882eb72 > > Diff: https://git.reviewboard.kde.org/r/120388/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
