> On Feb. 21, 2013, 6:23 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kglobalaccel.h, line 267 > > <http://git.reviewboard.kde.org/r/109019/diff/2/?file=114644#file114644line267> > > > > Hm... I'm wondering, should this signal have a twin (both emitted at > > the same time) where we indicate the action linked to the shortcut when it > > changed? > > > > The old one being tied to KAction we had that information (knew the > > emitter), here the information is lost.
Good point! I missed that one - now fixed. > On Feb. 21, 2013, 6:23 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kglobalaccel.h, line 180 > > <http://git.reviewboard.kde.org/r/109019/diff/2/?file=114644#file114644line180> > > > > Please add apidox for those methods, don't forget the @since 5.0. Yep, documentation for these methods and also update KDE5PORTING.html BTW, KDE5PORTING.html should be renamed to KF5PORTING.html, if I correctly followed the issue on the mailing list. - Valentin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review27809 ----------------------------------------------------------- On Feb. 20, 2013, 10:32 p.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109019/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 10:32 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > KDELibs cleanup task: move global shortcut facilities from KAction to > KGlobalAccel. The second step, registering QActions instead of KActions, will > be done after completing this review. > > > Diffs > ----- > > kdeui/tests/kglobalshortcuttest.cpp 49fb8ec > kdeui/actions/kaction.h ddaa4de > kdeui/actions/kaction.cpp ec63a72 > kdeui/actions/kaction_p.h b50e678 > kdeui/actions/kactioncollection.cpp 555b204 > kdeui/dialogs/kshortcutseditoritem.cpp 5aa8437 > kdeui/shortcuts/kglobalaccel.h ed68bba > kdeui/shortcuts/kglobalaccel.cpp 36dbab7 > kdeui/shortcuts/kglobalaccel_p.h 04feaba > > Diff: http://git.reviewboard.kde.org/r/109019/diff/ > > > Testing > ------- > > Code compiles > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
