> On Feb. 27, 2013, 7:11 p.m., Kevin Ottens wrote: > > kdeui/actions/kaction.cpp, line 77 > > <http://git.reviewboard.kde.org/r/109019/diff/6/?file=116169#file116169line77> > > > > Please put the space before * and &, not after.
Old habits. However, watching code around this I see I'm not alone ;-) - Valentin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/#review28223 ----------------------------------------------------------- On Feb. 27, 2013, 7:20 p.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109019/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 7:20 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > KDELibs cleanup task: move global shortcut facilities from KAction to > KGlobalAccel. The second step, registering QActions instead of KActions, will > be done after completing this review. > > > Diffs > ----- > > KDE5PORTING.html e1b41d1 > kdeui/actions/kaction.h ddaa4de > kdeui/actions/kaction.cpp ec63a72 > kdeui/actions/kaction_p.h b50e678 > kdeui/shortcuts/kglobalaccel.h ed68bba > kdeui/shortcuts/kglobalaccel.cpp 36dbab7 > kdeui/shortcuts/kglobalaccel_p.h 04feaba > > Diff: http://git.reviewboard.kde.org/r/109019/diff/ > > > Testing > ------- > > Code compiles > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
