Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94450 --- Ship it! Ship It! - John Layt On April 7, 2016, 10:53

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94443 --- - John Layt On April 7, 2016, 10:53 p.m., Kai Uwe Broulik

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt
g/r/127253/#comment64162> Err, obviously I mean be BC, not BIC... - John Layt On March 2, 2016, 1:17 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt
tps://git.reviewboard.kde.org/r/127253/#comment64161> This can be added to the end of the Currency group and still be BIC, that's why each group is hard-coded to start at a 1000 interval. - John Layt On March 2, 2016, 1:17 a.m., Kai Uwe Br

KHolidays as Framework (redux)

2015-12-24 Thread John Layt
Hi, It's xmas holidays, so it must be time to poke a stick at KHolidays again for inclusion as a Framework. As far as I am aware there are no outstanding porting issues with KHolidays and it is ready for review to be included as a Tier 1 Framework in the next possible release. What's the next step

Re: Review Request 125343: bump so version from 5 to 6

2015-09-22 Thread John Layt
widget). - John Layt On Sept. 22, 2015, 9:02 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Proposal to improving KDE Software Repository Organization

2015-08-16 Thread John Layt
On 16 August 2015 at 11:14, David Faure wrote: > (*) I keep finding the "division" term a bit obscure, and I wonder if this > shouldn't be > called "product" instead. I.e. matching how we release things. Nowadays we > basically have 4 products (frameworks, plasma, applications, extragear?), > pr

Re: Default page size now missing

2015-07-29 Thread John Layt
On 29 July 2015 at 22:43, Jaroslaw Staniek wrote: > Hi, > While looking at possible improvements of QPageSize (with John), > another finding: > Defaults for page size for KDE SC 4 apps come from the locale based on > KLocale and specific config value. Now in QLocale we miss this > information. QPr

Re: split kdepimlibs

2014-08-27 Thread John Layt
On 26 August 2014 11:41, Jonathan Riddell wrote: > > I'd like to suggest taking the opportunity to remove uses of the quite ugly > term PIM in favour of the friendlier Kontact. I would say no. PIM in library names makes sense, especially as we want that others outside KDE-PIM / Kontact will use

Re: split kdepimlibs

2014-08-27 Thread John Layt
My general 2c: I'm with Kevin that we should do functional and api reviews, move code around, and generally refactor stuff *before* we split anything. It's just plain easier that way. I don't think we're anywhere near close to knowing what to do with everything to be splitting things yet. Will we

Re: KPlotting and KUnitConversion

2014-08-12 Thread John Layt
On 10 August 2014 23:20, Garret Wassermann wrote: > I am also curious who is the KUnitConversion maintainer as well. > Similarly, unit conversion software would be fantastic, > however it is missing many units and features. > > I would also be glad to work on either cleaning up KUnitConversion, >

Re: Web Shortcuts KCM

2014-07-14 Thread John Layt
On 14 July 2014 11:46, David Faure wrote: > On Monday 14 July 2014 12:34:44 Eike Hein wrote: >> Hi David, >> >> I'd like to port the ebrowsing KCM and move it to >> plasma-desktop or -workspace, since it has plenty >> of users outside of Konq (e.g. Konvi, Konsole and >> Okular, the first two of wh

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-09 Thread John Layt
On 9 July 2014 06:14, Kevin Ottens wrote: > Hello, > > On Wednesday 09 July 2014 09:57:27 Ben Cooksley wrote: >> On 9 July 2014 03:30, Kevin Ottens wrote: >> > * ervin hopes to see kdepimlibs bits getting in sooner rather than later; >> >> Hmm? Sysadmin has already received a request to get the

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-08 Thread John Layt
On 8 July 2014 16:30, Kevin Ottens wrote: > * he'd like our documentation to improve, we're really behind alternatives in > that regard; Seconded, especially from the point-of-view of external devs. For example, someone today was asking about KArchive and whether it was fully standalone or depe

Locale Name Primer

2014-06-07 Thread John Layt
Locale Names. A quick primer on Locale Names, seeing as we've had a few issues in the last couple of days. I can't claim perfect knowledge, so feel free to point out where I am wrong :-) TL;DR: * Don't use QLocale::bcp47Name(). * Use QLocale::name(), but may need to modify the results. * You usua

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-07 Thread John Layt
> On June 6, 2014, 12:21 p.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > <https://git.reviewboard.kde.org/r/118564/diff/1/?file=279088#file279088line98> > > > > The bcp47Name() is a complicated beast that could add lots of other > > bi

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-06 Thread John Layt
to add the needed languageCode() api for QT 5.4. - John Layt On June 5, 2014, 1:16 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

KUnitConversion apidox

2014-05-22 Thread John Layt
Hi, I've just noticed that the KUnitConversion api dox at http://api.kde.org/frameworks-api/frameworks5-apidocs/kunitconversion/html/index.html does not have a class list available not the individual classes. Have I missed something? Cheers! John. ___

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-06 Thread John Layt
ou keep the > > initial commit from the kunitconversion repository. > > John Layt wrote: > It was used by KLocale, the Locale KCM, KUnitConversion, and the finance > apps like KMyMoney and Skrooge. Klocale still needs it. The old Locale KCM > doesn't need modi

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-04 Thread John Layt
/kcurrencycode.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117888/diff/ Testing --- Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-01 Thread John Layt
PRE-CREATION > data/currency/vnd.desktop PRE-CREATION > data/currency/vuv.desktop PRE-CREATION > data/currency/wst.desktop PRE-CREATION > data/currency/xaf.desktop PRE-CREATION > data/currency/xag.desktop PRE-CREATION > data/curr

Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-04-29 Thread John Layt
--- Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread John Layt
te my changes to move this stuff into kdelibs4support, and then we can look at doing the same for the country locale files. - John Layt On April 29, 2014, 2:42 p.m., Jonathan Riddell wrote: > > --- > This is an automatically ge

Re: KF5 Maintainers: Please get ready for release

2014-04-29 Thread John Layt
On 29 April 2014 14:16, Alex Merry wrote: > > You are working on a separate branch as that wiki page suggests, right? > It wouldn't surpise me if using the --parent=master option from the > master branch gave you no changes. > I've tried both from the local master branch and a feature branch tra

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread John Layt
> On April 29, 2014, 1:45 p.m., Aleix Pol Gonzalez wrote: > > usually we're going more for kf5/ more than /kf5, meaning > > that those are the files in locale dedicated to currency. Note that > > share/currency is not a standard place anyway, so we are not being backward > > compatible. > > >

Re: KF5 Maintainers: Please get ready for release

2014-04-29 Thread John Layt
On 26 April 2014 23:32, Kevin Ottens wrote: > > John Layt: > - kunitconversion > The only thing left is the move of KCurrencyCode back to kdelibs4support. I've now done up patches, but I'm once again bamboozled by Reviewboard and post-review and feel like a total idiot.

Fwd: Proposal: Location hackfest

2014-04-07 Thread John Layt
: Zeeshan Ali (Khattak) Date: 2 April 2014 17:00 Subject: Proposal: Location hackfest To: John Layt , Aaron McCarthy < aaron.mccar...@jollamobile.com>, Hanno Schlichting Cc: Bastien Nocera , Ekaterina Gerasimova < kittykat3...@gmail.com> Hi everyone, I'm planning a combined hackfest

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-04-07 Thread John Layt
> On March 28, 2014, 3:43 p.m., David Faure wrote: > > Looks wrong, QLocale looks at .ts/.qm files while we mostly use .po/.gmo > > files - different translation system. > > > > Also doubly wrong because uiLanguages() returns the user preferences (e.g. > > for me "en, fr"), which has nothing t

Re: Status of the KDE Runtime module splitting

2014-04-07 Thread John Layt
On 7 April 2014 18:57, Aleix Pol wrote: > - l10n, localization: it was decided in this mailing list it would go to > kde4support when some development happens. Otherwise it should go to > KUnitConversion because it's only used there. besides KDE4Support. > Catching up after a couple of weeks awa

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-26 Thread John Layt
On 26 March 2014 20:08, Kevin Ottens wrote: > Hello, > > On Tuesday 25 March 2014 16:41:12 Jos Poortvliet wrote: >> Just imagine what header would you like to see on an announcement/article: >> * Frameworks 5 To Not Include Deprecated Technologies >> * KDE Porting Aids To Have Three Releases >> *

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread John Layt
On 17 March 2014 20:14, John Layt wrote: > I like the limit on kde4support, we only have to look to Qt3Support to > know that if the aids are left in place people will avoid porting away > from them until they absolutely have to. I'm not sure we need to call > it a "product

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread John Layt
On 17 March 2014 18:15, Kevin Ottens wrote: > So let's pick the following cocktail: 1, 2 and 4. > > That means we immediately move khtml and kde4support out of KDE Frameworks (to > be widely advertised) and into a KDE Porting Aids product (to be advertised > only to existing KDE developers). > > B

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread John Layt
On 17 March 2014 16:45, Alex Merry wrote: > On 17/03/14 15:25, Aurélien Gâteau wrote: >> What worries me with this approach is it feels like comparing apples and >> oranges here. To me a framework "tier" is about its dependencies, not >> about its maturity. I would suggest to instead introduce an

Plasma Next - Translations KCM - What Languages?

2014-03-14 Thread John Layt
Hi, I'm doing some more work on the new KCM for Translations, i.e. the KCM in Plasma Next to configure the LANGUAGE env var that startkde will export for all apps running under Plasma Next to use, including Gtk as well as Qt apps. Because this is now the workspace/desktop wide setting, and not

Re: Review Request 116615: Remove deprecated method languageForEncoding()

2014-03-05 Thread John Layt
0baedd28a72248a2ef974ff2ea539409a23fe0fd src/kcharsets.cpp b140074a82384111074ee9876048718c76b98523 Diff: https://git.reviewboard.kde.org/r/116615/diff/ Testing --- Autotests pass. Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 116615: Remove deprecated method languageForEncoding()

2014-03-05 Thread John Layt
://git.reviewboard.kde.org/r/116615/diff/ Testing --- Autotests pass. Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KGuiAddons Review

2014-03-04 Thread John Layt
Hi, Here's my first pass through KGuiAddons, focussing on the public api. KColorCollection - Should probably become a QSharedDataPointer KWorkdWrap - "// KDE5 TODO: return a value, not a pointer, and use QSharedDataPointer." KModifierKeyInfo - Generally looks OK - Has lots of "bool isKeyPress

KIdleTime Quick Review

2014-03-04 Thread John Layt
Hi, Nice simple one this, one public class, looks OK. Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need Wayland or systemd support eventually? Does have one TODO, but that's an implementation detail: "widgetbasedpoller.cpp # TODO: make optional, to avoid always depend

KCodecs - Quick Review

2014-03-04 Thread John Layt
Hi, I know nothing about text codecs, but I've had a *very* quick look at KCodecs: * Original code by Lars dated 1999! * One method marked as deprecated to be removed for KDE4 * "###FIXME KDE4: the name of the encodings should mostly be uppercase" * Code generated by script generate_string_table.

Re: KUnitConversion Review

2014-03-04 Thread John Layt
On 4 March 2014 15:59, Kevin Ottens wrote: > KGuiAddons definitely. The other two are important too, but this one is even > more important. OK, I'll get onto that then. John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://m

Re: KUnitConversion Review

2014-03-04 Thread John Layt
On 4 March 2014 09:25, Kevin Ottens wrote: > On Tuesday 04 March 2014 01:04:05 John Layt wrote: >> So, now KPrintUtils and KUnitConversion are about done (bar the >> KCurrencyCode move), are there any other Frameworks needing review? > > All the unmaintained ones, some of th

Re: KUnitConversion Review

2014-03-03 Thread John Layt
On 2 March 2014 19:58, Kevin Ottens wrote: > On Thursday 27 February 2014 17:15:56 John Layt wrote: >> * Try port away from ki18n to tr(). KUC makes extensive use of ki18nc() and >> ki18ncp(), but I need to check with Chusselove if all the plural >> translations can be hand

Re: KUnitConversion Review

2014-02-28 Thread John Layt
On 28 February 2014 10:52, Chusslove Illich wrote: >> [: John Layt :] >> * Try port away from ki18n to tr(). KUC makes extensive use of ki18nc() >> and ki18ncp(), but I need to check with Chusselove if all the plural >> translations can be handled with Qt or if any are

Re: kprintutils - next steps

2014-02-28 Thread John Layt
On 28 February 2014 14:14, Alex Merry wrote: > Given the alpha1 time constraints, I just pushed this. > > I'll leave dealing with the old repo to you (which I guess involves > filing a sysadmin request to remove it). > > David: kprintutils should not form part of alpha 1, since the code is > now

KUnitConversion Review

2014-02-27 Thread John Layt
Hi, I've been reviewing KUnitConversion (KUC for short) and doing some small clean-ups, and I'm slowly coming to the conclusion I'm not a fan of the api. However it is used in a few places, so rather than try rewrite the api in the time remaining, I'll finish up the clean-ups and we can releas

Re: kprintutils - next steps

2014-02-27 Thread John Layt
On 23 February 2014 20:02, John Layt wrote: > I believe the steps required are: > > 1) Port existing apps that are already ported to KF5 away from > KdePrint::createPrintDialog(): > - Okteta > - kfontinst > - ktexteditor > - None use KPrintPreview This has been done

Re: Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116051/#review50858 --- Ship it! Ship It! - John Layt On Feb. 25, 2014, 5:22 p.m

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread John Layt
On 23 February 2014 20:15, Harald Fernengel wrote: > Hi, > > TL;DR > > Do we want to do build KDE Frameworks as Mac OS X Frameworks? I think so, at least for the ones we want to be viewed as proper Qt Add-ons, it would enlarge our possible user-base. From experience in Qt the hard part is keepin

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread John Layt
On 23 February 2014 20:15, Harald Fernengel wrote: > TL;DR > > Do we want to do build KDE Frameworks as Mac OS X Frameworks? I think so, at least for the ones we want to be viewed as proper Qt Add-ons, it would enlarge our possible user-base. From experience in Qt the hard part is keeping the i

kprintutils - next steps

2014-02-23 Thread John Layt
Hi, I've just merged my clean-ups for kprintutils to remove everything not needed due to the changes in Qt5. Basically what is now left is so minimal that I see no benefit in keeping it as a framework and propose we move it to kde4support instead. There are two parts to kprintutils: 1) The K

Re: Figuring out kde-runtime: localization

2014-02-23 Thread John Layt
On 23 February 2014 17:31, Albert Astals Cid wrote: > El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: >> >> In KF5 both KLocale and KCurrencyCode are in kde4support > > KCurrencyCode is in kunitconversion. Ah, so it is, had missed that :-) So I gue

Re: Building frameworks: docbook problems

2014-02-23 Thread John Layt
On 7 February 2014 10:01, David Faure wrote: > On Monday 03 February 2014 22:08:20 Andriy Rysin wrote: >> I am trying to build frameworks using >> http://community.kde.org/Frameworks/Building on Fedora 20 and it failes >> in several modules due to some docbook problem, e.g. in kconfigwidgets: >> >

Re: Figuring out kde-runtime: localization

2014-02-23 Thread John Layt
On 21 February 2014 13:17, Aleix Pol wrote: > Hi, > Going through the information we have in kde-runtime [1] we found there are > two subdirectories related to localization (localization and l10n) that we > couldn't find a correct place to move to. > > Can anybody give us a hand and help us figure

kguiaddons uses qpa headers?

2014-02-23 Thread John Layt
Hi, I'm building all of Frameworks from scratch for the first time, using the openSUSE packages for Qt 5.2, and qguiaddons fails with: [ 24%] Building CXX object src/CMakeFiles/KF5GuiAddons.dir/util/kmodifierkeyinfoprovider_x11.cpp.o /media/build/kdesrc- build/src/k5/frameworks/kguiaddons/src/u

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-15 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review49828 --- Ship it! Ship It! - John Layt On Feb. 15, 2014, 12:37 p.m

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-15 Thread John Layt
> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread John Layt
> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread John Layt
with "#defined Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No point in compiling the CUPS code if we're never going to use it. Once Qt feature freeze kicks in I'll have time to review all this code properly and it's likely most of it wil

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:52, Alex Merry wrote: > If these additions are something that applications would need to be > aware of, I see no issue with creating a wrapper class or some such > as-and-when we find a use for one. > > If they are something that would be hidden to applications, would you > c

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 8 January 2014 07:17, Kevin Ottens wrote: > For the record, if that depends on QtPrintSupport it can't make it to > KGuiAddons (which should depend only on QtCore and QtGui). Good point :-) > I'm fine keeping it even if it's small. OK, I'll take the chainsaw to it this weekend and see what

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:30, Michal Humpula wrote: > If I may post a little input here. I've implemented print preview in kate > (KF5) with QPrintPreviewDialog, mainly for the reasons mentioned above. But > what I'm missing is ability to add custom configuration tabs as in > KdePrint::createPrintDial

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 7 January 2014 19:49, Kevin Ottens wrote: >> Most of the >> dialog code from there has been merged into Qt5.2, or is planned for >> Qt 5.3, so needs deleting. I'm also wondering if we still need our >> own KPrintPreview dialog, there was a reason in 4.0 but I can't >> remember why now and I'm

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 7 January 2014 19:55, Albert Astals Cid wrote: > El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure: >> On 07/01/14 17:10, John Layt wrote: >> > I've put myself down (rather obviously) for KPrintUtils. Most of the >> > dialog code from ther

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 6 January 2014 07:52, Kevin Ottens wrote: > I urge everyone, and in particular people volunteering to maintain a > framework, to do a pass of review of our code base and APIs to modernize them > when appropriate. It is a very big task, and in no way can be coordinated in > the way we've been w

Re: Framework metadata

2013-12-19 Thread John Layt
On 19 December 2013 08:47, Cornelius Schumacher wrote: > On Wednesday 18 December 2013 Aurélien Gâteau wrote: >> >> The information in the DOAP file can also be used to generate manifest >> files for Inqlude (http://inqlude.org/) > > For this to work we need at least the following data in the DOAP

Re: Framework metadata

2013-12-19 Thread John Layt
On 19 December 2013 08:47, Cornelius Schumacher wrote: > On Wednesday 18 December 2013 Aurélien Gâteau wrote: >> >> The information in the DOAP file can also be used to generate manifest >> files for Inqlude (http://inqlude.org/) > > For this to work we need at least the following data in the DOAP

Re: Review Request 114187: KFormat - Add new KFormat class

2013-12-12 Thread John Layt
g --- Autotests copied from KLocale tests and improved. Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114187: KFormat - Add new KFormat class

2013-11-28 Thread John Layt
mat.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114187/diff/ Testing --- Autotests copied from KLocale tests and improved.

Re: Dot story on KDE contributions to Qt 5.2

2013-11-24 Thread John Layt
On 24 November 2013 19:34, David Faure wrote: > > Is this supposed to be "added for Qt 5.2" only, or "added in Qt 5.0, 5.1 and > 5.2"? > This email says the former, but the document contains a lot of the earlier > stuff (mimetypes, qstandardpaths, ...) > > See the above doc for more, I wrote more

Re: [Kde-pim] PIM Sprint: Porting PIM to Frameworks

2013-11-20 Thread John Layt
On 19 November 2013 22:59, Stephen Kelly wrote: > John Layt wrote: > Those TODO tasks are very 'vertical'. Many tasks, and most useful tasks in > frameworks porting, are horizontal. The horizontal tasks should largely be > done before the vertical ones. Horizontal

Re: [Kde-pim] PIM Sprint: Porting PIM to Frameworks

2013-11-20 Thread John Layt
On 19 November 2013 22:59, Stephen Kelly wrote: > John Layt wrote: > Those TODO tasks are very 'vertical'. Many tasks, and most useful tasks in > frameworks porting, are horizontal. The horizontal tasks should largely be > done before the vertical ones. Horizontal

PIM Sprint: Porting PIM to Frameworks

2013-11-19 Thread John Layt
Hi, At the PIM Sprint a major topic discussed was the plans for migrating to Qt5 / KF5, in particular how and when to convert from "kdepimlibs" to "PIM Frameworks". I've started a wiki page to document the process required and to co-ordinate the tasks at http://community.kde.org/Frameworks/Epics/

Re: KF5 Update Meeting Minutes 2013-w47

2013-11-19 Thread John Layt
On 19 November 2013 16:53, Kevin Ottens wrote: > Announcement: > * We're not yet ready for the splitting so it's postponed by a week; > * Please get open tasks done; At the PIM Sprint Alex passed the byte formatting TODO on to me which I've started coding, I'll try push a review in a couple of

Dot story on KDE contributions to Qt 5.2

2013-11-16 Thread John Layt
Hi, There was a discussion on the promo list a couple of weeks back about doing a Dot story to coincide with the release of Qt 5.2 highlighting KDE's contributions. Jos started an Etherpad at https://notes.kde.org/p/Platform5DotStoryForQt52 for notes on this story. If you've made a contribution

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43331 --- Ship it! Ship It! - John Layt On Oct. 22, 2013, 4:49 p.m

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread John Layt
> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first,

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread John Layt
o return the current system time zone and the list of available time zones, and on other platforms just wrap the Qt calls. Opinions? - John Layt On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: > > --- > This is an automatical

Re: Flaky kcodecs test depending on qt configuration

2013-10-28 Thread John Layt
On Thursday 24 Oct 2013 07:35:48 Kevin Ottens wrote: > Hello, > > On Wednesday 23 October 2013 21:43:59 Sune Vuorela wrote: > > Depending on the Qt configuration (built with or without ICU), the > > KCharsetsTest::testEncodingNames() test fails (in the #if) block. > > > > If Qt built with ICU, th

Re: Porting away from KLocale

2013-10-24 Thread John Layt
On 24 October 2013 07:33, Kevin Ottens wrote: > On Wednesday 23 October 2013 20:40:19 John Layt wrote: >> * The obviously place to move it is k18n, as either part of >> KLocalizedString or in a new KByteFormatter class? > > Hm, wouldn't that fit in KCoreAddons? >>

Re: Keep the Things You Forgot

2013-10-24 Thread John Layt
On 24 October 2013 14:54, Mario Fux KDE ML wrote: >> You probably mean dot.kde.org/2013/09/25/frameworks-5 > > And this: > http://dot.kde.org/2013/09/04/kde-release-structure-evolves Yes, that explains Frameworks and Workspaces, albeit a little fuzzy on Workspaces vs Plasma, but it kinda leaves

Re: Keep the Things You Forgot

2013-10-23 Thread John Layt
On 23 October 2013 21:49, Mark wrote: > A blog post that i'd very much like from you (Aaron) is about the next > big KDE version, the naming and how the complete collection is going > to be called or if there even will be a collection release (what KDE > SC is now). Press is still getting that wr

Re: Porting away from KLocale

2013-10-23 Thread John Layt
On 23 October 2013 12:56, Aleix Pol wrote: > On Tue, Oct 22, 2013 at 2:03 PM, David Faure wrote: >> >> On Thursday 17 October 2013 23:47:40 Aleix Pol wrote: >> > Well maybe I could help with this, but I'd need to know what do you >> > think >> > it would be the most appropriate solution. >> >> I'

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread John Layt
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only sup

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-20 Thread John Layt
zone path tree (/usr/share/zoneinfo or wherever) is updated, or for Windows if any of the registry database is updated (I can do that later). - John Layt On Oct. 18, 2013, 1 p.m., Martin Klapetek wrote: > > --- > This is an auto

Re: Porting away from KLocale

2013-10-17 Thread John Layt
On 17 October 2013 01:51, Aleix Pol wrote: > Hi, > I was trying to port some application to Qt/KF5, then I realized that I > didn't know how to port KLocale::formatByteSize. I don't see anything in > QLocale for this, so I feel a bit stuck. Also I don't see any information in > KDE5Porting.html >

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-16 Thread John Layt
anged, but I can't guarantee it will get in so we still need the daemon for now. - John Layt On Oct. 15, 2013, 8:09 p.m., Martin Klapetek wrote: > > --- > This is an automatically generat

Re: QTimeZone merged for 5.2

2013-10-14 Thread John Layt
On 14 October 2013 12:55, Kevin Ottens wrote: > Giving it a closer look, I'm wondering: are you sure about this course of > action? > KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted > together. So deprecating those two without deprecating KDateTimeEdit sounds > weird to me.

Re: QTimeZone merged for 5.2

2013-10-14 Thread John Layt
On 14 October 2013 12:55, Kevin Ottens wrote: > Giving it a closer look, I'm wondering: are you sure about this course of > action? > KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted > together. So deprecating those two without deprecating KDateTimeEdit sounds > weird to me

Re: QTimeZone merged for 5.2

2013-10-03 Thread John Layt
On 24 September 2013 19:24, Kevin Ottens wrote: > On Tuesday 24 September 2013 19:03:21 John Layt wrote: >> I'll do some analysis on the use of all the widgets and what ones are >> worth keeping, and look at the Qt widgets to see if they're worth >> switching to, if

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-30 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41026 --- Ship it! Ship It! - John Layt On Sept. 25, 2013, 4:50 p.m

Re: QTimeZone merged for 5.2

2013-09-27 Thread John Layt
On 27 September 2013 16:52, Kevin Ottens wrote: > On Wednesday 25 September 2013 11:28:54 John Layt wrote: >> Started to look at the number of uses, but lxr hardly shows any. Does >> lxr include .ui files, or do I need to grep? > > I don't think it does unfortunately.

Re: QTimeZone merged for 5.2

2013-09-27 Thread John Layt
On 25 September 2013 17:21, Mark wrote: > >> >> I've been >> talking to the QML component guys and they will have a new calendar >> component for 5.3 that they need QCalendarSystem for as well. > > > > Hi John, > > What you said there sounds very interesting to me! Do you have any link for > me

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-25 Thread John Layt
ttp://git.reviewboard.kde.org/r/112935/#comment29986> Pedantic. Can we keep the parms all lined up with first line? Same for all below. Ta! - John Layt On Sept. 25, 2013, 3:21 p.m., Martin Klapetek wrote: > > --- > This is an automatica

Re: QTimeZone merged for 5.2

2013-09-25 Thread John Layt
On 24 September 2013 19:24, Kevin Ottens wrote: > On Tuesday 24 September 2013 19:03:21 John Layt wrote: >> I'll do some analysis on the use of all the widgets and what ones are >> worth keeping, and look at the Qt widgets to see if they're worth >> switching to, if

Re: QTimeZone merged for 5.2

2013-09-24 Thread John Layt
On 24 September 2013 12:11, Kevin Ottens wrote: >> OK, let's attempt to move KLocale, KDateTime and friends to kde4support now. >> With some luck we'll be able to completely get rid of KDE4Attic before >> release. > > Hmm, looking at that closer... indeed it looks like we can get rid of > K*TimeZo

Re: Review Request 112909: Remove KDE print stuff that has been ported to Qt5

2013-09-24 Thread John Layt
the rationale behind KPrintPreview to see if we really need it still. - John Layt On Sept. 23, 2013, 6:47 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To r

Re: Qt Dev Days Stuff

2013-09-23 Thread John Layt
On 19 September 2013 15:34, John Layt wrote: > Qt Dev Days is short on Lightning Talks, so if you have a Qt-related > topic you want to present or demo for up to 10 minutes, please submit > it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow. I've submitted a talk c

QTimeZone merged for 5.2

2013-09-23 Thread John Layt
Hi, I am extremely relived to announce that QTimeZone finally got merged late late last night, thanks to the efforts of Thiago in fighting the CI system :-) Combined with other changes in QDateTime, this should mean we're free of KDateTime and KTimeZone, albeit with a few caveats. I'll be doing

Qt Dev Days Stuff

2013-09-19 Thread John Layt
Hi, Qt Dev Days is short on Lightning Talks, so if you have a Qt-related topic you want to present or demo for up to 10 minutes, please submit it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow. I'd especially like to see a KF5 lightning talk focussed on the libraries we will be rel

Re: Fwd: Print Dialog - next steps

2013-09-19 Thread John Layt
On 18 September 2013 08:18, David Faure wrote: > On Monday 09 September 2013 14:07:31 Martin Klapetek wrote: >> 5) In KF5 the KdePrintDialog stuff can either be removed entirely, or more >> conservatively modified to no longer insert the extra KDE Cups widgets and >> modifications so they don't ap

  1   2   >