----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review40772 -----------------------------------------------------------
staging/kde4attic/src/kdeprintdialog.h <http://git.reviewboard.kde.org/r/112935/#comment29986> Pedantic. Can we keep the parms all lined up with first line? Same for all below. Ta! - John Layt On Sept. 25, 2013, 3:21 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112935/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 3:21 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Description > ------- > > Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some > changes like KComboBox -> QComboBox etc and also removes couple of image > icons, which are no longer needed (was part of a feature merged in qt). > > Will do separate commits. > > > Diffs > ----- > > staging/kde4attic/src/kcupsoptionsjobwidget_p.h > staging/kde4attic/src/CMakeLists.txt 74ecc39 > staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b > staging/kde4attic/src/kcupsoptionspageswidget_p.h > staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 > staging/kde4attic/src/kcupsoptionssettingswidget_p.h > staging/kde4attic/src/kcupsoptionswidget_p.h > staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf > staging/kde4attic/src/kdeprint_nup1.png 9f13429 > staging/kde4attic/src/kdeprint_nup2.png 7289a7e > staging/kde4attic/src/kdeprint_nup4.png b03a539 > staging/kde4attic/src/kdeprint_nupother.png 5a7c385 > staging/kde4attic/src/kdeprintdialog.h 5d9cd25 > staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 > staging/kprintutils/src/CMakeLists.txt a2e56c9 > staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112935/diff/ > > > Testing > ------- > > Builds > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
