Hi, Here's my first pass through KGuiAddons, focussing on the public api.
KColorCollection - Should probably become a QSharedDataPointer KWorkdWrap - "// KDE5 TODO: return a value, not a pointer, and use QSharedDataPointer." KModifierKeyInfo - Generally looks OK - Has lots of "bool isKeyPressed(Qt::Key)" style methods and keyPressed(Qt::Key, bool) style signals when perhaps a KeyState enum would be better? - Uses X11 / XKB / XCB, will need Wayland backend eventually? - Perhaps really belongs in Qt, or somewhere else? KImageCache KSharedPixmapCacheMixin KLocalImageCacheImplementation - Looks OK - KImageCache not exported, but KLocalImageCacheImplementation is, some CMake magic involved? KColorMimeData KFontUtils KIconUtils - Looks OK KColorUtils - Looks OK - Qt should probably get some of these methods? KDateValidator - Looks OK - Qt should probably have one, QTime as well? And the usual documentation improvements of course. Otherwise looks in good shape. Cheers! John. _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
