> On April 30, 2014, 1:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it. > > > > Also, I disagree that there's nothing interesting in the history. Most of > > the interesting stuff is in the kdelibs history, but that can be grafted on > > if the commit is constructed properly -- in particular, if you keep the > > initial commit from the kunitconversion repository. > > John Layt wrote: > It was used by KLocale, the Locale KCM, KUnitConversion, and the finance > apps like KMyMoney and Skrooge. Klocale still needs it. The old Locale KCM > doesn't need modifying as it already links to kdelibs4support and the > includes don't use the framework name. KUnitConversion no longer uses it > hence the move. The apps are a long way starting from a port. > > Not sure why it should be marked deprecated, isn't that the whole point > of kdelibs4support? I don't see other classes in kdelibs4support like > KLocale marked in that way? For porting there is no alternative to the class > as yet, that's coming in the new KStandards framework I'm writing, but I can > make a note of that. > > I don't know how to do the history move, I had asked on list a few times > for it to be moved but no-one has done so, so I decided it was better to at > least have it moved to the right place before it's too late (i.e. tomorrow). > > Alex Merry wrote: > I can do it for you if you like. > > The advantage of marking it deprecated is that the compiler tells you > about the deprecated usage. Of course, you can just remove KDELibs4Support > from the link targets and then fix the build, but this makes it easier to do > it piecemeal. Things in KDELibs4Support should, in general, be marked > deprecated, but not all of them are. > > Alex Merry wrote: > Merge done, and files removed from KUnitConversion.
Thanks Alex! - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117888/#review56981 ----------------------------------------------------------- On May 4, 2014, 9:29 p.m., John Layt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117888/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 9:29 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > ------- > > KCurrencyCode is not needed in KUnitConversion and imposes an unneeded > dependency on KConfigCore, so move it to kdelibs4support back with the > rest of KLocale. Note no attempt has been made to move the history as > there was nothing of significance. > > > Diffs > ----- > > CMakeLists.txt ff8199e8b80078d40b403800230448ad1a7c85c9 > data/CMakeLists.txt PRE-CREATION > data/currency/CMakeLists.txt PRE-CREATION > data/currency/adf.desktop PRE-CREATION > data/currency/adp.desktop PRE-CREATION > data/currency/aed.desktop PRE-CREATION > data/currency/afa.desktop PRE-CREATION > data/currency/afn.desktop PRE-CREATION > data/currency/all.desktop PRE-CREATION > data/currency/amd.desktop PRE-CREATION > data/currency/ang.desktop PRE-CREATION > data/currency/aoa.desktop PRE-CREATION > data/currency/aon.desktop PRE-CREATION > data/currency/ars.desktop PRE-CREATION > data/currency/ats.desktop PRE-CREATION > data/currency/aud.desktop PRE-CREATION > data/currency/awg.desktop PRE-CREATION > data/currency/azm.desktop PRE-CREATION > data/currency/azn.desktop PRE-CREATION > data/currency/bam.desktop PRE-CREATION > data/currency/bbd.desktop PRE-CREATION > data/currency/bdt.desktop PRE-CREATION > data/currency/bef.desktop PRE-CREATION > data/currency/bgl.desktop PRE-CREATION > data/currency/bgn.desktop PRE-CREATION > data/currency/bhd.desktop PRE-CREATION > data/currency/bif.desktop PRE-CREATION > data/currency/bmd.desktop PRE-CREATION > data/currency/bnd.desktop PRE-CREATION > data/currency/bob.desktop PRE-CREATION > data/currency/bov.desktop PRE-CREATION > data/currency/brl.desktop PRE-CREATION > data/currency/bsd.desktop PRE-CREATION > data/currency/btn.desktop PRE-CREATION > data/currency/bwp.desktop PRE-CREATION > data/currency/byr.desktop PRE-CREATION > data/currency/bzd.desktop PRE-CREATION > data/currency/cad.desktop PRE-CREATION > data/currency/cdf.desktop PRE-CREATION > data/currency/chf.desktop PRE-CREATION > data/currency/clf.desktop PRE-CREATION > data/currency/clp.desktop PRE-CREATION > data/currency/cny.desktop PRE-CREATION > data/currency/cop.desktop PRE-CREATION > data/currency/cou.desktop PRE-CREATION > data/currency/crc.desktop PRE-CREATION > data/currency/cuc.desktop PRE-CREATION > data/currency/cup.desktop PRE-CREATION > data/currency/cve.desktop PRE-CREATION > data/currency/cyp.desktop PRE-CREATION > data/currency/czk.desktop PRE-CREATION > data/currency/dem.desktop PRE-CREATION > data/currency/djf.desktop PRE-CREATION > data/currency/dkk.desktop PRE-CREATION > data/currency/dop.desktop PRE-CREATION > data/currency/dzd.desktop PRE-CREATION > data/currency/eek.desktop PRE-CREATION > data/currency/egp.desktop PRE-CREATION > data/currency/ern.desktop PRE-CREATION > data/currency/esp.desktop PRE-CREATION > data/currency/etb.desktop PRE-CREATION > data/currency/eur.desktop PRE-CREATION > data/currency/fim.desktop PRE-CREATION > data/currency/fjd.desktop PRE-CREATION > data/currency/fkp.desktop PRE-CREATION > data/currency/frf.desktop PRE-CREATION > data/currency/gbp.desktop PRE-CREATION > data/currency/gel.desktop PRE-CREATION > data/currency/ghc.desktop PRE-CREATION > data/currency/ghs.desktop PRE-CREATION > data/currency/gip.desktop PRE-CREATION > data/currency/gmd.desktop PRE-CREATION > data/currency/gnf.desktop PRE-CREATION > data/currency/grd.desktop PRE-CREATION > data/currency/gtq.desktop PRE-CREATION > data/currency/gwp.desktop PRE-CREATION > data/currency/gyd.desktop PRE-CREATION > data/currency/hkd.desktop PRE-CREATION > data/currency/hnl.desktop PRE-CREATION > data/currency/hrk.desktop PRE-CREATION > data/currency/htg.desktop PRE-CREATION > data/currency/huf.desktop PRE-CREATION > data/currency/idr.desktop PRE-CREATION > data/currency/iep.desktop PRE-CREATION > data/currency/ils.desktop PRE-CREATION > data/currency/inr.desktop PRE-CREATION > data/currency/iqd.desktop PRE-CREATION > data/currency/irr.desktop PRE-CREATION > data/currency/isk.desktop PRE-CREATION > data/currency/itl.desktop PRE-CREATION > data/currency/jmd.desktop PRE-CREATION > data/currency/jod.desktop PRE-CREATION > data/currency/jpy.desktop PRE-CREATION > data/currency/kes.desktop PRE-CREATION > data/currency/kgs.desktop PRE-CREATION > data/currency/khr.desktop PRE-CREATION > data/currency/kmf.desktop PRE-CREATION > data/currency/kpw.desktop PRE-CREATION > data/currency/krw.desktop PRE-CREATION > data/currency/kwd.desktop PRE-CREATION > data/currency/kyd.desktop PRE-CREATION > data/currency/kzt.desktop PRE-CREATION > data/currency/lak.desktop PRE-CREATION > data/currency/lbp.desktop PRE-CREATION > data/currency/lkr.desktop PRE-CREATION > data/currency/lrd.desktop PRE-CREATION > data/currency/lsl.desktop PRE-CREATION > data/currency/ltl.desktop PRE-CREATION > data/currency/luf.desktop PRE-CREATION > data/currency/lvl.desktop PRE-CREATION > data/currency/lyd.desktop PRE-CREATION > data/currency/mad.desktop PRE-CREATION > data/currency/mdl.desktop PRE-CREATION > data/currency/mga.desktop PRE-CREATION > data/currency/mgf.desktop PRE-CREATION > data/currency/mkd.desktop PRE-CREATION > data/currency/mlf.desktop PRE-CREATION > data/currency/mmk.desktop PRE-CREATION > data/currency/mnt.desktop PRE-CREATION > data/currency/mop.desktop PRE-CREATION > data/currency/mro.desktop PRE-CREATION > data/currency/mtl.desktop PRE-CREATION > data/currency/mur.desktop PRE-CREATION > data/currency/mvr.desktop PRE-CREATION > data/currency/mwk.desktop PRE-CREATION > data/currency/mxn.desktop PRE-CREATION > data/currency/mxv.desktop PRE-CREATION > data/currency/myr.desktop PRE-CREATION > data/currency/mzm.desktop PRE-CREATION > data/currency/mzn.desktop PRE-CREATION > data/currency/nad.desktop PRE-CREATION > data/currency/ngn.desktop PRE-CREATION > data/currency/nio.desktop PRE-CREATION > data/currency/nlg.desktop PRE-CREATION > data/currency/nok.desktop PRE-CREATION > data/currency/npr.desktop PRE-CREATION > data/currency/nzd.desktop PRE-CREATION > data/currency/omr.desktop PRE-CREATION > data/currency/pab.desktop PRE-CREATION > data/currency/pen.desktop PRE-CREATION > data/currency/pgk.desktop PRE-CREATION > data/currency/php.desktop PRE-CREATION > data/currency/pkr.desktop PRE-CREATION > data/currency/pln.desktop PRE-CREATION > data/currency/pte.desktop PRE-CREATION > data/currency/pyg.desktop PRE-CREATION > data/currency/qar.desktop PRE-CREATION > data/currency/rol.desktop PRE-CREATION > data/currency/ron.desktop PRE-CREATION > data/currency/rsd.desktop PRE-CREATION > data/currency/rub.desktop PRE-CREATION > data/currency/rur.desktop PRE-CREATION > data/currency/rwf.desktop PRE-CREATION > data/currency/sar.desktop PRE-CREATION > data/currency/sbd.desktop PRE-CREATION > data/currency/scr.desktop PRE-CREATION > data/currency/sdd.desktop PRE-CREATION > data/currency/sdg.desktop PRE-CREATION > data/currency/sek.desktop PRE-CREATION > data/currency/sgd.desktop PRE-CREATION > data/currency/shp.desktop PRE-CREATION > data/currency/sit.desktop PRE-CREATION > data/currency/skk.desktop PRE-CREATION > data/currency/sll.desktop PRE-CREATION > data/currency/sos.desktop PRE-CREATION > data/currency/srd.desktop PRE-CREATION > data/currency/srg.desktop PRE-CREATION > data/currency/ssp.desktop PRE-CREATION > data/currency/std.desktop PRE-CREATION > data/currency/svc.desktop PRE-CREATION > data/currency/syp.desktop PRE-CREATION > data/currency/szl.desktop PRE-CREATION > data/currency/thb.desktop PRE-CREATION > data/currency/tjs.desktop PRE-CREATION > data/currency/tmm.desktop PRE-CREATION > data/currency/tmt.desktop PRE-CREATION > data/currency/tnd.desktop PRE-CREATION > data/currency/top.desktop PRE-CREATION > data/currency/tpe.desktop PRE-CREATION > data/currency/trl.desktop PRE-CREATION > data/currency/try.desktop PRE-CREATION > data/currency/ttd.desktop PRE-CREATION > data/currency/twd.desktop PRE-CREATION > data/currency/tzs.desktop PRE-CREATION > data/currency/uah.desktop PRE-CREATION > data/currency/ugx.desktop PRE-CREATION > data/currency/usd.desktop PRE-CREATION > data/currency/usn.desktop PRE-CREATION > data/currency/uss.desktop PRE-CREATION > data/currency/uyu.desktop PRE-CREATION > data/currency/uzs.desktop PRE-CREATION > data/currency/veb.desktop PRE-CREATION > data/currency/vnd.desktop PRE-CREATION > data/currency/vuv.desktop PRE-CREATION > data/currency/wst.desktop PRE-CREATION > data/currency/xaf.desktop PRE-CREATION > data/currency/xag.desktop PRE-CREATION > data/currency/xau.desktop PRE-CREATION > data/currency/xcd.desktop PRE-CREATION > data/currency/xof.desktop PRE-CREATION > data/currency/xpd.desktop PRE-CREATION > data/currency/xpf.desktop PRE-CREATION > data/currency/xpt.desktop PRE-CREATION > data/currency/yer.desktop PRE-CREATION > data/currency/yum.desktop PRE-CREATION > data/currency/zar.desktop PRE-CREATION > data/currency/zmk.desktop PRE-CREATION > data/currency/zwd.desktop PRE-CREATION > data/currency/zwl.desktop PRE-CREATION > src/CMakeLists.txt 1db2612bdc625b7267d31ce773ecfdcddc6ae045 > src/kdecore/kcurrencycode.h PRE-CREATION > src/kdecore/kcurrencycode.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117888/diff/ > > > Testing > ------- > > > Thanks, > > John Layt > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
